[PATCH] D73388: NFC: Implement AST node skipping in ParentMapContext

2020-01-26 Thread Stephen Kelly via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rGf29204d3: NFC: Implement AST node skipping in ParentMapContext (authored by stephenkelly). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D73388/new/ http

[PATCH] D73388: NFC: Implement AST node skipping in ParentMapContext

2020-01-25 Thread Stephen Kelly via Phabricator via cfe-commits
steveire added a comment. In D73388#1840100 , @rsmith wrote: > This seems reasonable to me. > > If you want to unify something about this and the `Ignore*` functions in > `Expr`, maybe we could add a "classify" mechanism, so you could ask "what > kind of

[PATCH] D73388: NFC: Implement AST node skipping in ParentMapContext

2020-01-24 Thread Richard Smith - zygoloid via Phabricator via cfe-commits
rsmith accepted this revision. rsmith added a comment. This revision is now accepted and ready to land. This seems reasonable to me. If you want to unify something about this and the `Ignore*` functions in `Expr`, maybe we could add a "classify" mechanism, so you could ask "what kind of node is