[PATCH] D73667: Speed up compilation of ASTImporter

This revision was automatically updated to reflect the committed changes. Closed by commit rGaf3e88495627: Speed up compilation of ASTImporter (authored by rnk). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D73667/new/ https://reviews.llvm.org/D7366

[PATCH] D73667: Speed up compilation of ASTImporter

martong accepted this revision. martong added a comment. This revision is now accepted and ready to land. Thanks for the patch! Looks good to me! Comment at: clang/lib/AST/ASTImporter.cpp:192 + // Don't attempt to import nodes if we hit an error earlier. + if (Err) +

[PATCH] D73667: Speed up compilation of ASTImporter

merge_guards_bot added a comment. {icon times-circle color=red} Unit tests: fail. 62308 tests passed, 1 failed and 838 were skipped. failed: libc++.std/thread/futures/futures_async/async.pass.cpp {icon check-circle color=green} clang-tidy: pass. {icon check-circle color=green} clang-format:

[PATCH] D73667: Speed up compilation of ASTImporter

merge_guards_bot added a comment. {icon check-circle color=green} Unit tests: pass. 62309 tests passed, 0 failed and 838 were skipped. {icon check-circle color=green} clang-tidy: pass. {icon check-circle color=green} clang-format: pass. Build artifacts

[PATCH] D73667: Speed up compilation of ASTImporter

rnk added a comment. The `Expected>` and `std::tie` instantiations are still expensive, and they seem avoidable. We could use this code pattern instead: ExpectedType ASTNodeImporter::VisitVariableArrayType(const VariableArrayType *T) { QualType ToElementType = T->getElementType(); E

[PATCH] D73667: Speed up compilation of ASTImporter

rnk updated this revision to Diff 241297. rnk added a comment. Herald added a subscriber: rnkovacs. - remove unintended hack to test MSVC Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D73667/new/ https://reviews.llvm.org/D73667 Files: clang/lib/A

[PATCH] D73667: Speed up compilation of ASTImporter

rnk created this revision. rnk added reviewers: rsmith, aaron.ballman. Herald added a reviewer: martong. Herald added a reviewer: a.sidorin. Herald added a reviewer: shafik. Herald added subscribers: llvm-commits, teemperor. Herald added projects: clang, LLVM. rnk updated this revision to Diff 2412