[PATCH] D74907: libclang: Make shared object symbol exporting by default

thakis added a comment. Looks like things are still broken in several ways even with this in: [2600/2950] Linking CXX executable bin\c-index-test.exe FAILED: bin/c-index-test.exe cmd.exe /C "cd . && C:\b\s\w\ir\cache\builder\src\third_party\llvm-build-tools\cmake-3.12.1-win32-x86\bin\cm

[PATCH] D74907: libclang: Make shared object symbol exporting by default

cristian.adam added a comment. Thank you! A build with `-DLIBCLANG_BUILD_STATIC=ON` and `-DLLVM_ENABLE_PIC=OFF` is green at: https://github.com/cristianadam/llvm-project/actions/runs/42545217 The default build with `-DLIBCLANG_BUILD_STATIC=OFF` and `-DLLVM_ENABLE_PIC=ON` is green at: https:/

[PATCH] D74907: libclang: Make shared object symbol exporting by default

This revision was automatically updated to reflect the committed changes. Closed by commit rG7a7c753b0cca: libclang: Make shared object symbol exporting by default (authored by cristian.adam, committed by thakis). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.

[PATCH] D74907: libclang: Make shared object symbol exporting by default

thakis accepted this revision. thakis added a comment. Thanks! Let me try landing this and see what happens :) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D74907/new/ https://reviews.llvm.org/D74907 _

[PATCH] D74907: libclang: Make shared object symbol exporting by default

cristian.adam added a comment. > The problem is (I believe) that `add_clang_library(libclang ` is passed > `${ENABLE_SHARED}` and that used to be true on Windows but no longer is after > your change (due to the change in line 80 in your original change), so > libclang.dll isn't built at all any

[PATCH] D74907: libclang: Make shared object symbol exporting by default

cristian.adam added a comment. > The problem is (I believe) that `add_clang_library(libclang ` is passed > `${ENABLE_SHARED}` and that used to be true on Windows but no longer is after > your change (due to the change in line 80 in your original change), so > libclang.dll isn't built at all any

[PATCH] D74907: libclang: Make shared object symbol exporting by default

cristian.adam updated this revision to Diff 245683. cristian.adam added a comment. `-DLLVM_ENABLE_PIC=OFF` on Windows if `LIBCLANG_BUILD_STATIC` is not set to `ON` will generate a SHARED libclang.dll Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D7

[PATCH] D74907: libclang: Make shared object symbol exporting by default

thakis added a comment. In D74907#1884842 , @cristian.adam wrote: > In D74907#1884795 , @thakis wrote: > > > Thanks! Does this make it so that libclang.dll is built again with > > -DLLVM_ENABLE_PIC=NO on Window? F

[PATCH] D74907: libclang: Make shared object symbol exporting by default

cristian.adam added a comment. I do not have commit rights, I need help to submit this patch. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D74907/new/ https://reviews.llvm.org/D74907 ___ cfe-commits ma

[PATCH] D74907: libclang: Make shared object symbol exporting by default

cristian.adam added a comment. In D74907#1884795 , @thakis wrote: > Thanks! Does this make it so that libclang.dll is built again with > -DLLVM_ENABLE_PIC=NO on Window? From what I understand, it doesn't. Is that > correct? If so, could you reinstantiate

[PATCH] D74907: libclang: Make shared object symbol exporting by default

cristian.adam marked an inline comment as done. cristian.adam added inline comments. Comment at: clang/include/clang-c/Platform.h:33 #endif -#elif defined(CINDEX_EXPORTS) +#elif defined(CINDEX_EXPORTS) && defined(__GNUC__) #define CINDEX_LINKAGE __attribute__((visibility("d

[PATCH] D74907: libclang: Make shared object symbol exporting by default

thakis accepted this revision. thakis added a comment. This revision is now accepted and ready to land. Thanks! Does this make it so that libclang.dll is built again with -DLLVM_ENABLE_PIC=NO on Window? From what I understand, it doesn't. Is that correct? If so, could you reinstantiate that too?

[PATCH] D74907: libclang: Make shared object symbol exporting by default

cristian.adam created this revision. cristian.adam added reviewers: yvvan, mstorsjo, thakis. Herald added subscribers: cfe-commits, mgorny. Herald added a project: clang. https://reviews.llvm.org/D74564 enabled static building for libclang, and for non CMake consumers they had to set the `CMAKE_E