[PATCH] D76342: [OpenMP] Implement '#pragma omp tile'

clementval added a comment. A fix is ready hereL https://reviews.llvm.org/D96808 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D76342/new/ https://reviews.llvm.org/D76342 ___ cfe-commits mailing list

[PATCH] D76342: [OpenMP] Implement '#pragma omp tile'

clementval added a comment. @Meinersbur This patch is making Flang buildbots failing. Since you have added a clause in `OMP.td` you have to add lines here as well ->

[PATCH] D76342: [OpenMP] Implement '#pragma omp tile'

ABataev added a comment. In D76342#2565945 , @Meinersbur wrote: > In D76342#2565686 , @ABataev wrote: > >> I can commit it as soon as you accepted it if you don't mind of course. > > I do not mind Ok, will commit

[PATCH] D76342: [OpenMP] Implement '#pragma omp tile'

Meinersbur added a comment. In D76342#2565686 , @ABataev wrote: > I can commit it as soon as you accepted it if you don't mind of course. I do not mind Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D76342: [OpenMP] Implement '#pragma omp tile'

ABataev added a comment. In D76342#2562097 , @Meinersbur wrote: > Who is going to commit? I can commit it as soon as you accepted it if you don't mind of course. Comment at: clang/include/clang/AST/StmtOpenMP.h:651-677 + static bool

[PATCH] D76342: [OpenMP] Implement '#pragma omp tile'

Meinersbur accepted this revision. Meinersbur added a comment. This revision is now accepted and ready to land. Who is going to commit? Comment at: clang/include/clang/AST/StmtOpenMP.h:651-677 + static bool + doForAllLoops(Stmt *CurStmt, bool TryImperfectlyNestedLoops, +

[PATCH] D76342: [OpenMP] Implement '#pragma omp tile'

ABataev added a comment. Just a note: >> 4.b. still feels like a hack because there are captures variables outside of >> any CapturedStmt and therefore complicated the AST. Comparable directive >> such as master don't do this. It is not a hack, this was an optimization to minimize the number

[PATCH] D76342: [OpenMP] Implement '#pragma omp tile'

Meinersbur added inline comments. Comment at: clang/include/clang/AST/StmtOpenMP.h:448 + /// Number of collapsed loops as specified by 'collapse' clause. + unsigned CollapsedNum = 0; + ABataev wrote: > Meinersbur wrote: > > Inaccurate for the tile directive. >

[PATCH] D76342: [OpenMP] Implement '#pragma omp tile'

ABataev added a comment. In D76342#2535321 , @Meinersbur wrote: > Thank you for the update. > > From comparing the diffs, here is the list of main changes I found: > > 1. Create `OMPLoopBasedDirective` as a new base class for OMPLoopDirective > (and

[PATCH] D76342: [OpenMP] Implement '#pragma omp tile'

Meinersbur added a comment. Thank you for the update. From comparing the diffs, here is the list of main changes I found: 1. Create `OMPLoopBasedDirective` as a new base class for OMPLoopDirective (and OMPTileDirective) for CollapsedNum and some utility methods for analyzing the

[PATCH] D76342: [OpenMP] Implement '#pragma omp tile'

Meinersbur added a comment. Thank you Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D76342/new/ https://reviews.llvm.org/D76342 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D76342: [OpenMP] Implement '#pragma omp tile'

ABataev added a comment. In D76342#2262414 , @Meinersbur wrote: > Rebase after D83261 I will try to adapt it to the new interface (it won't work for `simd`, still need to capture the variables) and will send the patch

[PATCH] D76342: [OpenMP] Implement '#pragma omp tile'

Meinersbur added a comment. ping @ABataev Have you checked the alternative scheme? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D76342/new/ https://reviews.llvm.org/D76342 ___ cfe-commits mailing

[PATCH] D76342: [OpenMP] Implement '#pragma omp tile'

ABataev added a comment. In D76342#2128739 , @Meinersbur wrote: > ping > > @ABataev Have you checked the alternative scheme? Working on it, need a little bit more time. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D76342: [OpenMP] Implement '#pragma omp tile'

ABataev added inline comments. Comment at: clang/include/clang/AST/StmtOpenMP.h:4781-4784 +/// This represents the '#pragma omp tile' loop transformation directive. +class OMPTileDirective final +: public OMPLoopDirective, + private llvm::TrailingObjects {

[PATCH] D76342: [OpenMP] Implement '#pragma omp tile'

Meinersbur marked an inline comment as done. Meinersbur added inline comments. Comment at: clang/include/clang/AST/StmtOpenMP.h:4781-4784 +/// This represents the '#pragma omp tile' loop transformation directive. +class OMPTileDirective final +: public OMPLoopDirective, +

[PATCH] D76342: [OpenMP] Implement '#pragma omp tile'

ABataev added inline comments. Comment at: clang/include/clang/AST/StmtOpenMP.h:4781-4784 +/// This represents the '#pragma omp tile' loop transformation directive. +class OMPTileDirective final +: public OMPLoopDirective, + private llvm::TrailingObjects {

[PATCH] D76342: [OpenMP] Implement '#pragma omp tile'

Meinersbur marked an inline comment as done. Meinersbur added inline comments. Comment at: clang/include/clang/AST/StmtOpenMP.h:4781-4784 +/// This represents the '#pragma omp tile' loop transformation directive. +class OMPTileDirective final +: public OMPLoopDirective, +

[PATCH] D76342: [OpenMP] Implement '#pragma omp tile'

ABataev added inline comments. Comment at: clang/include/clang/AST/StmtOpenMP.h:4781-4784 +/// This represents the '#pragma omp tile' loop transformation directive. +class OMPTileDirective final +: public OMPLoopDirective, + private llvm::TrailingObjects {

[PATCH] D76342: [OpenMP] Implement '#pragma omp tile'

Meinersbur added a comment. ping Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D76342/new/ https://reviews.llvm.org/D76342 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D76342: [OpenMP] Implement '#pragma omp tile'

Meinersbur added a comment. Herald added a subscriber: sstefan1. ping Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D76342/new/ https://reviews.llvm.org/D76342 ___ cfe-commits mailing list

[PATCH] D76342: [OpenMP] Implement '#pragma omp tile'

Meinersbur added a comment. Herald added a reviewer: DavidTruby. Herald added a project: LLVM. Herald added a subscriber: llvm-commits. ping Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D76342/new/ https://reviews.llvm.org/D76342

[PATCH] D76342: [OpenMP] Implement '#pragma omp tile'

Meinersbur marked an inline comment as done. Meinersbur added inline comments. Comment at: clang/include/clang/AST/StmtOpenMP.h:4781-4784 +/// This represents the '#pragma omp tile' loop transformation directive. +class OMPTileDirective final +: public OMPLoopDirective, +

[PATCH] D76342: [OpenMP] Implement '#pragma omp tile'

ABataev added inline comments. Comment at: clang/include/clang/AST/StmtOpenMP.h:4781-4784 +/// This represents the '#pragma omp tile' loop transformation directive. +class OMPTileDirective final +: public OMPLoopDirective, + private llvm::TrailingObjects {

[PATCH] D76342: [OpenMP] Implement '#pragma omp tile'

Meinersbur added a comment. pong Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D76342/new/ https://reviews.llvm.org/D76342 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D76342: [OpenMP] Implement '#pragma omp tile'

Meinersbur added a comment. Herald added a subscriber: yaxunl. ping Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D76342/new/ https://reviews.llvm.org/D76342 ___ cfe-commits mailing list

[PATCH] D76342: [OpenMP] Implement '#pragma omp tile'

Meinersbur added a comment. ping Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D76342/new/ https://reviews.llvm.org/D76342 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D76342: [OpenMP] Implement '#pragma omp tile'

Meinersbur added a comment. In D76342#1941591 , @JonChesterfield wrote: > edit: actually you've already done the clang-format on trunk as I hoped, > phabricator mislead me. Apologies for the noise The previous diff was against a branch with only the

[PATCH] D76342: [OpenMP] Implement '#pragma omp tile'

JonChesterfield added a comment. edit: actually you've already done the clang-format on trunk as I hoped, phabricator mislead me. Apologies for the noise Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D76342/new/ https://reviews.llvm.org/D76342

[PATCH] D76342: [OpenMP] Implement '#pragma omp tile'

Meinersbur added a comment. ping Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D76342/new/ https://reviews.llvm.org/D76342 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

RE: [PATCH] D76342: [OpenMP] Implement '#pragma omp tile'

.in...@gmail.com Subject: [PATCH] D76342: [OpenMP] Implement '#pragma omp tile' Meinersbur created this revision. Meinersbur added reviewers: ABataev, jdoerfert, hfinkel, tlwilmar, hbae, protze.joachim, AndreyChurbanov, RaviNarayanaswamy, JonChesterfield, grokos. Herald added subscribers: arphaman