[PATCH] D76948: [cuda][hip] Add CUDA builtin surface/texture reference support.

tra added a comment. In D76948#1946878 , @hliao wrote: > I tried that before submitting this one. But, as it's in the closed state, I > cannot submit that anymore. I will attach the difference against the previous > change somewhere. I've reopened it.

[PATCH] D76948: [cuda][hip] Add CUDA builtin surface/texture reference support.

hliao marked an inline comment as done. hliao added inline comments. Comment at: clang/test/SemaCUDA/bad-attributes.cu:74-75 + +typedef __attribute__((device_builtin_surface_type)) unsigned long long s0_ty; // expected-warning {{'device_builtin_surface_type' attribute only appli

[PATCH] D76948: [cuda][hip] Add CUDA builtin surface/texture reference support.

hliao added a comment. In D76948#1946861 , @tra wrote: > Would it be possible to update the old review with the new diff? It would > make it easier to see the incremental changes you've made. If the old review > can be reopened that would be great as it

[PATCH] D76948: [cuda][hip] Add CUDA builtin surface/texture reference support.

hliao added a comment. In D76948#1946861 , @tra wrote: > Would it be possible to update the old review with the new diff? It would > make it easier to see the incremental changes you've made. If the old review > can be reopened that would be great as it

[PATCH] D76948: [cuda][hip] Add CUDA builtin surface/texture reference support.

tra added a comment. Would it be possible to update the old review with the new diff? It would make it easier to see the incremental changes you've made. If the old review can be reopened that would be great as it would keep all relevant info in one place, but I'm fine doing the review here, to

[PATCH] D76948: [cuda][hip] Add CUDA builtin surface/texture reference support.

hliao added a comment. This's revised change from https://reviews.llvm.org/D76365 after fixing Sema checks on the template partial specialization. With this change, I could compile the following sample code using surface reference. kernel.cu #include surface surf; #if defined(__cl

[PATCH] D76948: [cuda][hip] Add CUDA builtin surface/texture reference support.

hliao created this revision. hliao added reviewers: tra, rjmccall, yaxunl. Herald added a reviewer: a.sidorin. Herald added a project: clang. Herald added a subscriber: cfe-commits. hliao added a comment. This's revised change from https://reviews.llvm.org/D76365 after fixing Sema checks on the t