[PATCH] D76990: [clang-tidy]: fix false positive of cert-oop54-cpp check.

This revision was automatically updated to reflect the committed changes. Closed by commit rG0f9e1e3ae750: [clang-tidy]: fix false positive of cert-oop54-cpp check. (authored by ztamas). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D76990/new/

[PATCH] D76990: [clang-tidy]: fix false positive of cert-oop54-cpp check.

ztamas updated this revision to Diff 255038. ztamas added a comment. Add suggested test case and rebase. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D76990/new/ https://reviews.llvm.org/D76990 Files:

[PATCH] D76990: [clang-tidy]: fix false positive of cert-oop54-cpp check.

aaron.ballman accepted this revision. aaron.ballman added a comment. This revision is now accepted and ready to land. LGTM with a testing request. I agree that the Clang AST is a bit surprising, but not so surprising that I could definitely call it a bug. Comment at:

[PATCH] D76990: [clang-tidy]: fix false positive of cert-oop54-cpp check.

ztamas updated this revision to Diff 253438. ztamas added a comment. Remove false TODO comment. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D76990/new/ https://reviews.llvm.org/D76990 Files:

[PATCH] D76990: [clang-tidy]: fix false positive of cert-oop54-cpp check.

njames93 added a comment. In D76990#1948516 , @ztamas wrote: > I agree, it seems suspicious that a BinaryOperator matcher does not work in > this case. However, I'm working on this level of the code, I'm looking at the > matchers like an API, what I'm

[PATCH] D76990: [clang-tidy]: fix false positive of cert-oop54-cpp check.

ztamas added a comment. In D76990#1948286 , @njames93 wrote: > I'm not entirely sure this is where the fix needs to be for this. The test > case code is whacky as hell, but from what I can see clang should always emit > a `BinaryOperator` for dependent

[PATCH] D76990: [clang-tidy]: fix false positive of cert-oop54-cpp check.

ztamas updated this revision to Diff 253412. ztamas added a comment. Rebase, TODO comment, remove unrelated change. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D76990/new/ https://reviews.llvm.org/D76990 Files:

[PATCH] D76990: [clang-tidy]: fix false positive of cert-oop54-cpp check.

njames93 added a comment. I'm not entirely sure this is where the fix needs to be for this. The test case code is whacky as hell, but from what I can see clang should always emit a `BinaryOperator` for dependent type operators. No idea why it is spewing out a `CXXOperatorCallExpr` instead.

[PATCH] D76990: [clang-tidy]: fix false positive of cert-oop54-cpp check.

ztamas updated this revision to Diff 253354. ztamas added a comment. Run clang-format on test code. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D76990/new/ https://reviews.llvm.org/D76990 Files:

[PATCH] D76990: [clang-tidy]: fix false positive of cert-oop54-cpp check.

ztamas created this revision. Herald added subscribers: cfe-commits, xazax.hun. Herald added a project: clang. ztamas edited the summary of this revision. ztamas added a reviewer: aaron.ballman. It seems we need a different matcher for binary operator in a template context. Fixes this issue: