nigelp-xmos marked an inline comment as done.
nigelp-xmos added inline comments.
Comment at: clang/test/CodeGen/xcore-unused-inline.c:4
+
+inline void dead_function(void) {}
erichkeane wrote:
> What is this test validating? It should likely have a check line of
erichkeane added a comment.
The test needs work (check/check-not lines+ filecheck), otherwise I think this
should be alright, particularly if no one else has commented in a while. I'd
like to have you upload an updated test validating what you think should be
happening before approving
nigelp-xmos added a comment.
Ping. I made the change suggested by @erichkeane .
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D77068/new/
https://reviews.llvm.org/D77068
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
nigelp-xmos updated this revision to Diff 264827.
nigelp-xmos added a comment.
As suggested by FIXME comment in code, and review comment, moved the
EmitTargetMetadata loop into XCore target.
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D77068/new/
https://reviews.llvm.org/D77068
nigelp-xmos added a comment.
Thanks for the comment, I will look into that.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D77068/new/
https://reviews.llvm.org/D77068
___
cfe-commits mailing list
erichkeane added a comment.
It doesn't seem like it would be much work to move the EmitTargetMetadata
function into the TargetInfo object (as a virtual function taking a reference
to the collection). Essentially, have this take a reference to the collection
instead of the 'D' and 'GV'.
I say
nigelp-xmos added reviewers: jasonliu, erichkeane, RKSimon, jhibbits, ctetreau,
george.burgess.iv, efriedma.
nigelp-xmos added a comment.
Adding code reviewer suggestions from git history. I would be grateful for
review and/or reviewer suggestions. Many thanks.
Repository:
rG LLVM Github
nigelp-xmos added a comment.
This patches fixes two Clang tests which are failing for XCore target on
2020-04-27 with "unexpected null value" assert failures:
CodeGen/2003-12-14-ExternInlineSupport.c
CoverageMapping/unused_names.c
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST
nigelp-xmos added a comment.
Ping.
Just a polite ping to keep it alive. I hope that's all right. Not urgent at all.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D77068/new/
https://reviews.llvm.org/D77068
nigelp-xmos created this revision.
nigelp-xmos added a reviewer: rsmith.
nigelp-xmos added a project: clang.
EmitTargetMetadata passes to emitTargetMD a null pointer as returned from
GetGlobalValue for an unused inline function which has been removed from the
module at that point.
Richard
10 matches
Mail list logo
