[PATCH] D78118: [analyzer] StdLibraryFunctionsChecker: Add option to display loaded summaries

martong created this revision. martong added reviewers: NoQ, Szelethus, baloghadamsoftware, balazske. Herald added subscribers: cfe-commits, ASDenysPetrov, steakhal, Charusso, gamesh411, dkrupp, donat.nagy, mikhail.ramalho, a.sidorin, rnkovacs, szepet, xazax.hun, whisperity. Herald added a projec

[PATCH] D78118: [analyzer] StdLibraryFunctionsChecker: Add option to display loaded summaries

Szelethus added a comment. This is a great idea, but the tests just seem to, well, test the new functionality? On a different issue, take a look at how certain help related frontend flags (not `-analyzer-config` ones!) skip the analysis, like `-analyzer-checker-help`, or `-analyzer-list-enable

[PATCH] D78118: [analyzer] StdLibraryFunctionsChecker: Add option to display loaded summaries

balazske added a comment. The new option will simply list the (found) functions that have a summary based check enabled. (The term "Loaded" may be misleading in the current implementation, somebody can think if it is loaded from file?) A more detailed output would be better (display the signatu

[PATCH] D78118: [analyzer] StdLibraryFunctionsChecker: Add option to display loaded summaries

This revision was automatically updated to reflect the committed changes. Closed by commit rGff4492c89feb: [analyzer] StdLibraryFunctionsChecker: Add option to display loaded summaries (authored by martong). Changed prior to commit: https://reviews.llvm.org/D78118?vs=260930&id=263992#toc Repos

[PATCH] D78118: [analyzer] StdLibraryFunctionsChecker: Add option to display loaded summaries

martong updated this revision to Diff 260647. martong added a comment. - Rebase to master - Add the option to the lit test analyzer-config.c Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D78118/new/ https://reviews.llvm.org/D78118 Files: clang/in

[PATCH] D78118: [analyzer] StdLibraryFunctionsChecker: Add option to display loaded summaries

martong updated this revision to Diff 260651. martong added a comment. - Better description for the option in Checkers.td Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D78118/new/ https://reviews.llvm.org/D78118 Files: clang/include/clang/StaticA

[PATCH] D78118: [analyzer] StdLibraryFunctionsChecker: Add option to display loaded summaries

martong added a comment. In D78118#1981592 , @Szelethus wrote: > This is a great idea, but the tests just seem to, well, test the new > functionality? > > On a different issue, take a look at how certain help related frontend flags > (not `-analyzer-conf

[PATCH] D78118: [analyzer] StdLibraryFunctionsChecker: Add option to display loaded summaries

martong marked an inline comment as done. martong added inline comments. Comment at: clang/include/clang/StaticAnalyzer/Checkers/Checkers.td:299 + "DisplayLoadedSummaries", + "If set to true, the checker displays all loaded summaries.", +

[PATCH] D78118: [analyzer] StdLibraryFunctionsChecker: Add option to display loaded summaries

martong added a comment. In D78118#1988464 , @balazske wrote: > The new option will simply list the (found) functions that have a summary > based check enabled. (The term "Loaded" may be misleading in the current > implementation, somebody can think if i

[PATCH] D78118: [analyzer] StdLibraryFunctionsChecker: Add option to display loaded summaries

martong updated this revision to Diff 260687. martong added a comment. - Handle and test the display of signatures Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D78118/new/ https://reviews.llvm.org/D78118 Files: clang/include/clang/StaticAnalyzer

[PATCH] D78118: [analyzer] StdLibraryFunctionsChecker: Add option to display loaded summaries

martong added a comment. In D78118#2007943 , @martong wrote: > In D78118#1988464 , @balazske wrote: > > > The new option will simply list the (found) functions that have a summary > > based check enabled. (The term

[PATCH] D78118: [analyzer] StdLibraryFunctionsChecker: Add option to display loaded summaries

martong added a comment. > This is a great idea, but the tests just seem to, well, test the new > functionality? I updated the patch so now we have a new RUN line that checks with FileCheck. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D78118/new/

[PATCH] D78118: [analyzer] StdLibraryFunctionsChecker: Add option to display loaded summaries

balazske added inline comments. Comment at: clang/lib/StaticAnalyzer/Checkers/StdLibraryFunctionsChecker.cpp:651 +// Get the declaration of a function proto as written in the source file. +StringRef ToString(const FunctionDecl *FD) { + const auto &SM = ACtx.getSource

[PATCH] D78118: [analyzer] StdLibraryFunctionsChecker: Add option to display loaded summaries

martong marked 4 inline comments as done. martong added inline comments. Comment at: clang/lib/StaticAnalyzer/Checkers/StdLibraryFunctionsChecker.cpp:651 +// Get the declaration of a function proto as written in the source file. +StringRef ToString(const FunctionDecl *FD)

[PATCH] D78118: [analyzer] StdLibraryFunctionsChecker: Add option to display loaded summaries

martong updated this revision to Diff 260930. martong marked 2 inline comments as done. martong added a comment. - Use Decl::print and 'for: ' Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D78118/new/ https://reviews.llvm.org/D78118 Files: clang/

[PATCH] D78118: [analyzer] StdLibraryFunctionsChecker: Add option to display loaded summaries

Szelethus added a comment. It would be nice to have a user-facing option that lists the functions this checker is **capable** of modeling in another patch :) Comment at: clang/include/clang/StaticAnalyzer/Checkers/Checkers.td:299 + "DisplayLoadedSummaries", +

[PATCH] D78118: [analyzer] StdLibraryFunctionsChecker: Add option to display loaded summaries

xazax.hun accepted this revision. xazax.hun added a comment. This revision is now accepted and ready to land. LGTM! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D78118/new/ https://reviews.llvm.org/D78118