[PATCH] D78979: OpenCL: Include builtin header by default

Anastasia added a comment. The new review: https://reviews.llvm.org/D96515 CHANGES SINCE LAST ACTION https://reviews.llvm.org/D78979/new/ https://reviews.llvm.org/D78979 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D78979: OpenCL: Include builtin header by default

Anastasia added a comment. In D78979#2536661 , @arsenm wrote: > In D78979#2536590 , @Anastasia wrote: > >> @arsenm I would like to see if we can finalize this patch soon. Do you think >> you will have a capacity

[PATCH] D78979: OpenCL: Include builtin header by default

arsenm added a comment. In D78979#2536590 , @Anastasia wrote: > @arsenm I would like to see if we can finalize this patch soon. Do you think > you will have a capacity for this in the next weeks? Otherwise I would be > happy to help too. I don't think

[PATCH] D78979: OpenCL: Include builtin header by default

Anastasia added a comment. Herald added a reviewer: jansvoboda11. @arsenm I would like to see if we can finalize this patch soon. Do you think you will have a capacity for this in the next weeks? Otherwise I would be happy to help too. It looks in a good shape, we just need to decide if we go

[PATCH] D78979: OpenCL: Include builtin header by default

arsenm updated this revision to Diff 292275. arsenm added a comment. Herald added subscribers: wenlei, dang. Rebase CHANGES SINCE LAST ACTION https://reviews.llvm.org/D78979/new/ https://reviews.llvm.org/D78979 Files: clang/include/clang/Driver/Options.td

[PATCH] D78979: OpenCL: Include builtin header by default

Anastasia added a comment. In D78979#2015214 , @arsenm wrote: > In D78979#2010739 , @Anastasia wrote: > > > In D78979#2010527 , @svenvh wrote: > > > > > In D78979#2007643

[PATCH] D78979: OpenCL: Include builtin header by default

arsenm added a comment. In D78979#2010739 , @Anastasia wrote: > In D78979#2010527 , @svenvh wrote: > > > In D78979#2007643 , @Anastasia > > wrote: > > > > > > Would it not

[PATCH] D78979: OpenCL: Include builtin header by default

arsenm added a comment. In D78979#2011582 , @jvesely wrote: > In D78979#2006901 , @yaxunl wrote: > > > In D78979#2006847 , @arsenm wrote: > > > > > I'm also wondering if

[PATCH] D78979: OpenCL: Include builtin header by default

Anastasia added a comment. In D78979#2011582 , @jvesely wrote: > In D78979#2006901 , @yaxunl wrote: > > > In D78979#2006847 , @arsenm wrote: > > > > > I'm also wondering if

[PATCH] D78979: OpenCL: Include builtin header by default

jvesely added a comment. In D78979#2006901 , @yaxunl wrote: > In D78979#2006847 , @arsenm wrote: > > > I'm also wondering if using -nogpulib for the corresponding linker purpose > > was correct, since in the

[PATCH] D78979: OpenCL: Include builtin header by default

Anastasia added a comment. In D78979#2010527 , @svenvh wrote: > In D78979#2007643 , @Anastasia wrote: > > > > Would it not become confusing since the builtins are going to be included > > > by default? Should we

[PATCH] D78979: OpenCL: Include builtin header by default

Anastasia added a comment. In D78979#2007760 , @yaxunl wrote: > In D78979#2007643 , @Anastasia wrote: > > > ah I guess if we leave it under `-cc1 ` we will have the command line > > interface as follows: > > > > -

[PATCH] D78979: OpenCL: Include builtin header by default

svenvh added a comment. In D78979#2007643 , @Anastasia wrote: > > Would it not become confusing since the builtins are going to be included > > by default? Should we rename the flag at least? Also ideally it should be > > documented in

[PATCH] D78979: OpenCL: Include builtin header by default

arsenm added a comment. In D78979#2007356 , @Anastasia wrote: > > I'm somewhat confused by the way this is supposed to work, or why a > > separate option exists for OpenCL. The other language flags seem to be > > implemented in the driver, not cc1 like

[PATCH] D78979: OpenCL: Include builtin header by default

yaxunl added a comment. In D78979#2007643 , @Anastasia wrote: > ah I guess if we leave it under `-cc1 ` we will have the command line > interface as follows: > > - Driver (without `-cc1`) adds OpenCL header by default that can be > overridden by the

[PATCH] D78979: OpenCL: Include builtin header by default

Anastasia added a comment. In D78979#2007563 , @Anastasia wrote: > > > > > >> I am looping in @svenvh to discuss this further. Sven, do you think we > >> should rename this flag due to current proposed change? Should it be moved > >> out of `-cc1`

[PATCH] D78979: OpenCL: Include builtin header by default

Anastasia added a comment. > > >> I am looping in @svenvh to discuss this further. Sven, do you think we >> should rename this flag due to current proposed change? Should it be moved >> out of `-cc1` too? > > I would leave `-fdeclare-opencl-builtins` as it is, until it is complete and >

[PATCH] D78979: OpenCL: Include builtin header by default

svenvh added a comment. In D78979#2007356 , @Anastasia wrote: > Originally we didn't want to include the header by default for 2 reasons: > > 1. Many vendors used their own header. > 2. It takes long time to parse the header. > > However, we might be in

[PATCH] D78979: OpenCL: Include builtin header by default

Anastasia added a subscriber: svenvh. Anastasia added a comment. > I'm somewhat confused by the way this is supposed to work, or why a > separate option exists for OpenCL. The other language flags seem to be > implemented in the driver, not cc1 like OpenCL. I'm not sure this is > the right set

[PATCH] D78979: OpenCL: Include builtin header by default

yaxunl added a comment. In D78979#2006847 , @arsenm wrote: > I'm also wondering if using -nogpulib for the corresponding linker purpose > was correct, since in the OpenCL case it's not really an offload target. > Maybe this should switch to -nostdlib?

[PATCH] D78979: OpenCL: Include builtin header by default

arsenm added a comment. I'm also wondering if using -nogpulib for the corresponding linker purpose was correct, since in the OpenCL case it's not really an offload target. Maybe this should switch to -nostdlib? CHANGES SINCE LAST ACTION https://reviews.llvm.org/D78979/new/

[PATCH] D78979: OpenCL: Include builtin header by default

arsenm created this revision. arsenm added reviewers: Anastasia, yaxunl. Herald added subscribers: kerbowa, nhaehnle, wdng, jvesely. arsenm added a comment. I'm also wondering if using -nogpulib for the corresponding linker purpose was correct, since in the OpenCL case it's not really an offload