This revision was automatically updated to reflect the committed changes.
Closed by commit rGc98c94d85f85: [clang-tidy] Add diagnostics level to YAML
output (authored by DmitryPolukhin).
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D79285/new/
https
DmitryPolukhin added a comment.
@aaron.ballman thank you for review and quick response!
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D79285/new/
https://reviews.llvm.org/D79285
___
cfe-commits mailing
aaron.ballman accepted this revision.
aaron.ballman added a comment.
This revision is now accepted and ready to land.
LGTM!
Comment at: clang/include/clang/Tooling/DiagnosticsYaml.h:109
+ static void enumeration(IO &IO, clang::tooling::Diagnostic::Level &Value) {
+IO.enumC
DmitryPolukhin marked an inline comment as done.
DmitryPolukhin added inline comments.
Comment at: clang/include/clang/Tooling/DiagnosticsYaml.h:109
+ static void enumeration(IO &IO, clang::tooling::Diagnostic::Level &Value) {
+IO.enumCase(Value, "Warning", clang::tooling::D
aaron.ballman added inline comments.
Comment at: clang/include/clang/Tooling/DiagnosticsYaml.h:109
+ static void enumeration(IO &IO, clang::tooling::Diagnostic::Level &Value) {
+IO.enumCase(Value, "Warning", clang::tooling::Diagnostic::Warning);
+IO.enumCase(Value, "Erro
DmitryPolukhin added a reviewer: aaron.ballman.
DmitryPolukhin added a subscriber: aaron.ballman.
DmitryPolukhin added a comment.
@alexfh, @gribozavr2, @aaron.ballman - friendly ping, please take a look to
this diff. It is just trivial implementation of TODO in the code.
Repository:
rG LLVM G
DmitryPolukhin added a comment.
@alexfh and @gribozavr2 friendly ping could you please take a look
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D79285/new/
https://reviews.llvm.org/D79285
___
cfe-commi
DmitryPolukhin created this revision.
DmitryPolukhin added reviewers: alexfh, gribozavr2.
DmitryPolukhin added projects: clang-tools-extra, clang.
Herald added a subscriber: xazax.hun.
Also added BuildDirectory for completness and removed unused `Fix`.
Test Plan: check-all
Repository:
rG LLVM
