[PATCH] D82654: [libTooling] Improve error message from failure in selection Stencil

This revision was automatically updated to reflect the committed changes. Closed by commit rG30deabf89f93: [libTooling] Improve error message from failure in selection Stencil (authored by ymandel). Changed prior to commit: https://reviews.llvm.org/D82654?vs=273706=273763#toc Repository: rG

[PATCH] D82654: [libTooling] Improve error message from failure in selection Stencil

gribozavr2 added a comment. > I generally avoid testing error message content in tests, but I know there's > a variety of opinions on this subject... If you thought that the quality of the error message matters enough to improve it, then it is worth testing the message, I think. Repository:

[PATCH] D82654: [libTooling] Improve error message from failure in selection Stencil

ymandel added a comment. In D82654#2116906 , @gribozavr2 wrote: > Any chance for a test? StencilTest.CatOfInvalidRangeFails essentially covers this (indeed, earlier versions of the code failed this test).

[PATCH] D82654: [libTooling] Improve error message from failure in selection Stencil

gribozavr2 accepted this revision. gribozavr2 added a comment. This revision is now accepted and ready to land. Any chance for a test? Comment at: clang/lib/Tooling/Transformer/Stencil.cpp:244 + llvm::make_error_code(errc::invalid_argument) && +

[PATCH] D82654: [libTooling] Improve error message from failure in selection Stencil

ymandel created this revision. ymandel added a reviewer: gribozavr2. Herald added a project: clang. This patch improves the error message provided by the stencil that handles source from a range selector. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D82654 Files: