eduucaldas added inline comments.
Comment at: clang/lib/Tooling/Syntax/BuildTree.cpp:188
+ case OO_Comma:
+ case OO_ArrowStar:
+return syntax::NodeKind::UnknownExpression;
Actually arrow star is treated like a normal binary operator in the [[
https://eel.i
gribozavr2 added inline comments.
Comment at: clang/lib/Tooling/Syntax/BuildTree.cpp:118
+syntax::NodeKind getOperatorNodeKind(const CXXOperatorCallExpr &E) {
+ switch (E.getOperator()) {
eduucaldas wrote:
> # Where to put this logic?
> The pro of having this
eduucaldas updated this revision to Diff 275930.
eduucaldas added a comment.
`->*` and `,` are binary operators.
Unit tests covering most of the operator kinds
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D82954/new/
https://reviews.llvm.org/D82954
eduucaldas updated this revision to Diff 275940.
eduucaldas marked 9 inline comments as done.
eduucaldas added a comment.
Answering comments
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D82954/new/
https://reviews.llvm.org/D82954
Files:
clang/li
eduucaldas added a comment.
Comment at: clang/lib/Tooling/Syntax/BuildTree.cpp:741
bool WalkUpFromIntegerLiteral(IntegerLiteral *S) {
+if (S->getLocation().isInvalid())
+ return true;
gribozavr2 wrote:
> WDYT about overriding `TraverseCXXOperatorCa
eduucaldas updated this revision to Diff 275942.
eduucaldas added a comment.
Unifying user defined binary operator tests
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D82954/new/
https://reviews.llvm.org/D82954
Files:
clang/lib/Tooling/Syntax/Bui
gribozavr2 accepted this revision.
gribozavr2 added inline comments.
This revision is now accepted and ready to land.
Comment at: clang/lib/Tooling/Syntax/BuildTree.cpp:149
+ case OO_PipePipe:
+ // Less common binary operators
+ case OO_ArrowStar:
Please drop
eduucaldas added inline comments.
Comment at: clang/unittests/Tooling/Syntax/TreeTest.cpp:2192
R"cpp(
+class osstream {};
struct X {
gribozavr2 wrote:
> I don't think we need a separate class to show the left shift operator. The
> declaration below can b
eduucaldas updated this revision to Diff 276344.
eduucaldas marked 4 inline comments as done.
eduucaldas added a comment.
answering minor comments
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D82954/new/
https://reviews.llvm.org/D82954
Files:
cl
gribozavr2 added inline comments.
Comment at: clang/unittests/Tooling/Syntax/TreeTest.cpp:2192
R"cpp(
+class osstream {};
struct X {
eduucaldas wrote:
> gribozavr2 wrote:
> > I don't think we need a separate class to show the left shift operator. The
> >
eduucaldas marked 2 inline comments as done.
eduucaldas added inline comments.
Comment at: clang/unittests/Tooling/Syntax/TreeTest.cpp:2192
R"cpp(
+class osstream {};
struct X {
gribozavr2 wrote:
> eduucaldas wrote:
> > gribozavr2 wrote:
> > > I don't thi
gribozavr2 added inline comments.
Comment at: clang/unittests/Tooling/Syntax/TreeTest.cpp:2192
R"cpp(
+class osstream {};
struct X {
eduucaldas wrote:
> gribozavr2 wrote:
> > eduucaldas wrote:
> > > gribozavr2 wrote:
> > > > I don't think we need a separa
eduucaldas updated this revision to Diff 276408.
eduucaldas marked an inline comment as done.
eduucaldas added a comment.
Switch to `TraverseCXXOperatorCallExpr`
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D82954/new/
https://reviews.llvm.org/D829
gribozavr2 accepted this revision.
gribozavr2 added inline comments.
Comment at: clang/lib/Tooling/Syntax/BuildTree.cpp:820
+ // A postfix unary operator is declared as taking two operands. The
+ // second operand is used to differ from its prefix counterpart. In the
+
eduucaldas updated this revision to Diff 276411.
eduucaldas marked 2 inline comments as done.
eduucaldas added a comment.
minor fix comments
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D82954/new/
https://reviews.llvm.org/D82954
Files:
clang/li
This revision was automatically updated to reflect the committed changes.
Closed by commit rGea8bba7e8d0d: Fix crash on overloaded postfix unary
operators due to invalid sloc (authored by eduucaldas).
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D829
This revision was not accepted when it landed; it landed in state "Needs
Review".
This revision was automatically updated to reflect the committed changes.
Closed by commit rGea8bba7e8d0d: Fix crash on overloaded postfix unary
operators due to invalid sloc (authored by eduucaldas).
Changed prior
17 matches
Mail list logo
