[PATCH] D83224: [clangd] Move clang-tidy check modifications into ClangdServer

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG0464acd0197c: [clangd] Move clang-tidy check modifications into ClangdServer (authored by kadircet). Changed prior to commit: https://reviews.llvm

[PATCH] D83224: [clangd] Move clang-tidy check modifications into ClangdServer

aaron.ballman added inline comments. Comment at: clang-tools-extra/clangd/ClangdServer.cpp:115 +// either due to crashes or false positives. +const char *getClangTidyBlacklist() { + static const std::string FalsePositives = kadircet wrote: > sammccall wrote: > >

[PATCH] D83224: [clangd] Move clang-tidy check modifications into ClangdServer

kadircet marked 19 inline comments as done. kadircet added inline comments. Comment at: clang-tools-extra/clangd/ClangdServer.cpp:115 +// either due to crashes or false positives. +const char *getClangTidyBlacklist() { + static const std::string FalsePositives =

[PATCH] D83224: [clangd] Move clang-tidy check modifications into ClangdServer

kadircet updated this revision to Diff 285389. kadircet marked an inline comment as done. kadircet added a comment. - Address comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D83224/new/ https://reviews.llvm.org/D83224 Files: clang-tools-ex

[PATCH] D83224: [clangd] Move clang-tidy check modifications into ClangdServer

aaron.ballman added inline comments. Comment at: clang-tools-extra/clangd/ClangdServer.cpp:120 + // clangd doesn't replay those when using a preamble. + "-llvm-header-guard"); + static const std::string CrashingChecks = ---

[PATCH] D83224: [clangd] Move clang-tidy check modifications into ClangdServer

sammccall added inline comments. Comment at: clang-tools-extra/clangd/ClangdServer.cpp:120 + // clangd doesn't replay those when using a preamble. + "-llvm-header-guard"); + static const std::string CrashingChecks = aa

[PATCH] D83224: [clangd] Move clang-tidy check modifications into ClangdServer

aaron.ballman added inline comments. Comment at: clang-tools-extra/clangd/ClangdServer.cpp:120 + // clangd doesn't replay those when using a preamble. + "-llvm-header-guard"); + static const std::string CrashingChecks = ---

[PATCH] D83224: [clangd] Move clang-tidy check modifications into ClangdServer

sammccall accepted this revision. sammccall added inline comments. This revision is now accepted and ready to land. Comment at: clang-tools-extra/clangd/ClangdServer.cpp:113 + +// Set of clang-tidy checks that are not suitable to be run through clangd, +// either due to crashes o

[PATCH] D83224: [clangd] Move clang-tidy check modifications into ClangdServer

aaron.ballman added inline comments. Comment at: clang-tools-extra/clangd/ClangdServer.cpp:120 + // clangd doesn't replay those when using a preamble. + "-llvm-header-guard"); + static const std::string CrashingChecks = ---

[PATCH] D83224: [clangd] Move clang-tidy check modifications into ClangdServer

njames93 added inline comments. Comment at: clang-tools-extra/clangd/ClangdServer.cpp:120 + // clangd doesn't replay those when using a preamble. + "-llvm-header-guard"); + static const std::string CrashingChecks = aar

[PATCH] D83224: [clangd] Move clang-tidy check modifications into ClangdServer

aaron.ballman added inline comments. Comment at: clang-tools-extra/clangd/ClangdServer.cpp:115 +// either due to crashes or false positives. +const char *getClangTidyBlacklist() { + static const std::string FalsePositives = kadircet wrote: > aaron.ballman wrote:

[PATCH] D83224: [clangd] Move clang-tidy check modifications into ClangdServer

kadircet added inline comments. Comment at: clang-tools-extra/clangd/ClangdServer.cpp:115 +// either due to crashes or false positives. +const char *getClangTidyBlacklist() { + static const std::string FalsePositives = aaron.ballman wrote: > njames93 wrote: > >

[PATCH] D83224: [clangd] Move clang-tidy check modifications into ClangdServer

aaron.ballman added inline comments. Comment at: clang-tools-extra/clangd/ClangdServer.cpp:115 +// either due to crashes or false positives. +const char *getClangTidyBlacklist() { + static const std::string FalsePositives = njames93 wrote: > Return by StringRef?

[PATCH] D83224: [clangd] Move clang-tidy check modifications into ClangdServer

kadircet added inline comments. Comment at: clang-tools-extra/clangd/ClangdServer.cpp:210 GetClangTidyOptions(*TFS.view(/*CWD=*/llvm::None), File); + if (!Opts.ClangTidyOpts.Checks) { +// If the user hasn't configured clang-tidy checks at all, including

[PATCH] D83224: [clangd] Move clang-tidy check modifications into ClangdServer

njames93 added inline comments. Comment at: clang-tools-extra/clangd/ClangdServer.cpp:210 GetClangTidyOptions(*TFS.view(/*CWD=*/llvm::None), File); + if (!Opts.ClangTidyOpts.Checks) { +// If the user hasn't configured clang-tidy checks at all, including

[PATCH] D83224: [clangd] Move clang-tidy check modifications into ClangdServer

kadircet added a comment. In D83224#2133457 , @njames93 wrote: > Do you think there should be a hidden command line option to disable > disabling blacklisted checks, purely to prevent hindering attempts to fix > these problematic checks. I would expect

[PATCH] D83224: [clangd] Move clang-tidy check modifications into ClangdServer

njames93 added a comment. Do you think there should be a hidden command line option to disable disabling blacklisted checks, purely to prevent hindering attempts to fix these problematic checks. Comment at: clang-tools-extra/clangd/ClangdServer.cpp:115 +// either due to crash

[PATCH] D83224: [clangd] Move clang-tidy check modifications into ClangdServer

kadircet updated this revision to Diff 275709. kadircet added a comment. - Add tests and also disable bugprone-use-after-move Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D83224/new/ https://reviews.llvm.org/D83224 Files: clang-tools-extra/clang

[PATCH] D83224: [clangd] Move clang-tidy check modifications into ClangdServer

kadircet created this revision. kadircet added a reviewer: sammccall. Herald added subscribers: cfe-commits, aaron.ballman, usaxena95, arphaman, jkorous, MaskRay, ilya-biryukov. Herald added a project: clang. This enables sharing the logic between standalone clangd and embedders of it. The new ap