This revision was landed with ongoing or failed builds.
This revision was automatically updated to reflect the committed changes.
Closed by commit rG8e41a688a5b1: [clang][cli] Port DependencyOutput option
flags to new option parsing system (authored by jansvoboda11).
Repository:
rG LLVM Github
jansvoboda11 updated this revision to Diff 308573.
jansvoboda11 added a comment.
Remove unnecessary std namespace
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D83694/new/
https://reviews.llvm.org/D83694
Files:
dexonsmith accepted this revision.
dexonsmith added a comment.
This revision is now accepted and ready to land.
This LGTM, with one more nit to consider.
Comment at: clang/lib/Frontend/CompilerInvocation.cpp:163
+static constexpr bool is_int_convertible() {
+ return sizeof(T)
jansvoboda11 updated this revision to Diff 307037.
jansvoboda11 added a comment.
Rebase
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D83694/new/
https://reviews.llvm.org/D83694
Files:
clang/include/clang/Driver/Options.td
jansvoboda11 added a comment.
Addressed review feedback.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D83694/new/
https://reviews.llvm.org/D83694
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
jansvoboda11 updated this revision to Diff 307034.
jansvoboda11 added a comment.
Herald added a project: LLVM.
Herald added a subscriber: llvm-commits.
Reduce template instantiations, remove names of unused parameters
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
dexonsmith added inline comments.
Comment at: clang/lib/Frontend/CompilerInvocation.cpp:156-159
+template
+FlagToValueNormalizer makeFlagToValueNormalizer(T Value) {
+ return FlagToValueNormalizer{std::move(Value)};
}
dexonsmith wrote:
> Please declare this
dexonsmith requested changes to this revision.
dexonsmith added inline comments.
This revision now requires changes to proceed.
Comment at: clang/include/clang/Driver/Options.td:473
+MarshallingInfoFlag<"DependencyOutputOpts.OutputFormat",
"DependencyOutputFormat::Make">,
+
jansvoboda11 added inline comments.
Comment at: clang/include/clang/Driver/Options.td:473
+MarshallingInfoFlag<"DependencyOutputOpts.OutputFormat",
"DependencyOutputFormat::Make">,
+Normalizer<"makeFlagToValueNormalizer(DependencyOutputFormat::NMake)">;
def Mach :
