[PATCH] D85735: [OpenMP] Context selector extensions for template functions

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. jdoerfert marked 2 inline comments as done. Closed by commit rG5c1084e8840b: [OpenMP] Context selector extensions for template functions (authored by jdoerfert). Repos

[PATCH] D85735: [OpenMP] Context selector extensions for template functions

jdoerfert marked 5 inline comments as done. jdoerfert added inline comments. Comment at: clang/include/clang/Sema/Sema.h:10042 void ActOnFinishedFunctionDefinitionInOpenMPDeclareVariantScope( - FunctionDecl *FD, FunctionDecl *BaseFD); + Decl *D, SmallVectorImpl &Base

[PATCH] D85735: [OpenMP] Context selector extensions for template functions

ABataev added inline comments. Comment at: clang/include/clang/Sema/Sema.h:10042 void ActOnFinishedFunctionDefinitionInOpenMPDeclareVariantScope( - FunctionDecl *FD, FunctionDecl *BaseFD); + Decl *D, SmallVectorImpl &Bases); JonChesterfield wrote:

[PATCH] D85735: [OpenMP] Context selector extensions for template functions

JonChesterfield accepted this revision. JonChesterfield added a comment. This revision is now accepted and ready to land. This looks good to me. I can't claim to have read the test case in detail. Some style suggestions inline around the vector, but they're not blocking. Comme

[PATCH] D85735: [OpenMP] Context selector extensions for template functions

jdoerfert updated this revision to Diff 285468. jdoerfert added a comment. Test formatting Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D85735/new/ https://reviews.llvm.org/D85735 Files: clang/include/clang/Basic/AttrDocs.td clang/include/clan

[PATCH] D85735: [OpenMP] Context selector extensions for template functions

jdoerfert updated this revision to Diff 285264. jdoerfert added a comment. Rebase on top of D85878 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D85735/new/ https://reviews.llvm.org/D85735 Files: clang/include/cl

[PATCH] D85735: [OpenMP] Context selector extensions for template functions

jdoerfert added a comment. In D85735#2210662 , @JonChesterfield wrote: > Nice. What makes it an extension? 5.0 / 2.3.5 claims "and where > variant-func-id is the name of a function variant that is either a base > language identifier or, for C++, a templ

[PATCH] D85735: [OpenMP] Context selector extensions for template functions

JonChesterfield added a comment. Nice. What makes it an extension? 5.0 / 2.3.5 claims "and where variant-func-id is the name of a function variant that is either a base language identifier or, for C++, a template-id." which suggests this could be always-on Comment at: clang/l

[PATCH] D85735: [OpenMP] Context selector extensions for template functions

jdoerfert created this revision. jdoerfert added reviewers: JonChesterfield, jhuber6, ABataev. Herald added subscribers: llvm-commits, guansong, bollu, yaxunl. Herald added a reviewer: aaron.ballman. Herald added projects: clang, LLVM. jdoerfert requested review of this revision. Herald added a sub