[PATCH] D85777: [OpenMP] Support std::complex math functions in target regions

2020-09-16 Thread Johannes Doerfert via Phabricator via cfe-commits
This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG56069b5c71ca: [OpenMP] Support `std::complex` math functions in target regions (authored by jdoerfert). Repository: rG LLVM Github Monorepo CHANG

[PATCH] D85777: [OpenMP] Support std::complex math functions in target regions

2020-08-25 Thread Johannes Doerfert via Phabricator via cfe-commits
jdoerfert added inline comments. Comment at: clang/lib/Headers/openmp_wrappers/complex_cmath.h:58 + +template __DEVICE__ _Tp norm(const std::complex<_Tp> &__c) { + if (std::isinf(__c.real())) JonChesterfield wrote: > Doesn't matter hugely given inlining, but I'

[PATCH] D85777: [OpenMP] Support std::complex math functions in target regions

2020-08-25 Thread Jon Chesterfield via Phabricator via cfe-commits
JonChesterfield accepted this revision. JonChesterfield added a comment. This revision is now accepted and ready to land. The duplication from libc++ doesn't feel good but I can see how it happened. Dependency breaking etc. Comment at: clang/lib/Headers/openmp_wrappers/complex

[PATCH] D85777: [OpenMP] Support std::complex math functions in target regions

2020-08-11 Thread Johannes Doerfert via Phabricator via cfe-commits
jdoerfert added a comment. I think the test fail because D85735 was not part of the build. Works locally just fine. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D85777/new/ https://reviews.llvm.org/D85777 ___

[PATCH] D85777: [OpenMP] Support std::complex math functions in target regions

2020-08-11 Thread Johannes Doerfert via Phabricator via cfe-commits
jdoerfert updated this revision to Diff 284954. jdoerfert added a comment. Reintroduce requires-target into tests Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D85777/new/ https://reviews.llvm.org/D85777 Files: clang/lib/Headers/CMakeLists.txt

[PATCH] D85777: [OpenMP] Support std::complex math functions in target regions

2020-08-11 Thread Johannes Doerfert via Phabricator via cfe-commits
jdoerfert updated this revision to Diff 284898. jdoerfert added a comment. Update test and include mock `type_traits` header Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D85777/new/ https://reviews.llvm.org/D85777 Files: clang/lib/Headers/CMakeL

[PATCH] D85777: [OpenMP] Support std::complex math functions in target regions

2020-08-11 Thread Johannes Doerfert via Phabricator via cfe-commits
jdoerfert created this revision. jdoerfert added reviewers: JonChesterfield, jhuber6, ABataev. Herald added subscribers: guansong, bollu, yaxunl, mgorny. Herald added a project: clang. jdoerfert requested review of this revision. Herald added a subscriber: sstefan1. The last (big) missing piece to