[PATCH] D88195: Remove stale assert.

This revision was automatically updated to reflect the committed changes. Closed by commit rG34ca5b3392ce: Remove stale assert. (authored by void). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D88195/new/ https://reviews.llvm.org/D88195 Files: cla

[PATCH] D88195: Remove stale assert.

nickdesaulniers accepted this revision. nickdesaulniers added a comment. In D88195#2293637 , @jyknight wrote: > In D88195#2293597 , @nickdesaulniers > wrote: > >> In D88195#2293589

[PATCH] D88195: Remove stale assert.

jyknight accepted this revision. jyknight added a comment. This revision is now accepted and ready to land. In D88195#2293597 , @nickdesaulniers wrote: > In D88195#2293589 , @void wrote: > >> Clarify commit message

[PATCH] D88195: Remove stale assert.

nickdesaulniers added a comment. In D88195#2293589 , @void wrote: > Clarify commit message. Phabricator unfortunately won't amend the review description when the commit message is updated; you'll need to manually edit the description via phab's UI for o

[PATCH] D88195: Remove stale assert.

void updated this revision to Diff 294150. void added a comment. Clarify commit message. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D88195/new/ https://reviews.llvm.org/D88195 Files: clang/lib/AST/Stmt.cpp clang/test/Modules/Inputs/asm-goto/

[PATCH] D88195: Remove stale assert.

nickdesaulniers added a comment. In D88195#2293559 , @nickdesaulniers wrote: > In D88195#2293533 , @void wrote: > >> In D88195#2293165 , >> @nickdesaulniers wrote: >> >>> I

[PATCH] D88195: Remove stale assert.

void added a comment. In D88195#2293559 , @nickdesaulniers wrote: > In D88195#2293533 , @void wrote: > >> In D88195#2293165 , >> @nickdesaulniers wrote: >> >>> I'm super co

[PATCH] D88195: Remove stale assert.

nickdesaulniers added a comment. In D88195#2293533 , @void wrote: > In D88195#2293165 , @nickdesaulniers > wrote: > >> I'm super confused between the commit message and initial hunk, that seem to >> make sense and

[PATCH] D88195: Remove stale assert.

void added a comment. In D88195#2293165 , @nickdesaulniers wrote: > I'm super confused between the commit message and initial hunk, that seem to > make sense and probably should go in clang-11 if it's not too late, and the > additional tests for modules

[PATCH] D88195: Remove stale assert.

void updated this revision to Diff 294141. void added a comment. Fix test. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D88195/new/ https://reviews.llvm.org/D88195 Files: clang/lib/AST/Stmt.cpp clang/test/Modules/Inputs/asm-goto/a.h clang/te

[PATCH] D88195: Remove stale assert.

nickdesaulniers added a comment. I'm super confused between the commit message and initial hunk, that seem to make sense and probably should go in clang-11 if it's not too late, and the additional tests for modules which the commit message does not address. Were these meant to be separate comm

[PATCH] D88195: Remove stale assert.

jyknight added inline comments. Comment at: clang/test/Modules/asm-goto.cpp:1 +// RUN: rm -rf %t +// RUN: %clang_cc1 -fmodules -fno-implicit-modules -x c++ -I%S/Inputs/asm-goto -emit-module %S/Inputs/asm-goto/module.modulemap -fmodule-name=a -o %t/a.pcm void wro

[PATCH] D88195: Remove stale assert.

void added inline comments. Comment at: clang/test/Modules/asm-goto.cpp:1 +// RUN: rm -rf %t +// RUN: %clang_cc1 -fmodules -fno-implicit-modules -x c++ -I%S/Inputs/asm-goto -emit-module %S/Inputs/asm-goto/module.modulemap -fmodule-name=a -o %t/a.pcm jyknight wro

[PATCH] D88195: Remove stale assert.

void updated this revision to Diff 293938. void added a comment. Fix test case. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D88195/new/ https://reviews.llvm.org/D88195 Files: clang/lib/AST/Stmt.cpp clang/test/Modules/Inputs/asm-goto/a.h cla

[PATCH] D88195: Remove stale assert.

jyknight added inline comments. Comment at: clang/test/Modules/Inputs/asm-goto/a.h:4-6 + asm goto("xor $0, $0\n\t" + "test $0, $0\n\t" + "jne $l1\n\t" An empty asm string will suffice for the test. Comment at: clang/test/Mo

[PATCH] D88195: Remove stale assert.

void created this revision. void added reviewers: nickdesaulniers, jyknight. Herald added a project: clang. Herald added a subscriber: cfe-commits. void requested review of this revision. Remove assert that "asm goto" cannot have outputs. Repository: rG LLVM Github Monorepo https://reviews.ll