This revision was landed with ongoing or failed builds.
This revision was automatically updated to reflect the committed changes.
Closed by commit rG5eb7a5814a5c: [cfe][M68k](7/8) Clang basic support (authored
by myhsu).
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
myhsu marked an inline comment as done.
myhsu added inline comments.
Comment at: clang/lib/Basic/Targets/M68k.cpp:142
+const char *, TargetInfo::ConstraintInfo ) const {
+ // FIXME: implement
+ switch (*Name) {
jrtc27 wrote:
> This is implemented?
only
myhsu updated this revision to Diff 326505.
myhsu marked 4 inline comments as done.
myhsu added a comment.
- [NFC] Addressed feedbacks
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D88393/new/
https://reviews.llvm.org/D88393
Files:
clang/include/clang/Basic/Attr.td
jrtc27 added a comment.
Issues from my previous review are still outstanding
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D88393/new/
https://reviews.llvm.org/D88393
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
jrtc27 added inline comments.
Comment at: clang/include/clang/Basic/Attr.td:1541
+ // NOTE: If you add any additional spellings, ARMInterrupt's, MipsInterrupt's
+ // and AnyX86Interrupt's spellings must match.
+ let Spellings = [GNU<"interrupt">];
Do you need
myhsu added inline comments.
Comment at: clang/lib/Basic/Targets/M68k.cpp:77-79
+ Builder.defineMacro("M68k");
+ Builder.defineMacro("__M68k__");
+ Builder.defineMacro("__M68K__");
jrtc27 wrote:
> myhsu wrote:
> > jrtc27 wrote:
> > > Where are these coming
myhsu updated this revision to Diff 320604.
myhsu added a comment.
- Addressed feedback
- Remove redundant target macro definitions
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D88393/new/
https://reviews.llvm.org/D88393
Files:
clang/include/clang/Basic/Attr.td
jrtc27 added inline comments.
Comment at: clang/lib/Basic/Targets/M68k.cpp:77-79
+ Builder.defineMacro("M68k");
+ Builder.defineMacro("__M68k__");
+ Builder.defineMacro("__M68K__");
myhsu wrote:
> jrtc27 wrote:
> > Where are these coming from? GCC only
myhsu added inline comments.
Comment at: clang/lib/Basic/Targets/M68k.cpp:63
+.Case("generic", CK_68000)
+.Case("M68000", CK_68000)
+.Case("M68010", CK_68010)
jrtc27 wrote:
> GCC's -mcpu excludes any M prefix and is just the
myhsu updated this revision to Diff 320585.
myhsu marked 4 inline comments as done.
myhsu added a comment.
- Addressed feedbacks
- Now M68k tries to use ABI that is compatible with GCC
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D88393/new/
https://reviews.llvm.org/D88393
Files:
jrtc27 added inline comments.
Comment at: clang/lib/Basic/Targets/M68k.cpp:38-50
+ // M68k pointers are always 32 bit wide even for 16 bit cpus
+ Layout += "-p:32:32";
+
+ // M68k integer data types
+ Layout += "-i8:8:8-i16:16:16-i32:32:32";
+
+ // FIXME no floats at the
RKSimon added inline comments.
Comment at: clang/lib/Basic/Targets/M68k.h:14
+#ifndef M680X0_H_LTNCIPAD
+#define M680X0_H_LTNCIPAD
+
@myhsu This should probably be LLVM_CLANG_LIB_BASIC_TARGETS_M68K_H
CHANGES SINCE LAST ACTION
bruno added a reviewer: bruno.
bruno accepted this revision.
bruno added a comment.
This revision is now accepted and ready to land.
LGTM
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D88393/new/
https://reviews.llvm.org/D88393
___
myhsu updated this revision to Diff 309461.
myhsu added a comment.
- Add support for M68060 sub-target
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D88393/new/
https://reviews.llvm.org/D88393
Files:
clang/include/clang/Basic/Attr.td
clang/lib/Basic/CMakeLists.txt
rengolin added a comment.
Thanks for the changes. This looks good to me but I'll let others check again
and approve.
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D88393/new/
https://reviews.llvm.org/D88393
___
cfe-commits mailing list
myhsu added inline comments.
Comment at: clang/lib/Basic/Targets.cpp:314
+default:
+ return new M68kTargetInfo(Triple, Opts);
+}
rengolin wrote:
> No support for bare-metal?
currently we don't have any plan for that
Comment at:
myhsu updated this revision to Diff 308866.
myhsu marked 3 inline comments as done.
myhsu added a comment.
- Addressed all the feedbacks
- Fixed minor issues that would retrieve the wrong TargetCodeGenInfo instance
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D88393/new/
myhsu updated this revision to Diff 308550.
myhsu marked 5 inline comments as done.
myhsu added a comment.
- Rebased to latest changes
- Addressed some of the feedbacks
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D88393/new/
https://reviews.llvm.org/D88393
Files:
bruno added a comment.
Looking forward to see m68k support (and hopefully sega genesis toolchain
support someday)!
Comment at: clang/lib/Basic/Targets/M68k.cpp:73
+void M68kTargetInfo::getTargetDefines(const LangOptions ,
+MacroBuilder
RKSimon added inline comments.
Comment at: clang/lib/Basic/CMakeLists.txt:78
Targets/Mips.cpp
+ Targets/M68k.cpp
Targets/NVPTX.cpp
(sorting) - move after Le64.cpp
Comment at: clang/lib/CodeGen/TargetInfo.cpp:8087
+ if (const
rengolin added inline comments.
Comment at: clang/lib/Basic/Targets.cpp:314
+default:
+ return new M68kTargetInfo(Triple, Opts);
+}
No support for bare-metal?
Comment at: clang/lib/Basic/Targets/M68k.cpp:123
+"d0", "d1", "d2",
myhsu updated this revision to Diff 302187.
myhsu retitled this revision from "[cfe][M68K] (Patch 7/8) Basic Clang support"
to "[cfe][M68k] (Patch 7/8) Basic Clang support".
myhsu edited the summary of this revision.
myhsu added a comment.
Herald added a subscriber: dexonsmith.
[NFC] Rename
myhsu updated this revision to Diff 296064.
myhsu added a comment.
Fix the CPU name passing to the Backend
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D88393/new/
https://reviews.llvm.org/D88393
Files:
clang/include/clang/Basic/Attr.td
clang/lib/Basic/CMakeLists.txt
myhsu updated this revision to Diff 295706.
myhsu added a comment.
Update licenses
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D88393/new/
https://reviews.llvm.org/D88393
Files:
clang/include/clang/Basic/Attr.td
clang/lib/Basic/CMakeLists.txt
clang/lib/Basic/Targets.cpp
myhsu updated this revision to Diff 295468.
myhsu added a comment.
Fix formatting issues
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D88393/new/
https://reviews.llvm.org/D88393
Files:
clang/include/clang/Basic/Attr.td
clang/lib/Basic/CMakeLists.txt
clang/lib/Basic/Targets.cpp
myhsu created this revision.
Herald added subscribers: cfe-commits, mgorny.
Herald added a reviewer: aaron.ballman.
Herald added a project: clang.
myhsu requested review of this revision.
1. Add M68K as new Clang target
2. Add new attribute to support M68K's ISR (Interrupt Service Routine)
26 matches
Mail list logo
