[PATCH] D89065: [clang] Tweaked fixit for static assert with no message

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG5616c5b8664b: [clang] Tweaked fixit for static assert with no message (authored by njames93). Changed prior to commit: https://reviews.llvm.org/D8

[PATCH] D89065: [clang] Tweaked fixit for static assert with no message

aaron.ballman added inline comments. Comment at: clang/test/FixIt/fixit-static-assert.cpp:2-3 +// RUN: %clang_cc1 -std=c++14 %s -fdiagnostics-parseable-fixits %s 2>&1 | FileCheck %s +// Ensure no warnings are emitted in c++17. +// RUN: %clang_cc1 -std=c++17 %s -Werror -fsyntax-o

[PATCH] D89065: [clang] Tweaked fixit for static assert with no message

njames93 updated this revision to Diff 325452. njames93 marked an inline comment as done. njames93 added a comment. Address comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D89065/new/ https://reviews.llvm.org/D89065 Files: clang/lib/Parse/

[PATCH] D89065: [clang] Tweaked fixit for static assert with no message

njames93 marked an inline comment as done. njames93 added inline comments. Comment at: clang/test/FixIt/fixit-static-assert.cpp:2-3 +// RUN: %clang_cc1 -std=c++14 %s -fdiagnostics-parseable-fixits %s 2>&1 | FileCheck %s +// Ensure no warnings are emitted in c++17. +// RUN: %clan

[PATCH] D89065: [clang] Tweaked fixit for static assert with no message

aaron.ballman accepted this revision. aaron.ballman added a comment. This revision is now accepted and ready to land. LGTM aside from some nits. Comment at: clang/lib/Parse/ParseDeclCXX.cpp:861 + SourceLocation EndExprLoc) { + if (

[PATCH] D89065: [clang] Tweaked fixit for static assert with no message

njames93 updated this revision to Diff 325287. njames93 added a comment. Add recompile test to ensure fix-its are correct Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D89065/new/ https://reviews.llvm.org/D89065 Files: clang/lib/Parse/ParseDeclCX

[PATCH] D89065: [clang] Tweaked fixit for static assert with no message

njames93 updated this revision to Diff 325284. njames93 added a comment. Add tests for fixits. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D89065/new/ https://reviews.llvm.org/D89065 Files: clang/lib/Parse/ParseDeclCXX.cpp clang/test/FixIt/fi

[PATCH] D89065: [clang] Tweaked fixit for static assert with no message

njames93 added inline comments. Comment at: clang/lib/Parse/ParseDeclCXX.cpp:874 /// [C++0x] static_assert-declaration: /// static_assert ( constant-expression , string-literal ) ; /// aaron.ballman wrote: > xbolva00 wrote: > > Do we warn for: > >

[PATCH] D89065: [clang] Tweaked fixit for static assert with no message

aaron.ballman added inline comments. Comment at: clang/lib/Parse/ParseDeclCXX.cpp:874 /// [C++0x] static_assert-declaration: /// static_assert ( constant-expression , string-literal ) ; /// xbolva00 wrote: > Do we warn for: > > static_assert(“my

[PATCH] D89065: [clang] Tweaked fixit for static assert with no message

xbolva00 added inline comments. Comment at: clang/lib/Parse/ParseDeclCXX.cpp:874 /// [C++0x] static_assert-declaration: /// static_assert ( constant-expression , string-literal ) ; /// Do we warn for: static_assert(“my msg”)? I remember some lo

[PATCH] D89065: [clang] Tweaked fixit for static assert with no message

aaron.ballman added a comment. In D89065#2320031 , @njames93 wrote: > I don't see any support for verifying fix-its in the test cases so unsure how > i could go about testing this change. We usually test fix-its with `-fdiagnostics-parseable-fixits` as i

[PATCH] D89065: [clang] Tweaked fixit for static assert with no message

njames93 added a comment. Ping? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D89065/new/ https://reviews.llvm.org/D89065 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi

[PATCH] D89065: [clang] Tweaked fixit for static assert with no message

njames93 added a comment. Ping Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D89065/new/ https://reviews.llvm.org/D89065 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-

[PATCH] D89065: [clang] Tweaked fixit for static assert with no message

njames93 added a comment. Ping Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D89065/new/ https://reviews.llvm.org/D89065 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-

[PATCH] D89065: [clang] Tweaked fixit for static assert with no message

njames93 updated this revision to Diff 297434. njames93 added a comment. FixIt now properly generated Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D89065/new/ https://reviews.llvm.org/D89065 Files: clang/lib/Parse/ParseDeclCXX.cpp Index: clang

[PATCH] D89065: [clang] Tweaked fixit for static assert with no message

njames93 planned changes to this revision. njames93 added a comment. Just noticed this doesn't quite work as expected, will update Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D89065/new/ https://reviews.llvm.org/D89065 ___

[PATCH] D89065: [clang] Tweaked fixit for static assert with no message

njames93 updated this revision to Diff 297072. njames93 added a comment. Remove unnecessary changes Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D89065/new/ https://reviews.llvm.org/D89065 Files: clang/lib/Parse/ParseDeclCXX.cpp Index: clang/l

[PATCH] D89065: [clang] Tweaked fixit for static assert with no message

njames93 added a comment. I don't see any support for verifying fix-its in the test cases so unsure how i could go about testing this change. Comment at: clang/lib/Parse/ParseDeclCXX.cpp:18 #include "clang/Basic/CharInfo.h" +#include "clang/Basic/DiagnosticParse.h" #include

[PATCH] D89065: [clang] Tweaked fixit for static assert with no message

njames93 created this revision. njames93 added a reviewer: rsmith. Herald added a project: clang. Herald added a subscriber: cfe-commits. njames93 requested review of this revision. If a static assert has a message as the right side of an and condition, suggest a fix it of replacing the '&&' to '