[PATCH] D90630: [CodeGen] Fix Bug 47499: __unaligned extension inconsistent behaviour with C and C++

2020-11-05 Thread Reid Kleckner via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rGd2e7dca5ca92: [CodeGen] Fix Bug 47499: __unaligned extension inconsistent behaviour with C… (authored by j0le, committed by rnk). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D90630: [CodeGen] Fix Bug 47499: __unaligned extension inconsistent behaviour with C and C++

2020-11-03 Thread Jan Ole Hüser via Phabricator via cfe-commits
j0le marked an inline comment as done. j0le added a comment. In D90630#2368984 , @rnk wrote: > Thanks, this basically looks correct to me, aside from some formatting > details. Do you want me to apply those fixes and land this for you? I see > that was

[PATCH] D90630: [CodeGen] Fix Bug 47499: __unaligned extension inconsistent behaviour with C and C++

2020-11-03 Thread Jan Ole Hüser via Phabricator via cfe-commits
j0le updated this revision to Diff 302496. j0le edited the summary of this revision. j0le added a comment. Moved comment into the else-if block. Changed Summary of the diff, so that it is better suited for a commit message. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D90630/new/

[PATCH] D90630: [CodeGen] Fix Bug 47499: __unaligned extension inconsistent behaviour with C and C++

2020-11-02 Thread Reid Kleckner via Phabricator via cfe-commits
rnk accepted this revision. rnk added a comment. This revision is now accepted and ready to land. Thanks, this basically looks correct to me, aside from some formatting details. Do you want me to apply those fixes and land this for you? I see that was done for your last patch, but it's best to

[PATCH] D90630: [CodeGen] Fix Bug 47499: __unaligned extension inconsistent behaviour with C and C++

2020-11-02 Thread Jan Ole Hüser via Phabricator via cfe-commits
j0le created this revision. j0le added reviewers: rogfer01, rnk. j0le added a project: clang. Herald added a subscriber: cfe-commits. j0le requested review of this revision. Hello everyone, I think, I have found the reason, why there is a difference between C and C++ for the keyword