nridge added a comment.
Herald added a project: clang-tools-extra.
I wonder, should these instructions be in an easier-to-find place, such as the
clangd repo's own README
(https://github.com/clangd/clangd/blob/master/README.md), or even a section of
the clangd website (clangd.llvm.org)?
I want
This revision was automatically updated to reflect the committed changes.
Closed by commit rG4cca7939: [clangd] Add documentation for building and
testing clangd (authored by kadircet).
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D91186/new/
ht
kadircet added inline comments.
Comment at: clang-tools-extra/clangd/README.md:26
+- Create a build directory, for example at `$LLVM_ROOT/build`.
+- Inside the build directory run: `cmake $LLVM_ROOT/llvm/
+ -DCMAKE_BUILD_TYPE=RELEASE -DLLVM_ENABLE_PROJECTS="clang;clang-tools-ext
kadircet updated this revision to Diff 306633.
kadircet marked 2 inline comments as done.
kadircet added a comment.
- Mention assertions and ninja
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D91186/new/
https://reviews.llvm.org/D91186
Files:
cl
sammccall accepted this revision.
sammccall added a comment.
This revision is now accepted and ready to land.
Thanks!
Comment at: clang-tools-extra/clangd/README.md:26
+- Create a build directory, for example at `$LLVM_ROOT/build`.
+- Inside the build directory run: `cmake $LLV
kadircet added inline comments.
Comment at: clang-tools-extra/clangd/README.md:30
+ We suggest building in RELEASE mode as building DEBUG binaries requires
+ considerably more resources. You can check [Building LLVM with CMake
+ documentation](https://llvm.org/docs/CMake.html)
nridge added inline comments.
Comment at: clang-tools-extra/clangd/README.md:30
+ We suggest building in RELEASE mode as building DEBUG binaries requires
+ considerably more resources. You can check [Building LLVM with CMake
+ documentation](https://llvm.org/docs/CMake.html) f
kadircet created this revision.
kadircet added a reviewer: sammccall.
Herald added subscribers: cfe-commits, usaxena95, arphaman.
Herald added a project: clang.
kadircet requested review of this revision.
Herald added subscribers: MaskRay, ilya-biryukov.
Adds minimal cmake configuration required t
