steveire updated this revision to Diff 313370.
steveire added a comment.
Update
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D91303/new/
https://reviews.llvm.org/D91303
Files:
clang-tools-extra/clang-tidy/readability/ContainerSizeEmptyCheck.cpp
steveire added inline comments.
Comment at:
clang-tools-extra/clang-tidy/readability/ContainerSizeEmptyCheck.cpp:56
- hasEitherOperand(ignoringImpCasts(
- anyOf(integerLiteral(equals(1)),
-
aaron.ballman added inline comments.
Comment at:
clang-tools-extra/clang-tidy/readability/ContainerSizeEmptyCheck.cpp:56
- hasEitherOperand(ignoringImpCasts(
- anyOf(integerLiteral(equals(1)),
-
alexfh requested changes to this revision.
alexfh added a comment.
This revision now requires changes to proceed.
Pre-merge builder can't apply this patch:
https://buildkite.com/llvm-project/diff-checks/builds/18651
Is it based on https://reviews.llvm.org/D91302 ? Do we need the intermediate
sta
steveire created this revision.
steveire added a reviewer: alexfh.
Herald added a project: clang.
Herald added a subscriber: cfe-commits.
steveire requested review of this revision.
Use IgnoreUnlessSpelledInSource to make the matcher code smaller and
more visibly-related to the code.
Repository:
