[PATCH] D91840: OpaquePtr: Require byval on x86_intrcc parameter 0

2020-12-14 Thread Matt Arsenault via Phabricator via cfe-commits
arsenm closed this revision. arsenm added a comment. ef4da3c2ba8a812a695361d786e3de8a8b2cd482 +2e0e03c6a089da39039ec3f464f7cee5df86646b CHANGES SINCE LAST

[PATCH] D91840: OpaquePtr: Require byval on x86_intrcc parameter 0

2020-11-30 Thread David Blaikie via Phabricator via cfe-commits
dblaikie added a comment. (generally I'd suggest splitting the clangc and llvm patches if at all possible - in this case I'm guessing the clang patch could go first (adding the attribute which would be redundant/unused initially), then the LLVM one?) CHANGES SINCE LAST ACTION https://reviews

[PATCH] D91840: OpaquePtr: Require byval on x86_intrcc parameter 0

2020-11-30 Thread Reid Kleckner via Phabricator via cfe-commits
rnk accepted this revision. rnk added a comment. This revision is now accepted and ready to land. lgtm Thanks for removing that special case. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D91840/new/ https://reviews.llvm.org/D91840 ___ cfe-co

[PATCH] D91840: OpaquePtr: Require byval on x86_intrcc parameter 0

2020-11-30 Thread Matt Arsenault via Phabricator via cfe-commits
arsenm updated this revision to Diff 308354. arsenm added a comment. Fix bitcode upgrade after rebase CHANGES SINCE LAST ACTION https://reviews.llvm.org/D91840/new/ https://reviews.llvm.org/D91840 Files: clang/lib/CodeGen/TargetInfo.cpp clang/test/CodeGen/attr-x86-interrupt.c clang/tes

[PATCH] D91840: OpaquePtr: Require byval on x86_intrcc parameter 0

2020-11-20 Thread Matt Arsenault via Phabricator via cfe-commits
arsenm added inline comments. Comment at: llvm/test/Bitcode/compatibility-6.0.ll:439 ; CHECK: declare hhvm_ccc void @f.hhvm_ccc() -declare cc83 void @f.cc83() +declare cc83 void @f.cc83(i8* byval(i8)) ; CHECK: declare x86_intrcc void @f.cc83() craig.topper wrot

[PATCH] D91840: OpaquePtr: Require byval on x86_intrcc parameter 0

2020-11-20 Thread Craig Topper via Phabricator via cfe-commits
craig.topper added inline comments. Comment at: llvm/test/Bitcode/compatibility-6.0.ll:439 ; CHECK: declare hhvm_ccc void @f.hhvm_ccc() -declare cc83 void @f.cc83() +declare cc83 void @f.cc83(i8* byval(i8)) ; CHECK: declare x86_intrcc void @f.cc83() Why do we n

[PATCH] D91840: OpaquePtr: Require byval on x86_intrcc parameter 0

2020-11-19 Thread Matt Arsenault via Phabricator via cfe-commits
arsenm created this revision. arsenm added reviewers: rnk, aaboud, craig.topper. Herald added subscribers: dexonsmith, pengfei, hiraditya. Herald added a project: LLVM. arsenm requested review of this revision. Herald added a subscriber: wdng. Currently the backend special cases x86_intrcc and tre