[PATCH] D91980: [OpenMP] Add initial support for `omp [begin/end] assumes`

jdoerfert updated this revision to Diff 312277. jdoerfert added a comment. Fixes CHANGES SINCE LAST ACTION https://reviews.llvm.org/D91980/new/ https://reviews.llvm.org/D91980 Files: clang/include/clang/Basic/DiagnosticParseKinds.td clang/include/clang/Parse/Parser.h clang/include/clan

[PATCH] D91980: [OpenMP] Add initial support for `omp [begin/end] assumes`

thakis added a comment. In D91980#2456637 , @jdoerfert wrote: > In D91980#2456600 , @thakis wrote: > >> In addition to the build error, it also broke check-clang everywhere as far >> as I can tell. >> mac: http://4

[PATCH] D91980: [OpenMP] Add initial support for `omp [begin/end] assumes`

jdoerfert added a comment. In D91980#2456600 , @thakis wrote: > In addition to the build error, it also broke check-clang everywhere as far > as I can tell. > mac: http://45.33.8.238/macm1/292/step_6.txt > linux: http://45.33.8.238/linux/35399/step_7.txt

[PATCH] D91980: [OpenMP] Add initial support for `omp [begin/end] assumes`

thakis added a comment. In addition to the build error, it also broke check-clang everywhere as far as I can tell. mac: http://45.33.8.238/macm1/292/step_6.txt linux: http://45.33.8.238/linux/35399/step_7.txt win: http://45.33.8.238/win/29934/step_7.txt Repository: rG LLVM Github Monorepo CH

[PATCH] D91980: [OpenMP] Add initial support for `omp [begin/end] assumes`

jdoerfert added a comment. I guess I revert it for now :( Comment at: llvm/include/llvm/Frontend/OpenMP/OMPConstants.h:101 +#include "llvm/Frontend/OpenMP/OMPKinds.def" +}; + mehdi_amini wrote: > This is broken on gcc-5: > ``` > llvm/include/llvm/Frontend/Open

[PATCH] D91980: [OpenMP] Add initial support for `omp [begin/end] assumes`

mehdi_amini added inline comments. Comment at: llvm/include/llvm/Frontend/OpenMP/OMPConstants.h:101 +#include "llvm/Frontend/OpenMP/OMPKinds.def" +}; + This is broken on gcc-5: ``` llvm/include/llvm/Frontend/OpenMP/OMPConstants.h:101:1: error: could not convert

[PATCH] D91980: [OpenMP] Add initial support for `omp [begin/end] assumes`

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGa5a14cbe7f87: [OpenMP] Add initial support for `omp [begin/end] assumes` (authored by jdoerfert). Repository: rG LLVM Github Monorepo CHANGES SIN

[PATCH] D91980: [OpenMP] Add initial support for `omp [begin/end] assumes`

ABataev accepted this revision. ABataev added a comment. This revision is now accepted and ready to land. LG Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D91980/new/ https://reviews.llvm.org/D91980 ___ c

[PATCH] D91980: [OpenMP] Add initial support for `omp [begin/end] assumes`

jdoerfert updated this revision to Diff 309584. jdoerfert marked 2 inline comments as done. jdoerfert added a comment. Addressed comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D91980/new/ https://reviews.llvm.org/D91980 Files: clang/inclu

[PATCH] D91980: [OpenMP] Add initial support for `omp [begin/end] assumes`

ABataev added inline comments. Comment at: clang/lib/Sema/SemaOpenMP.cpp:5940 +void Sema::ActOnFinishedFunctionDefinitionInOpenMPAssumeScope(Decl *D) { + FunctionDecl *FD = nullptr; + if (auto *UTemplDecl = dyn_cast(D)) You can also check if the decl is invalid

[PATCH] D91980: [OpenMP] Add initial support for `omp [begin/end] assumes`

jdoerfert updated this revision to Diff 309381. jdoerfert added a comment. Early exit Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D91980/new/ https://reviews.llvm.org/D91980 Files: clang/include/clang/Basic/DiagnosticParseKinds.td clang/inclu

[PATCH] D91980: [OpenMP] Add initial support for `omp [begin/end] assumes`

jdoerfert added inline comments. Comment at: clang/lib/Sema/SemaOpenMP.cpp:3203-3206 + if (!SkippedClauses && Assumptions.empty()) +Diag(Loc, diag::err_omp_no_clause_for_directive) +<< llvm::omp::getAllAssumeClauseOptions() +<< llvm::omp::getOpenMPDirectiveNa

[PATCH] D91980: [OpenMP] Add initial support for `omp [begin/end] assumes`

ABataev added inline comments. Comment at: clang/lib/Sema/SemaOpenMP.cpp:3203-3206 + if (!SkippedClauses && Assumptions.empty()) +Diag(Loc, diag::err_omp_no_clause_for_directive) +<< llvm::omp::getAllAssumeClauseOptions() +<< llvm::omp::getOpenMPDirectiveName

[PATCH] D91980: [OpenMP] Add initial support for `omp [begin/end] assumes`

jdoerfert added inline comments. Comment at: clang/lib/Sema/SemaLambda.cpp:999-1002 + // OpenMP lambdas might get assumumption attributes. + if (LangOpts.OpenMP) +ActOnFinishedFunctionDefinitionInOpenMPAssumeScope(Method); + ABataev wrote: > Are there any o

[PATCH] D91980: [OpenMP] Add initial support for `omp [begin/end] assumes`

jdoerfert updated this revision to Diff 309340. jdoerfert marked 4 inline comments as done. jdoerfert added a comment. Addressed comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D91980/new/ https://reviews.llvm.org/D91980 Files: clang/inclu

[PATCH] D91980: [OpenMP] Add initial support for `omp [begin/end] assumes`

ABataev added inline comments. Comment at: clang/include/clang/Basic/DiagnosticParseKinds.td:1296-1297 +: Error<"'#pragma omp end assumes' with no matching '#pragma omp begin assumes'">; +def err_expected_assumption_clause +: Error<"'%0' directive requires at least one c

[PATCH] D91980: [OpenMP] Add initial support for `omp [begin/end] assumes`

jdoerfert updated this revision to Diff 308817. jdoerfert marked an inline comment as done. jdoerfert added a comment. Addressed comments, lambda handling and more Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D91980/new/ https://reviews.llvm.org/D9

[PATCH] D91980: [OpenMP] Add initial support for `omp [begin/end] assumes`

jdoerfert marked 6 inline comments as done. jdoerfert added inline comments. Comment at: clang/lib/Sema/SemaOpenMP.cpp:3210 + +SmallVector DeclContexts; +DeclContexts.push_back(CurContext); ABataev wrote: > jdoerfert wrote: > > ABataev wrote: > > > jdoerf

[PATCH] D91980: [OpenMP] Add initial support for `omp [begin/end] assumes`

ABataev added inline comments. Comment at: clang/lib/Parse/ParseOpenMP.cpp:1569-1593 +int idx = -1; +if (Tok.isAnyIdentifier()) { + II = Tok.getIdentifierInfo(); + llvm::StringSwitch SS(II->getName()); + for (const AssumptionClauseMappingInfo &ACMI : Assump

[PATCH] D91980: [OpenMP] Add initial support for `omp [begin/end] assumes`

jdoerfert added a comment. In D91980#2417129 , @ABataev wrote: > In D91980#2417049 , @jdoerfert wrote: > >> In D91980#2416950 , @ABataev wrote: >> >>> Why don't yo want to tr

[PATCH] D91980: [OpenMP] Add initial support for `omp [begin/end] assumes`

ABataev added a comment. In D91980#2417049 , @jdoerfert wrote: > In D91980#2416950 , @ABataev wrote: > >> Why don't yo want to try to implement the scheme similar to the declare >> target? > > Because it is not cle

[PATCH] D91980: [OpenMP] Add initial support for `omp [begin/end] assumes`

jdoerfert added a comment. In D91980#2416950 , @ABataev wrote: > Why don't yo want to try to implement the scheme similar to the declare > target? Because it is not clear that the standard even says that right now. Even if, as you noted, what is the use

[PATCH] D91980: [OpenMP] Add initial support for `omp [begin/end] assumes`

jdoerfert updated this revision to Diff 307697. jdoerfert marked 8 inline comments as done. jdoerfert added a comment. Addressed comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D91980/new/ https://reviews.llvm.org/D91980 Files: clang/inclu

[PATCH] D91980: [OpenMP] Add initial support for `omp [begin/end] assumes`

ABataev added a comment. Why don't yo want to try to implement the scheme similar to the declare target? Comment at: clang/include/clang/Sema/Sema.h:10333 + /// Check if there is an active global `omp begin assumes` directive. + bool isInOpenMPAssumeScope() { return !OMPAssum

[PATCH] D91980: [OpenMP] Add initial support for `omp [begin/end] assumes`

jdoerfert added inline comments. Comment at: clang/include/clang/Sema/Sema.h:10333 + /// Check if there is an active global `omp begin assumes` directive. + bool isInOpenMPAssumeScope() { return !OMPAssumeScoped.empty(); } + ABataev wrote: > jdoerfert wrote: >

[PATCH] D91980: [OpenMP] Add initial support for `omp [begin/end] assumes`

jdoerfert updated this revision to Diff 307479. jdoerfert added a comment. Improve template handling. Do not annotate template instantiations with scoped assumptions for now. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D91980/new/ https://reviews

[PATCH] D91980: [OpenMP] Add initial support for `omp [begin/end] assumes`

ABataev added inline comments. Comment at: clang/include/clang/Sema/Sema.h:10333 + /// Check if there is an active global `omp begin assumes` directive. + bool isInOpenMPAssumeScope() { return !OMPAssumeScoped.empty(); } + jdoerfert wrote: > ABataev wrote: > >

[PATCH] D91980: [OpenMP] Add initial support for `omp [begin/end] assumes`

jdoerfert added inline comments. Comment at: clang/include/clang/Sema/Sema.h:10333 + /// Check if there is an active global `omp begin assumes` directive. + bool isInOpenMPAssumeScope() { return !OMPAssumeScoped.empty(); } + ABataev wrote: > jdoerfert wrote: >

[PATCH] D91980: [OpenMP] Add initial support for `omp [begin/end] assumes`

ABataev added inline comments. Comment at: clang/include/clang/Sema/Sema.h:10333 + /// Check if there is an active global `omp begin assumes` directive. + bool isInOpenMPAssumeScope() { return !OMPAssumeScoped.empty(); } + jdoerfert wrote: > ABataev wrote: > >

[PATCH] D91980: [OpenMP] Add initial support for `omp [begin/end] assumes`

jdoerfert added inline comments. Comment at: clang/include/clang/Sema/Sema.h:10333 + /// Check if there is an active global `omp begin assumes` directive. + bool isInOpenMPAssumeScope() { return !OMPAssumeScoped.empty(); } + ABataev wrote: > jdoerfert wrote: >

[PATCH] D91980: [OpenMP] Add initial support for `omp [begin/end] assumes`

ABataev added inline comments. Comment at: clang/include/clang/Sema/Sema.h:10333 + /// Check if there is an active global `omp begin assumes` directive. + bool isInOpenMPAssumeScope() { return !OMPAssumeScoped.empty(); } + jdoerfert wrote: > ABataev wrote: > >

[PATCH] D91980: [OpenMP] Add initial support for `omp [begin/end] assumes`

jdoerfert added inline comments. Comment at: clang/include/clang/Sema/Sema.h:10333 + /// Check if there is an active global `omp begin assumes` directive. + bool isInOpenMPAssumeScope() { return !OMPAssumeScoped.empty(); } + ABataev wrote: > ABataev wrote: > >

[PATCH] D91980: [OpenMP] Add initial support for `omp [begin/end] assumes`

ABataev added inline comments. Comment at: clang/include/clang/Sema/Sema.h:10333 + /// Check if there is an active global `omp begin assumes` directive. + bool isInOpenMPAssumeScope() { return !OMPAssumeScoped.empty(); } + ABataev wrote: > `const` member functi

[PATCH] D91980: [OpenMP] Add initial support for `omp [begin/end] assumes`

jdoerfert created this revision. jdoerfert added reviewers: JonChesterfield, aaron.ballman, jhuber6, grokos, ggeorgakoudis, ABataev. Herald added subscribers: llvm-commits, guansong, bollu, yaxunl. Herald added projects: clang, LLVM. jdoerfert requested review of this revision. Herald added a subs