[PATCH] D92133: [clangd] Cache .clang-tidy files again.

njames93 added a comment. Unfortunately this broke the search order for clang-tidy files in root directories in favour or subdirectories. This wasn't caught as we didn't have tests for this. I've put a fix for this in D96204 with appropriate tests. Repository

[PATCH] D92133: [clangd] Cache .clang-tidy files again.

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. sammccall marked an inline comment as done. Closed by commit rG67d16b6da4be: [clangd] Cache .clang-tidy files again. (authored by sammccall). Changed prior to commit:

[PATCH] D92133: [clangd] Cache .clang-tidy files again.

njames93 accepted this revision. njames93 added a comment. This revision is now accepted and ready to land. LGTM, with a couple of nits that could easily be disregarded. Comment at: clang-tools-extra/clangd/TidyProvider.cpp:84-105 +for (auto I = path::begin(Parent, path::St

[PATCH] D92133: [clangd] Cache .clang-tidy files again.

sammccall updated this revision to Diff 308004. sammccall marked 3 inline comments as done. sammccall added a comment. Replace dynamic check with assert. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D92133/new/ https://reviews.llvm.org/D92133 File

[PATCH] D92133: [clangd] Cache .clang-tidy files again.

njames93 added inline comments. Comment at: clang-tools-extra/clangd/TidyProvider.cpp:113 +OptionStack.push_back(std::move(*Config)); +if (!OptionStack.back().InheritParentConfig) + break; njames93 wrote: > sammccall wrote: > > njames93 w

[PATCH] D92133: [clangd] Cache .clang-tidy files again.

njames93 added inline comments. Comment at: clang-tools-extra/clangd/TidyProvider.cpp:34 + llvm::Optional + get(const ThreadsafeFS &TFS, + std::chrono::steady_clock::time_point FreshTime) const { sammccall wrote: > njames93 wrote: > > To save a copy, could

[PATCH] D92133: [clangd] Cache .clang-tidy files again.

sammccall added inline comments. Comment at: clang-tools-extra/clangd/TidyProvider.cpp:34 + llvm::Optional + get(const ThreadsafeFS &TFS, + std::chrono::steady_clock::time_point FreshTime) const { njames93 wrote: > To save a copy, could this not return a c

[PATCH] D92133: [clangd] Cache .clang-tidy files again.

sammccall updated this revision to Diff 307924. sammccall marked 3 inline comments as done. sammccall added a comment. Return shared_ptr instead of value from cache, to avoid copies. Remove unneeded qualifiers. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.l

[PATCH] D92133: [clangd] Cache .clang-tidy files again.

njames93 added inline comments. Comment at: clang-tools-extra/clangd/TidyProvider.cpp:34 + llvm::Optional + get(const ThreadsafeFS &TFS, + std::chrono::steady_clock::time_point FreshTime) const { To save a copy, could this not return a const pointer to wha

[PATCH] D92133: [clangd] Cache .clang-tidy files again.

sammccall created this revision. sammccall added reviewers: njames93, kbobyrev. Herald added subscribers: cfe-commits, usaxena95, kadircet, arphaman. Herald added a project: clang. sammccall requested review of this revision. Herald added subscribers: MaskRay, ilya-biryukov. This cache went away i