[PATCH] D93301: [flang][driver] Add support for `-c` and `-emit-obj`

2021-01-07 Thread Andrzej Warzynski via Phabricator via cfe-commits
This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGe5cdb6c56edf: [flang][driver] Add support for `-c` and `-emit-obj` (authored by awarzynski). Changed prior to commit:

[PATCH] D93301: [flang][driver] Add support for `-c` and `-emit-obj`

2021-01-05 Thread Sourabh Singh Tomar via Phabricator via cfe-commits
SouraVX accepted this revision. SouraVX added a comment. LGTM! - Thanks! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D93301/new/ https://reviews.llvm.org/D93301 ___ cfe-commits mailing list

[PATCH] D93301: [flang][driver] Add support for `-c` and `-emit-obj`

2021-01-05 Thread Valentin Clement via Phabricator via cfe-commits
clementval accepted this revision. clementval added a comment. This revision is now accepted and ready to land. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D93301/new/ https://reviews.llvm.org/D93301

[PATCH] D93301: [flang][driver] Add support for `-c` and `-emit-obj`

2021-01-04 Thread Andrzej Warzynski via Phabricator via cfe-commits
awarzynski added a comment. Ping Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D93301/new/ https://reviews.llvm.org/D93301 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D93301: [flang][driver] Add support for `-c` and `-emit-obj`

2020-12-17 Thread Andrzej Warzynski via Phabricator via cfe-commits
awarzynski updated this revision to Diff 312457. awarzynski added a comment. Address PR comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D93301/new/ https://reviews.llvm.org/D93301 Files: clang/include/clang/Driver/Options.td

[PATCH] D93301: [flang][driver] Add support for `-c` and `-emit-obj`

2020-12-17 Thread Andrzej Warzynski via Phabricator via cfe-commits
awarzynski marked an inline comment as done. awarzynski added a comment. @clementval & @SouraVX - thank you for your comments! I will upload an updated version shortly. Comment at: clang/include/clang/Driver/Options.td:4329 HelpText<"Generate machine code, but discard

[PATCH] D93301: [flang][driver] Add support for `-c` and `-emit-obj`

2020-12-15 Thread Sourabh Singh Tomar via Phabricator via cfe-commits
SouraVX added a comment. Thanks! for the patch, some minor comments inlined. Rest LGTM. Let others also have a look. Comment at: clang/include/clang/Driver/Options.td:4329 HelpText<"Generate machine code, but discard output">; -def emit_obj : Flag<["-"], "emit-obj">, -

[PATCH] D93301: [flang][driver] Add support for `-c` and `-emit-obj`

2020-12-15 Thread Valentin Clement via Phabricator via cfe-commits
clementval added inline comments. Comment at: clang/include/clang/Driver/Options.td:4629 -} // let Flags = [CC1Option] +} // let Flags = [CC1Option, NoDriverOption] + Is it intended to modify the SYCL options? Comment at:

[PATCH] D93301: [flang][driver] Add support for `-c` and `-emit-obj`

2020-12-15 Thread Andrzej Warzynski via Phabricator via cfe-commits
awarzynski added a comment. @dang , I would appreciate if you could take a look at the diff in Options.td - you introduced the most recent changes there: https://reviews.llvm.org/D82574. I got a bit confused with the nested `let` statements there. I couldn't find a better way of marking

[PATCH] D93301: [flang][driver] Add support for `-c` and `-emit-obj`

2020-12-15 Thread Andrzej Warzynski via Phabricator via cfe-commits
awarzynski created this revision. Herald added a reviewer: sscalpone. Herald added a subscriber: dang. awarzynski requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. This patch adds a frontend action for emitting object files. While Flang does