[PATCH] D94941: Add minor version to libclang.so and libclang-cpp.so SONAME

tstellar updated this revision to Diff 318003. tstellar added a comment. Fix shared object symlinks. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D94941/new/ https://reviews.llvm.org/D94941 Files: clang/CMakeLists.txt

[PATCH] D94941: Add minor version to libclang.so and libclang-cpp.so SONAME

tstellar added inline comments. Comment at: clang/tools/clang-shlib/CMakeLists.txt:54 + PROPERTIES + SOVERSION ${LIBCLANG_LIBRARY_VERSION}) cuviper wrote: > tstellar wrote: > > cuviper wrote: > > > I think you also need `VERSION` here, or else it

[PATCH] D94941: Add minor version to libclang.so and libclang-cpp.so SONAME

cuviper added inline comments. Comment at: clang/tools/clang-shlib/CMakeLists.txt:54 + PROPERTIES + SOVERSION ${LIBCLANG_LIBRARY_VERSION}) tstellar wrote: > cuviper wrote: > > I think you also need `VERSION` here, or else it symlinks back to `.so.11`.

[PATCH] D94941: Add minor version to libclang.so and libclang-cpp.so SONAME

tstellar added inline comments. Comment at: clang/tools/clang-shlib/CMakeLists.txt:54 + PROPERTIES + SOVERSION ${LIBCLANG_LIBRARY_VERSION}) cuviper wrote: > I think you also need `VERSION` here, or else it symlinks back to `.so.11`. I think

[PATCH] D94941: Add minor version to libclang.so and libclang-cpp.so SONAME

cuviper added inline comments. Comment at: clang/tools/clang-shlib/CMakeLists.txt:54 + PROPERTIES + SOVERSION ${LIBCLANG_LIBRARY_VERSION}) I think you also need `VERSION` here, or else it symlinks back to `.so.11`. Repository: rG LLVM Github

[PATCH] D94941: Add minor version to libclang.so and libclang-cpp.so SONAME

sylvestre.ledru added a comment. I guess this will be clearly mentioned in the release notes :) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D94941/new/ https://reviews.llvm.org/D94941 ___ cfe-commits

[PATCH] D94941: Add minor version to libclang.so and libclang-cpp.so SONAME

sylvestre.ledru accepted this revision. sylvestre.ledru added a comment. This revision is now accepted and ready to land. Let's do it then :) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D94941/new/ https://reviews.llvm.org/D94941

[PATCH] D94941: Add minor version to libclang.so and libclang-cpp.so SONAME

cuviper added a comment. If the SONAME is different in any way, it is totally distinct to the dynamic linker. There's no semver parsing or anything like that. That's all we can do from a technical perspective, and the rest is just communication in the release. Repository: rG LLVM Github

[PATCH] D94941: Add minor version to libclang.so and libclang-cpp.so SONAME

sylvestre.ledru added a comment. Yeah, my question is more "is that enough for distro?" https://www.debian.org/doc/manuals/maint-guide/advanced.en.html https://www.gnu.org/software/libtool/manual/html_node/Updating-version-info.html I might be wrong but if 11.1 and 11.0 aren't compatible (not

[PATCH] D94941: Add minor version to libclang.so and libclang-cpp.so SONAME

tstellar added a comment. In D94941#2509829 , @sylvestre.ledru wrote: > I might be wrong but if the ABI is incompatible, are we not supposed to > update the SONAME itself? That's what this patch does, it updates the SONAME from *-11 to *-11.1.

[PATCH] D94941: Add minor version to libclang.so and libclang-cpp.so SONAME

sylvestre.ledru added a comment. I might be wrong but if the ABI is incompatible, are we not supposed to update the SONAME itself? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D94941/new/ https://reviews.llvm.org/D94941

[PATCH] D94941: Add minor version to libclang.so and libclang-cpp.so SONAME

dim added a comment. @sylvestre.ledru removed the minor version from the binary (on purpose, I think?) in rGa8b717fda42294d1c8e1f05d71280503e5839f14 : commit a8b717fda42294d1c8e1f05d71280503e5839f14 Author: Sylvestre

[PATCH] D94941: Add minor version to libclang.so and libclang-cpp.so SONAME

tstellar created this revision. tstellar added a reviewer: sylvestre.ledru. Herald added a subscriber: mgorny. tstellar requested review of this revision. Herald added a project: clang. This patch is for the release/11.x branch. We need to bump the SONAME, because the ABI of the shared library