rjmccall added a comment.
I agree, that seems like the right decision.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D95487/new/
https://reviews.llvm.org/D95487
___
cfe-commits mailing list
This revision was landed with ongoing or failed builds.
This revision was automatically updated to reflect the committed changes.
Closed by commit rG8ca33605ff0c: Itanium Mangling: Fix handling of
expr-primary in template-arg. (authored by jyknight).
Changed prior to commit:
jyknight added inline comments.
Comment at: clang/lib/AST/ItaniumMangle.cpp:5145
+ ASTContext = Context.getASTContext();
+ if (Ctx.getLangOpts().getClangABICompat() > LangOptions::ClangABI::Ver11) {
+mangleExpression(E, UnknownArity, /*AsTemplateArg=*/true);
rsmith accepted this revision.
rsmith added inline comments.
Comment at: clang/lib/AST/ItaniumMangle.cpp:549
void mangleInitListElements(const InitListExpr *InitList);
- void mangleDeclRefExpr(const NamedDecl *D);
- void mangleExpression(const Expr *E, unsigned Arity =
rjmccall accepted this revision.
rjmccall added a comment.
This revision is now accepted and ready to land.
Okay. I can accept this, then.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D95487/new/
https://reviews.llvm.org/D95487
jyknight added inline comments.
Comment at: clang/lib/AST/ItaniumMangle.cpp:3912
+IsPrimaryExpr = false;
+ };
+
jyknight wrote:
> rjmccall wrote:
> > I think it might be more reasonable to just check for the relatively small
> > number of
jyknight added inline comments.
Comment at: clang/lib/AST/ItaniumMangle.cpp:3912
+IsPrimaryExpr = false;
+ };
+
rjmccall wrote:
> I think it might be more reasonable to just check for the relatively small
> number of primary-expression cases in
rjmccall added inline comments.
Comment at: clang/lib/AST/ItaniumMangle.cpp:3912
+IsPrimaryExpr = false;
+ };
+
I think it might be more reasonable to just check for the relatively small
number of primary-expression cases in `mangleTemplateArgExpr` and
jyknight created this revision.
Herald added a subscriber: kristof.beyls.
jyknight requested review of this revision.
Herald added a project: clang.
Herald added a subscriber: cfe-commits.
Previously, we were emitting an extraneous X .. E in
around an if the template argument was constructed
