This revision was automatically updated to reflect the committed changes.
Closed by commit rG0b70c86e2007: clang-extra: fix incorrect use of
std::lock_guard by adding variable name… (authored by poelmanc, committed by
kadircet).
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
poelmanc marked an inline comment as done.
poelmanc added a comment.
s/Guard/Lock/! I don't have commit access so appreciate a push.
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D95725/new/
https://reviews.llvm.org/D95725
___
cfe-commits mail
poelmanc updated this revision to Diff 320594.
poelmanc added a comment.
Change Guard to Lock.
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D95725/new/
https://reviews.llvm.org/D95725
Files:
clang-tools-extra/clangd/support/Function.h
Index: clang-tools-extra/clangd/support/Functio
kadircet accepted this revision.
kadircet added a comment.
This revision is now accepted and ready to land.
thanks, lgtm!
Comment at: clang-tools-extra/clangd/support/Function.h:54
if (Parent) {
-std::lock_guard(Parent->ListenersMu);
+std::lock_guard Guar
poelmanc created this revision.
poelmanc added reviewers: sammccall, ilya-biryukov.
poelmanc added a project: clang-tools-extra.
Herald added subscribers: usaxena95, kadircet, arphaman.
poelmanc requested review of this revision.
Herald added a project: clang.
Herald added a subscriber: cfe-commits
