[PATCH] D95976: [OpenMP] Simplify offloading parallel call codegen

jdoerfert added inline comments. Comment at: openmp/libomptarget/deviceRTLs/common/generated_microtask_cases.gen:1 +case 0: +((void (*)(kmp_int32 *, kmp_int32 * JonChesterfield wrote: > This is not very pretty. Why do we need runtime dispatch to a function > po

[PATCH] D95976: [OpenMP] Simplify offloading parallel call codegen

JonChesterfield added inline comments. Comment at: openmp/libomptarget/deviceRTLs/common/generated_microtask_cases.gen:1 +case 0: +((void (*)(kmp_int32 *, kmp_int32 * This is not very pretty. Why do we need runtime dispatch to a function pointer? Repository:

[PATCH] D95976: [OpenMP] Simplify offloading parallel call codegen

ggeorgakoudis added a comment. In D95976#2725027 , @protze.joachim wrote: > Please update the test with a NFC commit. Thanks, @protze.joachim. The changes look good. I'll get that NFC commit in soon-ish, unless you would like to take over. Repository:

[PATCH] D95976: [OpenMP] Simplify offloading parallel call codegen

protze.joachim added a comment. Please update the test with a NFC commit. Comment at: openmp/libomptarget/test/offloading/bug49779.cpp:1-5 +// RUN: %libomptarget-compilexx-run-and-check-aarch64-unknown-linux-gnu +// RUN: %libomptarget-compilexx-run-and-check-powerpc64-ibm-linux

[PATCH] D95976: [OpenMP] Simplify offloading parallel call codegen

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGa2dbfb6b72db: [OpenMP] Simplify offloading parallel call codegen (authored by ggeorgakoudis). Changed prior to commit: https://reviews.llvm.org/D9

[PATCH] D95976: [OpenMP] Simplify offloading parallel call codegen

ggeorgakoudis updated this revision to Diff 339334. ggeorgakoudis added a comment. Fix clang-format Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D95976/new/ https://reviews.llvm.org/D95976 Files: clang/lib/CodeGen/CGOpenMPRuntimeGPU.cpp clang/

[PATCH] D95976: [OpenMP] Simplify offloading parallel call codegen

Meinersbur accepted this revision. Meinersbur added a comment. This revision is now accepted and ready to land. This test seem to pass on Windows now. Please still fix the clang-format remarks, such as going over 80 characters on a line. Comment at: clang/lib/CodeGen/CGOpenMPR

[PATCH] D95976: [OpenMP] Simplify offloading parallel call codegen

ggeorgakoudis updated this revision to Diff 339265. ggeorgakoudis added a comment. Add tests, reduce microtask cases to avoid stack problems Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D95976/new/ https://reviews.llvm.org/D95976 Files: clang/li

[PATCH] D95976: [OpenMP] Simplify offloading parallel call codegen

ggeorgakoudis updated this revision to Diff 338554. ggeorgakoudis marked 2 inline comments as done. ggeorgakoudis added a comment. Fix Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D95976/new/ https://reviews.llvm.org/D95976 Files: clang/lib/Code

[PATCH] D95976: [OpenMP] Simplify offloading parallel call codegen

Meinersbur added inline comments. Comment at: clang/lib/CodeGen/CGOpenMPRuntimeGPU.cpp:591-592 return Bld.CreateAnd(Bld.CreateNUWSub(NumThreads, Bld.getInt32(1)), Bld.CreateNot(Mask), "master_tid"); } This is another undefined codege

[PATCH] D95976: [OpenMP] Simplify offloading parallel call codegen

ggeorgakoudis marked 4 inline comments as done. ggeorgakoudis added inline comments. Comment at: clang/lib/CodeGen/CGOpenMPRuntimeGPU.cpp:1150 llvm::Value *IsMaster = Bld.CreateICmpEQ(RT.getGPUThreadID(CGF), getMasterThreadID(CGF)); Bld.CreateCondBr(IsMaster, MasterB

[PATCH] D95976: [OpenMP] Simplify offloading parallel call codegen

ggeorgakoudis updated this revision to Diff 338441. ggeorgakoudis marked 2 inline comments as done. ggeorgakoudis added a comment. Update for comments, fixes Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D95976/new/ https://reviews.llvm.org/D95976

[PATCH] D95976: [OpenMP] Simplify offloading parallel call codegen

Meinersbur added inline comments. Comment at: clang/lib/CodeGen/CGOpenMPRuntimeGPU.cpp:1141 llvm::Value *IsWorker = Bld.CreateICmpULT(RT.getGPUThreadID(CGF), getThreadLimit(CGF)); Bld.CreateCondBr(IsWorker, WorkerBB, MasterCheckBB); There seem to be

[PATCH] D95976: [OpenMP] Simplify offloading parallel call codegen

Meinersbur added a comment. I have not looked at the other mentioned problem yet: > another that attribute regexes are not recognized > (https://reviews.llvm.org/harbormaster/unit/view/552593/ at > nvptx_target_codegen.cpp:723:17) Which might still be there. I would want for Harbormaster to c

[PATCH] D95976: [OpenMP] Simplify offloading parallel call codegen

jdoerfert accepted this revision. jdoerfert added a comment. With the nit to add the two reproducers, LGTM. (please make sure to run FAROS or some benchmarks we have before commiting). Comment at: openmp/libomptarget/deviceRTLs/common/src/parallel.cu:294 + // TODO: Add UNLIKE

[PATCH] D95976: [OpenMP] Simplify offloading parallel call codegen

ggeorgakoudis marked 4 inline comments as done. ggeorgakoudis added inline comments. Comment at: clang/lib/CodeGen/CGOpenMPRuntimeGPU.cpp:2192 RCG(CGF); } } jdoerfert wrote: > Can we remove SeqGen while we are here please. We need to check in the > runt

[PATCH] D95976: [OpenMP] Simplify offloading parallel call codegen

ggeorgakoudis updated this revision to Diff 338246. ggeorgakoudis added a comment. Update for comments, fix for windows fix Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D95976/new/ https://reviews.llvm.org/D95976 Files: clang/lib/CodeGen/CGOpenM

[PATCH] D95976: [OpenMP] Simplify offloading parallel call codegen

Meinersbur requested changes to this revision. Meinersbur added inline comments. This revision now requires changes to proceed. Comment at: clang/lib/CodeGen/CGOpenMPRuntimeGPU.cpp:569-570 + else +ThreadLimit = Bld.CreateNUWSub(RT.getGPUNumThreads(CGF), +

[PATCH] D95976: [OpenMP] Simplify offloading parallel call codegen

ggeorgakoudis updated this revision to Diff 338102. ggeorgakoudis added a comment. Fix for getThreadsLimit Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D95976/new/ https://reviews.llvm.org/D95976 Files: clang/lib/CodeGen/CGOpenMPRuntimeGPU.cpp

[PATCH] D95976: [OpenMP] Simplify offloading parallel call codegen

Meinersbur added a comment. The transposition problem arises from: Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D95976/new/ https://reviews.llvm.org/D95976 ___ cfe-commits mailing list cfe-commits@li

[PATCH] D95976: [OpenMP] Simplify offloading parallel call codegen

jdoerfert added a comment. I have only minor remarks but I'd like you to check if my hunch is correct and the proposed modifications will fix fix PR49777 *and* fix PR49779. Also, the number of arguments need to be increased, let's go big and automatic here. Other than that I think this looks go

[PATCH] D95976: [OpenMP] Simplify offloading parallel call codegen

ggeorgakoudis added a comment. Hi @Meinersbur (got word you are a windows user), @jdoerfert, could I ask your help in detecting why the clang tests on windows are failing? There are two failures I'm spotting, one is that calls to llvm.nvvm intrinsics seem transposed (https://reviews.llvm.org/ha

[PATCH] D95976: [OpenMP] Simplify offloading parallel call codegen

ggeorgakoudis updated this revision to Diff 337556. ggeorgakoudis added a comment. Fix llvm test Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D95976/new/ https://reviews.llvm.org/D95976 Files: clang/lib/CodeGen/CGOpenMPRuntimeGPU.cpp clang/tes

[PATCH] D95976: [OpenMP] Simplify offloading parallel call codegen

ggeorgakoudis updated this revision to Diff 337183. ggeorgakoudis added a comment. Add aux-triple to one test, check unit test builder on windows Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D95976/new/ https://reviews.llvm.org/D95976 Files: cla

[PATCH] D95976: [OpenMP] Simplify offloading parallel call codegen

ggeorgakoudis updated this revision to Diff 337141. ggeorgakoudis added a comment. Herald added a subscriber: hiraditya. Add tests, update OpenMPOpt, rebase to main Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D95976/new/ https://reviews.llvm.org/D

[PATCH] D95976: [OpenMP] Simplify offloading parallel call codegen

ggeorgakoudis updated this revision to Diff 321375. ggeorgakoudis added a comment. Fix type for IfCond, formatting Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D95976/new/ https://reviews.llvm.org/D95976 Files: clang/lib/CodeGen/CGOpenMPRuntimeG

[PATCH] D95976: [OpenMP] Simplify offloading parallel call codegen

ggeorgakoudis created this revision. Herald added subscribers: jfb, guansong, yaxunl. ggeorgakoudis requested review of this revision. Herald added a reviewer: jdoerfert. Herald added subscribers: llvm-commits, openmp-commits, cfe-commits, sstefan1. Herald added projects: clang, OpenMP, LLVM. Repo