jansvoboda11 created this revision.
Herald added a subscriber: wenlei.
jansvoboda11 requested review of this revision.
Herald added a project: clang.
Herald added a subscriber: cfe-commits.
This patch moves the creation of the '-Wspir-compat' argument from cc1 to the
driver.
Without this change,
Anastasia added inline comments.
Comment at: clang/lib/Driver/ToolChains/Clang.cpp:4267
+ if (Triple.isSPIR())
+CmdArgs.push_back("-Wspir-compat");
It seems like this should have been in `addClangWarningOptions` but there is no
toolchain for SPIR?
Could
jansvoboda11 updated this revision to Diff 324959.
jansvoboda11 added a comment.
Add FIXME
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D97041/new/
https://reviews.llvm.org/D97041
Files:
clang/lib/Driver/ToolChains/Clang.cpp
clang/lib/Frontend
jansvoboda11 added inline comments.
Comment at: clang/lib/Driver/ToolChains/Clang.cpp:4267
+ if (Triple.isSPIR())
+CmdArgs.push_back("-Wspir-compat");
Anastasia wrote:
> It seems like this should have been in `addClangWarningOptions` but there is
> no too
Anastasia accepted this revision.
Anastasia added a comment.
This revision is now accepted and ready to land.
LGTM! Thanks
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D97041/new/
https://reviews.llvm.org/D97041
___
This revision was landed with ongoing or failed builds.
This revision was automatically updated to reflect the committed changes.
Closed by commit rG820e0c49fc48: [clang][cli] Pass '-Wspir-compat' to
cc1 from driver (authored by jansvoboda11).
Repository:
rG LLVM Github Monorepo
CHANGES SINCE
