[PATCH] D98034: [clang-tidy] Use-after-move: Ignore moves inside a try_emplace.

mboehme added a comment. First of all, sorry for submitting this change prematurely. I don't contribute to LLVM/Clang regularly and forgot that reviews should be kept open for a while after a reviewer has approved them to give others a chance to chime in. I jumped the gun here -- apologies. In

[PATCH] D98034: [clang-tidy] Use-after-move: Ignore moves inside a try_emplace.

njames93 added a comment. In D98034#2606535 , @mboehme wrote: > In D98034#2606488 , @njames93 wrote: > >> While `try_emplace` is a special case, it's may not be the only special case >> in someone's codebase, this

[PATCH] D98034: [clang-tidy] Use-after-move: Ignore moves inside a try_emplace.

mboehme added a comment. In D98034#2606488 , @njames93 wrote: > While `try_emplace` is a special case, it's may not be the only special case > in someone's codebase, this should be extended with options to let users > handle their special containers. So

[PATCH] D98034: [clang-tidy] Use-after-move: Ignore moves inside a try_emplace.

This revision was not accepted when it landed; it landed in state "Needs Revision". This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. mboehme marked 3 inline comments as done. Closed by commit rGe67d91faec21: [clang-ti

[PATCH] D98034: [clang-tidy] Use-after-move: Ignore moves inside a try_emplace.

njames93 added a comment. In D98034#2606488 , @njames93 wrote: > While `try_emplace` is a special case, it's may not be the only special case > in someone's codebase, this should be extended with options to let users > handle their special containers.

[PATCH] D98034: [clang-tidy] Use-after-move: Ignore moves inside a try_emplace.

njames93 requested changes to this revision. njames93 added a comment. This revision now requires changes to proceed. While `try_emplace` is a special case, it's may not be the only special case in someone's codebase, this should be behind extended with options to let users handle their special

[PATCH] D98034: [clang-tidy] Use-after-move: Ignore moves inside a try_emplace.

mboehme marked 5 inline comments as done. mboehme added inline comments. Comment at: clang-tools-extra/clang-tidy/bugprone/UseAfterMoveCheck.cpp:396 void UseAfterMoveCheck::registerMatchers(MatchFinder *Finder) { + auto StandardMapMatcher = + hasType(hasUnqualifiedDesugare

[PATCH] D98034: [clang-tidy] Use-after-move: Ignore moves inside a try_emplace.

mboehme updated this revision to Diff 328491. mboehme added a comment. Responses to review comments. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D98034/new/ https://reviews.llvm.org/D98034 Files: clang-tools-extra/clang-tidy/bugprone/UseAfterMoveCheck.cpp clang-tools-extra/docs/cl

[PATCH] D98034: [clang-tidy] Use-after-move: Ignore moves inside a try_emplace.

sammccall accepted this revision. sammccall added a comment. This revision is now accepted and ready to land. Nice! Only substantive suggestion: I think requiring the base type to be exactly a standard map type is too conservative. Comment at: clang-tools-extra/clang-tidy/bugp

[PATCH] D98034: [clang-tidy] Use-after-move: Ignore moves inside a try_emplace.

mboehme created this revision. mboehme added a reviewer: sammccall. mboehme added a project: clang-tools-extra. Herald added a subscriber: xazax.hun. mboehme requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. We have no way to reason about the