[PATCH] D99554: [ThinLTO] During module importing, close one source module before open another one for distributed mode.

2021-04-19 Thread Teresa Johnson via Phabricator via cfe-commits
tejohnson added a comment. In D99554#2674229 , @wenlei wrote: > Does this help non-distributed ThinLTO as well? cc: @weiwang No. See the note in Wei's description about this: > Note that this patch only changes the distributed thinlto mode. For in > pro

[PATCH] D99554: [ThinLTO] During module importing, close one source module before open another one for distributed mode.

2021-04-07 Thread Wenlei He via Phabricator via cfe-commits
wenlei added subscribers: weiwang, wenlei. wenlei added a comment. Does this help non-distributed ThinLTO as well? cc: @weiwang Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D99554/new/ https://reviews.llvm.org/D99554 __

[PATCH] D99554: [ThinLTO] During module importing, close one source module before open another one for distributed mode.

2021-03-30 Thread Wei Mi via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rGd535a05ca1a6: [ThinLTO] During module importing, close one source module before open (authored by wmi). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D99554/n

[PATCH] D99554: [ThinLTO] During module importing, close one source module before open another one for distributed mode.

2021-03-30 Thread Wei Mi via Phabricator via cfe-commits
wmi added inline comments. Comment at: clang/lib/CodeGen/BackendUtil.cpp:1583 ModuleToDefinedGVSummaries[M->getModuleIdentifier()], - ModuleMap, CGOpts.CmdArgs)) { + nullptr, CGOpts.CmdArgs)) { handleAllErrors(

[PATCH] D99554: [ThinLTO] During module importing, close one source module before open another one for distributed mode.

2021-03-30 Thread Wei Mi via Phabricator via cfe-commits
wmi updated this revision to Diff 334240. wmi added a comment. Address Teresa's comment. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D99554/new/ https://reviews.llvm.org/D99554 Files: clang/lib/CodeGen/BackendUtil.cpp clang/test/CodeGen/thinl

[PATCH] D99554: [ThinLTO] During module importing, close one source module before open another one for distributed mode.

2021-03-30 Thread Teresa Johnson via Phabricator via cfe-commits
tejohnson accepted this revision. tejohnson added a comment. This revision is now accepted and ready to land. LGTM with a couple of comment requests noted below. Comment at: clang/lib/CodeGen/BackendUtil.cpp:1583 ModuleToDefinedGVSummaries[M->getModuleIde

[PATCH] D99554: [ThinLTO] During module importing, close one source module before open another one for distributed mode.

2021-03-29 Thread Wei Mi via Phabricator via cfe-commits
wmi created this revision. wmi added a reviewer: tejohnson. Herald added subscribers: steven_wu, hiraditya, inglorion. wmi requested review of this revision. Herald added projects: clang, LLVM. Herald added a subscriber: cfe-commits. Currently during module importing, ThinLTO opens all the source