dwblaikie wrote:
> > I will say, `-fno-eliminate-unused-debug-types` is a really heavy hammer
> > that makes debug info much larger - and my understanding was that games
> > tended to have trouble with large debug builds, so I'd be surprised if this
> > was a great path forward.
>
>
aganea wrote:
> I will say, `-fno-eliminate-unused-debug-types` is a really heavy hammer that
> makes debug info much larger - and my understanding was that games tended to
> have trouble with large debug builds, so I'd be surprised if this was a great
> path forward.
Absolutely, this is
dwblaikie wrote:
I will say, `-fno-eliminate-unused-debug-types` is a really heavy hammer that
makes debug info much larger - and my understanding was that games tended to
have trouble with large debug builds, so I'd be surprised if this was a great
path forward.
Do you have a small example
dwblaikie wrote:
Yes, the initializers do have to be lazyily evaluated to be a conforming C++
compiler.
eg: this code must compile without error so far as I understand:
```
template
struct t1 {
static constexpr int x = 3 / Value;
};
t1<0> v1;
```
Though it seems MSVC doesn't implement this
aganea wrote:
> Yes, feel free to take over that part, thanks!
@amykhuang : I took a look at https://reviews.llvm.org/D89286. It works but
doesn't fix the most problematic case where the `constexpr` member needs an
evaluation that relies on dependent values:
```
template
struct C {
amykhuang wrote:
Yes, feel free to take over that part, thanks!
https://github.com/llvm/llvm-project/pull/95259
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/aganea closed https://github.com/llvm/llvm-project/pull/95259
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
aganea wrote:
Thanks @amykhuang for taking a look!
I won't close https://github.com/llvm/llvm-project/issues/46924 right away,
since we also need https://reviews.llvm.org/D89286. Do you mind if I took
ownership of that patch and send a PR crediting you?
https://github.com/aganea edited https://github.com/llvm/llvm-project/pull/95259
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/aganea edited https://github.com/llvm/llvm-project/pull/95259
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/amykhuang approved this pull request.
Looks reasonable to me.
https://github.com/llvm/llvm-project/pull/95259
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
llvmbot wrote:
@llvm/pr-subscribers-clang
Author: Alexandre Ganea (aganea)
Changes
This is used to set DebugInfoKind to "UnusedTypeInfo". This helps in the
context Unreal Engine and NATVIS files that reference unused otherwise `static
constexpr` class members. See
llvmbot wrote:
@llvm/pr-subscribers-clang-driver
Author: Alexandre Ganea (aganea)
Changes
This is used to set DebugInfoKind to "UnusedTypeInfo". This helps in the
context Unreal Engine and NATVIS files that reference unused otherwise `static
constexpr` class members. See
https://github.com/aganea created
https://github.com/llvm/llvm-project/pull/95259
This is used to set DebugInfoKind to "UnusedTypeInfo". This helps in the
context Unreal Engine and NATVIS files that reference unused otherwise `static
constexpr` class members. See
14 matches
Mail list logo
