[clang] [Clang] Fix the for statement disappearing in AST when an error occurs in the conditional expression of the for statement (PR #65381)

https://github.com/yronglin closed https://github.com/llvm/llvm-project/pull/65381 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [Clang] Fix the for statement disappearing in AST when an error occurs in the conditional expression of the for statement (PR #65381)

https://github.com/yronglin updated https://github.com/llvm/llvm-project/pull/65381: >From 51ba9cb126aa03b3add9d2705c10d3fa4f6acb39 Mon Sep 17 00:00:00 2001 From: yronglin Date: Wed, 6 Sep 2023 00:00:18 +0800 Subject: [PATCH 1/2] [Clang] Fix the do while statement disappearing in AST when an

[clang] [Clang] Fix the for statement disappearing in AST when an error occurs in the conditional expression of the for statement (PR #65381)

https://github.com/yronglin updated https://github.com/llvm/llvm-project/pull/65381: >From d1b0d467c3acd05a3f9a131511cd89be25d0d61a Mon Sep 17 00:00:00 2001 From: yronglin Date: Wed, 6 Sep 2023 00:00:18 +0800 Subject: [PATCH 1/2] [Clang] Fix the do while statement disappearing in AST when an

[clang] [Clang] Fix the for statement disappearing in AST when an error occurs in the conditional expression of the for statement (PR #65381)

https://github.com/yronglin updated https://github.com/llvm/llvm-project/pull/65381: >From 17891138b539c47556986f0bef5eba2ae2e6efea Mon Sep 17 00:00:00 2001 From: yronglin Date: Wed, 6 Sep 2023 00:00:18 +0800 Subject: [PATCH 1/2] [Clang] Fix the do while statement disappearing in AST when an

[clang] [Clang] Fix the for statement disappearing in AST when an error occurs in the conditional expression of the for statement (PR #65381)

https://github.com/yronglin updated https://github.com/llvm/llvm-project/pull/65381: >From 2500d388aef29b3fc4cb376057b7d42b2e9807ba Mon Sep 17 00:00:00 2001 From: yronglin Date: Wed, 6 Sep 2023 00:00:18 +0800 Subject: [PATCH 1/2] [Clang] Fix the do while statement disappearing in AST when an

[clang] [Clang] Fix the for statement disappearing in AST when an error occurs in the conditional expression of the for statement (PR #65381)

https://github.com/yronglin updated https://github.com/llvm/llvm-project/pull/65381: >From d4bef144b3b0d53aaf2a68f24a596f71c7205317 Mon Sep 17 00:00:00 2001 From: yronglin Date: Wed, 6 Sep 2023 00:00:18 +0800 Subject: [PATCH 1/2] [Clang] Fix the do while statement disappearing in AST when an

[clang] [Clang] Fix the for statement disappearing in AST when an error occurs in the conditional expression of the for statement (PR #65381)

yronglin wrote: Thanks for the review! @cor3ntin @shafik , wait for CI green. https://github.com/llvm/llvm-project/pull/65381 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [Clang] Fix the for statement disappearing in AST when an error occurs in the conditional expression of the for statement (PR #65381)

https://github.com/yronglin updated https://github.com/llvm/llvm-project/pull/65381: >From 1eb3e96d9cfc843139e6198b59bed56bac288a3c Mon Sep 17 00:00:00 2001 From: yronglin Date: Wed, 6 Sep 2023 00:00:18 +0800 Subject: [PATCH 1/2] [Clang] Fix the do while statement disappearing in AST when an

[clang] [Clang] Fix the for statement disappearing in AST when an error occurs in the conditional expression of the for statement (PR #65381)

https://github.com/yronglin resolved https://github.com/llvm/llvm-project/pull/65381 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [Clang] Fix the for statement disappearing in AST when an error occurs in the conditional expression of the for statement (PR #65381)

https://github.com/yronglin updated https://github.com/llvm/llvm-project/pull/65381: >From ee5c987880d4c9d9fec1780e28833b30b2753faa Mon Sep 17 00:00:00 2001 From: yronglin Date: Wed, 6 Sep 2023 00:00:18 +0800 Subject: [PATCH 1/2] [Clang] Fix the do while statement disappearing in AST when an

[clang] [Clang] Fix the for statement disappearing in AST when an error occurs in the conditional expression of the for statement (PR #65381)

https://github.com/cor3ntin approved this pull request. LGTM modulo @shafik's feedback https://github.com/llvm/llvm-project/pull/65381 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [Clang] Fix the for statement disappearing in AST when an error occurs in the conditional expression of the for statement (PR #65381)

@@ -2158,8 +2158,10 @@ StmtResult Parser::ParseForStatement(SourceLocation *TrailingElseLoc) { // for-range-declaration next. bool MightBeForRangeStmt = !ForRangeInfo.ParsedForRangeDecl(); ColonProtectionRAIIObject ColonProtection(*this,

[clang] [Clang] Fix the for statement disappearing in AST when an error occurs in the conditional expression of the for statement (PR #65381)

https://github.com/shafik commented: This looks good to me but I would like another set of eyes on it. https://github.com/llvm/llvm-project/pull/65381 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[clang] [Clang] Fix the for statement disappearing in AST when an error occurs in the conditional expression of the for statement (PR #65381)

https://github.com/shafik edited https://github.com/llvm/llvm-project/pull/65381 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [Clang] Fix the for statement disappearing in AST when an error occurs in the conditional expression of the for statement (PR #65381)

https://github.com/yronglin review_requested https://github.com/llvm/llvm-project/pull/65381 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [Clang] Fix the for statement disappearing in AST when an error occurs in the conditional expression of the for statement (PR #65381)

https://github.com/yronglin edited https://github.com/llvm/llvm-project/pull/65381 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits