[clang] [Clang] Wide delimiters ('{{{') for expect strings (PR #77326)

sethp wrote: Of course, thank you for tracking it down! https://github.com/llvm/llvm-project/pull/77326 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [Clang] Wide delimiters ('{{{') for expect strings (PR #77326)

ZequanWu wrote: > @ZequanWu would either of these work for you? > > ```c++ > DCHECK_OK(foo); // > expected-error@components/reporting/util/status_macros.h:* > {{{CHECK,DCHECK,ASSERT,EXPECT}_OK do not accept a type other than Status or > StatusOr.}}} > ``` > > or > > ```c++ >

[clang] [Clang] Wide delimiters ('{{{') for expect strings (PR #77326)

sethp wrote: Though, maybe we should revert this change, and gate it behind a new suffix (`expected-error-ext`?), since it is a breaking change to the verifier's mini-language. https://github.com/llvm/llvm-project/pull/77326 ___ cfe-commits mailing

[clang] [Clang] Wide delimiters ('{{{') for expect strings (PR #77326)

sethp wrote: @ZequanWu would either of these work for you?: ```c++ DCHECK_OK(foo); // expected-error@components/reporting/util/status_macros.h:* {{{CHECK,DCHECK,ASSERT,EXPECT}_OK do not accept a type other than Status or StatusOr.}}} ``` or ```c++ DCHECK_OK(foo); //

[clang] [Clang] Wide delimiters ('{{{') for expect strings (PR #77326)

ZequanWu wrote: Hi, this breaks our build. I don't know how to update the expectation to match Current expectation: DCHECK_OK(foo); // expected-error@components/reporting/util/status_macros.h:* {{{CHECK,DCHECK,ASSERT,EXPECT}_OK do not accept a type other than Status or StatusOr.}}

[clang] [Clang] Wide delimiters ('{{{') for expect strings (PR #77326)

https://github.com/erichkeane closed https://github.com/llvm/llvm-project/pull/77326 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [Clang] Wide delimiters ('{{{') for expect strings (PR #77326)

sethp wrote: Awesome, thank you for your help! https://github.com/llvm/llvm-project/pull/77326 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [Clang] Wide delimiters ('{{{') for expect strings (PR #77326)

erichkeane wrote: > I think I've followed all the steps in > https://llvm.org/docs/GitHub.html#landing-your-change except performing the > actual merge (or squash), for which I lack write permissions. Is there > anything else for me to do here? Nope! I'll put this on my list to merge when

[clang] [Clang] Wide delimiters ('{{{') for expect strings (PR #77326)

sethp wrote: I think I've followed all the steps in https://llvm.org/docs/GitHub.html#landing-your-change except performing the actual merge (or squash), for which I lack write permissions. Is there anything else for me to do here? https://github.com/llvm/llvm-project/pull/77326

[clang] [Clang] Wide delimiters ('{{{') for expect strings (PR #77326)

https://github.com/sethp updated https://github.com/llvm/llvm-project/pull/77326 >From 1afdcda3bbf695430111873a69631a07e64ff610 Mon Sep 17 00:00:00 2001 From: Seth Pellegrino Date: Sat, 6 Jan 2024 07:54:31 -0800 Subject: [PATCH] [Clang] Wide delimiters ('{{{') for expect strings Prior to this

[clang] [Clang] Wide delimiters ('{{{') for expect strings (PR #77326)

@@ -3458,8 +3461,34 @@ A range can also be specified by ``-``. For example: In this example, the diagnostic may appear only once, if at all. +.. _DiagnosticMatching: + +Matching Modes +~~ + +The default matching mode is simple string, which looks for the

[clang] [Clang] Wide delimiters ('{{{') for expect strings (PR #77326)

https://github.com/erichkeane approved this pull request. https://github.com/llvm/llvm-project/pull/77326 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [Clang] Wide delimiters ('{{{') for expect strings (PR #77326)

https://github.com/sethp updated https://github.com/llvm/llvm-project/pull/77326 >From cd0b9aed2d9e53f9b38aaa0f73336acae06bfbee Mon Sep 17 00:00:00 2001 From: Seth Pellegrino Date: Sat, 6 Jan 2024 07:54:31 -0800 Subject: [PATCH 1/4] [Clang] Wide delimiters ('{{{') for expect strings Prior to

[clang] [Clang] Wide delimiters ('{{{') for expect strings (PR #77326)

https://github.com/sethp edited https://github.com/llvm/llvm-project/pull/77326 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [Clang] Wide delimiters ('{{{') for expect strings (PR #77326)

https://github.com/sethp edited https://github.com/llvm/llvm-project/pull/77326 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [Clang] Wide delimiters ('{{{') for expect strings (PR #77326)

@@ -3458,8 +3461,34 @@ A range can also be specified by ``-``. For example: In this example, the diagnostic may appear only once, if at all. +.. _DiagnosticMatching: + +Matching Modes +~~ + +The default matching mode is simple string, which looks for the

[clang] [Clang] Wide delimiters ('{{{') for expect strings (PR #77326)

@@ -3458,8 +3461,34 @@ A range can also be specified by ``-``. For example: In this example, the diagnostic may appear only once, if at all. +.. _DiagnosticMatching: + +Matching Modes +~~ + +The default matching mode is simple string, which looks for the

[clang] [Clang] Wide delimiters ('{{{') for expect strings (PR #77326)

@@ -157,3 +157,33 @@ unexpected b; // expected-error@33 1-1 {{unknown type}} // what-error {{huh?}} // CHECK9: error: 'what-error' diagnostics expected but not seen: #endif + +#ifdef TEST_WIDE_DELIM +// RUN: not %clang_cc1 -DTEST_WIDE_DELIM -verify %s 2>&1 | FileCheck

[clang] [Clang] Wide delimiters ('{{{') for expect strings (PR #77326)

@@ -157,3 +157,33 @@ unexpected b; // expected-error@33 1-1 {{unknown type}} // what-error {{huh?}} // CHECK9: error: 'what-error' diagnostics expected but not seen: #endif + +#ifdef TEST_WIDE_DELIM +// RUN: not %clang_cc1 -DTEST_WIDE_DELIM -verify %s 2>&1 | FileCheck

[clang] [Clang] Wide delimiters ('{{{') for expect strings (PR #77326)

@@ -157,3 +157,33 @@ unexpected b; // expected-error@33 1-1 {{unknown type}} // what-error {{huh?}} // CHECK9: error: 'what-error' diagnostics expected but not seen: #endif + +#ifdef TEST_WIDE_DELIM +// RUN: not %clang_cc1 -DTEST_WIDE_DELIM -verify %s 2>&1 | FileCheck

[clang] [Clang] Wide delimiters ('{{{') for expect strings (PR #77326)

@@ -157,3 +157,33 @@ unexpected b; // expected-error@33 1-1 {{unknown type}} // what-error {{huh?}} // CHECK9: error: 'what-error' diagnostics expected but not seen: #endif + +#ifdef TEST_WIDE_DELIM +// RUN: not %clang_cc1 -DTEST_WIDE_DELIM -verify %s 2>&1 | FileCheck

[clang] [Clang] Wide delimiters ('{{{') for expect strings (PR #77326)

@@ -157,3 +157,33 @@ unexpected b; // expected-error@33 1-1 {{unknown type}} // what-error {{huh?}} // CHECK9: error: 'what-error' diagnostics expected but not seen: #endif + +#ifdef TEST_WIDE_DELIM +// RUN: not %clang_cc1 -DTEST_WIDE_DELIM -verify %s 2>&1 | FileCheck

[clang] [Clang] Wide delimiters ('{{{') for expect strings (PR #77326)

@@ -157,3 +157,33 @@ unexpected b; // expected-error@33 1-1 {{unknown type}} // what-error {{huh?}} // CHECK9: error: 'what-error' diagnostics expected but not seen: #endif + +#ifdef TEST_WIDE_DELIM +// RUN: not %clang_cc1 -DTEST_WIDE_DELIM -verify %s 2>&1 | FileCheck

[clang] [Clang] Wide delimiters ('{{{') for expect strings (PR #77326)

@@ -3458,8 +3461,34 @@ A range can also be specified by ``-``. For example: In this example, the diagnostic may appear only once, if at all. +.. _DiagnosticMatching: + +Matching Modes +~~ + +The default matching mode is simple string, which looks for the

[clang] [Clang] Wide delimiters ('{{{') for expect strings (PR #77326)

@@ -157,3 +157,33 @@ unexpected b; // expected-error@33 1-1 {{unknown type}} // what-error {{huh?}} // CHECK9: error: 'what-error' diagnostics expected but not seen: #endif + +#ifdef TEST_WIDE_DELIM +// RUN: not %clang_cc1 -DTEST_WIDE_DELIM -verify %s 2>&1 | FileCheck

[clang] [Clang] Wide delimiters ('{{{') for expect strings (PR #77326)

https://github.com/sethp updated https://github.com/llvm/llvm-project/pull/77326 >From cd0b9aed2d9e53f9b38aaa0f73336acae06bfbee Mon Sep 17 00:00:00 2001 From: Seth Pellegrino Date: Sat, 6 Jan 2024 07:54:31 -0800 Subject: [PATCH 1/3] [Clang] Wide delimiters ('{{{') for expect strings Prior to

[clang] [Clang] Wide delimiters ('{{{') for expect strings (PR #77326)

sethp wrote: Ah, perfect! I'll look into that, thank you! https://github.com/llvm/llvm-project/pull/77326 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [Clang] Wide delimiters ('{{{') for expect strings (PR #77326)

cor3ntin wrote: actually, we could add tests in `test/Frontend/verify.c`, probably. https://github.com/llvm/llvm-project/pull/77326 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [Clang] Wide delimiters ('{{{') for expect strings (PR #77326)

sethp wrote: @shafik I can, though I'm not quite sure where: my actual use-case is in a file that [doesn't exist yet](https://github.com/llvm/llvm-project/pull/74852/files#diff-f097ac693293d4002c0f9613238b5eaad14b46e30e8c2c9b1f43d8bdedfb06e1R10-R11). There's already accidentally a couple of

[clang] [Clang] Wide delimiters ('{{{') for expect strings (PR #77326)

https://github.com/shafik commented: Can we add a few tests for this change? https://github.com/llvm/llvm-project/pull/77326 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [Clang] Wide delimiters ('{{{') for expect strings (PR #77326)

sethp wrote: Ah, I was looking for those docs, thank you! I'll be sure to tweak the description there. https://github.com/llvm/llvm-project/pull/77326 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[clang] [Clang] Wide delimiters ('{{{') for expect strings (PR #77326)

erichkeane wrote: Can you update https://clang.llvm.org/docs/InternalsManual.html#verifying-diagnostics as well please? It should be in-repo, but we should make sure that keeps up to date here. Else, LGTM, thanks! https://github.com/llvm/llvm-project/pull/77326

[clang] [Clang] Wide delimiters ('{{{') for expect strings (PR #77326)

https://github.com/cor3ntin approved this pull request. Looks reasonable to me, thanks! https://github.com/llvm/llvm-project/pull/77326 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [Clang] Wide delimiters ('{{{') for expect strings (PR #77326)

https://github.com/sethp edited https://github.com/llvm/llvm-project/pull/77326 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [Clang] Wide delimiters ('{{{') for expect strings (PR #77326)

llvmbot wrote: @llvm/pr-subscribers-clang Author: None (sethp) Changes Prior to this commit, it was impossible to use the simple string matching directives to look for most content that contains `{{`, such as: ``` // expected-note {{my_struct{{1}, 2}}} ``` Which would parse like so:

[clang] [Clang] Wide delimiters ('{{{') for expect strings (PR #77326)

github-actions[bot] wrote: Thank you for submitting a Pull Request (PR) to the LLVM Project! This PR will be automatically labeled and the relevant teams will be notified. If you wish to, you can add reviewers by using the "Reviewers" section on this page. If this is not working for you, it

[clang] [Clang] Wide delimiters ('{{{') for expect strings (PR #77326)

https://github.com/sethp created https://github.com/llvm/llvm-project/pull/77326 Prior to this commit, it was impossible to use the simple string matching directives to look for most content that contains `{{`, such as: ``` // expected-note {{my_struct{{1}, 2}}} ``` Which would parse like so: