https://github.com/yxsamliu closed
https://github.com/llvm/llvm-project/pull/88827
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
yxsamliu wrote:
> Seems the documentation builder is complaining, maybe something wrong with
> the .rst file.
It is passing now
https://github.com/llvm/llvm-project/pull/88827
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://github.com/yxsamliu updated
https://github.com/llvm/llvm-project/pull/88827
>From 7574258faa28a43549e507d08128ba700c42acc8 Mon Sep 17 00:00:00 2001
From: "Yaxun (Sam) Liu"
Date: Mon, 15 Apr 2024 18:02:42 -0400
Subject: [PATCH] [ClangOffloadBundler] Add file size to header
jhuber6 wrote:
Seems the documentation builder is complaining, maybe something wrong with the
.rst file.
https://github.com/llvm/llvm-project/pull/88827
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
jhuber6 wrote:
> > Isn't this ABI breaking since we're changing the size of the struct?
> > Shouldn't that necessitate a new version?
> > Also unrelated, I wonder if there's a future where we can use the
> > ClangOffloadPackager format in the HIP runtime.
>
> I think you are right. Although
https://github.com/yxsamliu updated
https://github.com/llvm/llvm-project/pull/88827
>From fec9509f0c9162331fd2a7757e74b8c8408990c0 Mon Sep 17 00:00:00 2001
From: "Yaxun (Sam) Liu"
Date: Mon, 15 Apr 2024 18:02:42 -0400
Subject: [PATCH] [ClangOffloadBundler] Add file size to header
https://github.com/yxsamliu updated
https://github.com/llvm/llvm-project/pull/88827
>From d18a8c971d0220bafad643bb883b90c03f483913 Mon Sep 17 00:00:00 2001
From: "Yaxun (Sam) Liu"
Date: Mon, 15 Apr 2024 18:02:42 -0400
Subject: [PATCH] [ClangOffloadBundler] Add file size to header
yxsamliu wrote:
> Isn't this ABI breaking since we're changing the size of the struct?
> Shouldn't that necessitate a new version?
>
> Also unrelated, I wonder if there's a future where we can use the
> ClangOffloadPackager format in the HIP runtime.
I think you are right. Although this
https://github.com/jhuber6 commented:
Isn't this ABI breaking since we're changing the size of the struct? Shouldn't
that necessitate a new version?
Also unrelated, I wonder if there's a future where we can use the
ClangOffloadPackager format in the HIP runtime.
https://github.com/yxsamliu updated
https://github.com/llvm/llvm-project/pull/88827
>From c89b262fc8283d985ac31966de73764aedd140af Mon Sep 17 00:00:00 2001
From: "Yaxun (Sam) Liu"
Date: Mon, 15 Apr 2024 18:02:42 -0400
Subject: [PATCH] [ClangOffloadBundler] Add file size to header
llvmbot wrote:
@llvm/pr-subscribers-clang-driver
@llvm/pr-subscribers-clang
Author: Yaxun (Sam) Liu (yxsamliu)
Changes
__hipRegisterFatBinary only accepts one pointer argument. It is expected to get
the fat binary size from the header.
This patch adds a file size field to the header of
https://github.com/yxsamliu created
https://github.com/llvm/llvm-project/pull/88827
__hipRegisterFatBinary only accepts one pointer argument. It is expected to get
the fat binary size from the header.
This patch adds a file size field to the header of the compressed bundle.
>From
12 matches
Mail list logo
