https://github.com/bob80905 closed
https://github.com/llvm/llvm-project/pull/85340
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/damyanp approved this pull request.
https://github.com/llvm/llvm-project/pull/85340
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/bob80905 updated
https://github.com/llvm/llvm-project/pull/85340
>From 74a869a282d532ec426dbc1c954779ec2972aa5c Mon Sep 17 00:00:00 2001
From: Joshua Batista
Date: Thu, 14 Mar 2024 17:04:12 -0700
Subject: [PATCH 01/21] add test
---
.../clang/Basic/DiagnosticDriverKinds.td
@@ -4284,11 +4284,31 @@ bool CompilerInvocation::ParseLangArgs(LangOptions
, ArgList ,
Diags.Report(diag::err_drv_hlsl_bad_shader_unsupported)
<< ShaderModel << T.getOSName() << T.str();
}
+// Validate that if fnative-half-type is
@@ -4284,11 +4284,31 @@ bool CompilerInvocation::ParseLangArgs(LangOptions
, ArgList ,
Diags.Report(diag::err_drv_hlsl_bad_shader_unsupported)
<< ShaderModel << T.getOSName() << T.str();
}
+// Validate that if fnative-half-type is
https://github.com/sudonatalie approved this pull request.
https://github.com/llvm/llvm-project/pull/85340
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
@@ -0,0 +1,19 @@
+// RUN: not %clang_dxc -enable-16bit-types -T cs_6_0 -HV 2016 %s 2>&1 |
FileCheck -check-prefix=both_invalid %s
+// RUN: not %clang_dxc -enable-16bit-types -T lib_6_4 -HV 2017 %s 2>&1 |
FileCheck -check-prefix=HV_invalid %s
+// RUN: not %clang_dxc
https://github.com/sudonatalie edited
https://github.com/llvm/llvm-project/pull/85340
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
@@ -4284,11 +4284,31 @@ bool CompilerInvocation::ParseLangArgs(LangOptions
, ArgList ,
Diags.Report(diag::err_drv_hlsl_bad_shader_unsupported)
<< ShaderModel << T.getOSName() << T.str();
}
+// Validate that if fnative-half-type is
https://github.com/bob80905 updated
https://github.com/llvm/llvm-project/pull/85340
>From 74a869a282d532ec426dbc1c954779ec2972aa5c Mon Sep 17 00:00:00 2001
From: Joshua Batista
Date: Thu, 14 Mar 2024 17:04:12 -0700
Subject: [PATCH 01/20] add test
---
.../clang/Basic/DiagnosticDriverKinds.td
https://github.com/bob80905 updated
https://github.com/llvm/llvm-project/pull/85340
>From 74a869a282d532ec426dbc1c954779ec2972aa5c Mon Sep 17 00:00:00 2001
From: Joshua Batista
Date: Thu, 14 Mar 2024 17:04:12 -0700
Subject: [PATCH 01/19] add test
---
.../clang/Basic/DiagnosticDriverKinds.td
@@ -753,7 +753,10 @@ def err_drv_hlsl_unsupported_target : Error<
"HLSL code generation is unsupported for target '%0'">;
def err_drv_hlsl_bad_shader_required_in_target : Error<
"%select{shader model|Vulkan environment|shader stage}0 is required as
https://github.com/llvm-beanz edited
https://github.com/llvm/llvm-project/pull/85340
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/llvm-beanz commented:
One nit, but otherwise looks good.
https://github.com/llvm/llvm-project/pull/85340
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/bob80905 updated
https://github.com/llvm/llvm-project/pull/85340
>From 74a869a282d532ec426dbc1c954779ec2972aa5c Mon Sep 17 00:00:00 2001
From: Joshua Batista
Date: Thu, 14 Mar 2024 17:04:12 -0700
Subject: [PATCH 01/18] add test
---
.../clang/Basic/DiagnosticDriverKinds.td
@@ -753,7 +753,10 @@ def err_drv_hlsl_unsupported_target : Error<
"HLSL code generation is unsupported for target '%0'">;
def err_drv_hlsl_bad_shader_required_in_target : Error<
"%select{shader model|Vulkan environment|shader stage}0 is required as
@@ -0,0 +1,20 @@
+// RUN: not %clang_dxc -enable-16bit-types -T cs_6_0 -HV 2016 %s 2>&1 |
FileCheck -check-prefix=both_invalid %s
+// RUN: not %clang_dxc -enable-16bit-types -T lib_6_4 -HV 2017 %s 2>&1 |
FileCheck -check-prefix=HV_invalid %s
+// RUN: not %clang_dxc
@@ -4284,11 +4284,25 @@ bool CompilerInvocation::ParseLangArgs(LangOptions
, ArgList ,
Diags.Report(diag::err_drv_hlsl_bad_shader_unsupported)
<< ShaderModel << T.getOSName() << T.str();
}
+// validate that if fnative-half-type is
@@ -4284,11 +4284,25 @@ bool CompilerInvocation::ParseLangArgs(LangOptions
, ArgList ,
Diags.Report(diag::err_drv_hlsl_bad_shader_unsupported)
<< ShaderModel << T.getOSName() << T.str();
}
+// validate that if fnative-half-type is
@@ -753,7 +753,10 @@ def err_drv_hlsl_unsupported_target : Error<
"HLSL code generation is unsupported for target '%0'">;
def err_drv_hlsl_bad_shader_required_in_target : Error<
"%select{shader model|Vulkan environment|shader stage}0 is required as
@@ -4284,11 +4284,25 @@ bool CompilerInvocation::ParseLangArgs(LangOptions
, ArgList ,
Diags.Report(diag::err_drv_hlsl_bad_shader_unsupported)
<< ShaderModel << T.getOSName() << T.str();
}
+// validate that if fnative-half-type is
@@ -753,7 +753,10 @@ def err_drv_hlsl_unsupported_target : Error<
"HLSL code generation is unsupported for target '%0'">;
def err_drv_hlsl_bad_shader_required_in_target : Error<
"%select{shader model|Vulkan environment|shader stage}0 is required as
@@ -0,0 +1,20 @@
+// RUN: not %clang_dxc -enable-16bit-types -T cs_6_0 -HV 2016 %s 2>&1 |
FileCheck -check-prefix=both_invalid %s
+// RUN: not %clang_dxc -enable-16bit-types -T lib_6_4 -HV 2017 %s 2>&1 |
FileCheck -check-prefix=HV_invalid %s
+// RUN: not %clang_dxc
@@ -753,7 +753,10 @@ def err_drv_hlsl_unsupported_target : Error<
"HLSL code generation is unsupported for target '%0'">;
def err_drv_hlsl_bad_shader_required_in_target : Error<
"%select{shader model|Vulkan environment|shader stage}0 is required as
https://github.com/bob80905 updated
https://github.com/llvm/llvm-project/pull/85340
>From 74a869a282d532ec426dbc1c954779ec2972aa5c Mon Sep 17 00:00:00 2001
From: Joshua Batista
Date: Thu, 14 Mar 2024 17:04:12 -0700
Subject: [PATCH 01/17] add test
---
.../clang/Basic/DiagnosticDriverKinds.td
https://github.com/bob80905 updated
https://github.com/llvm/llvm-project/pull/85340
>From 74a869a282d532ec426dbc1c954779ec2972aa5c Mon Sep 17 00:00:00 2001
From: Joshua Batista
Date: Thu, 14 Mar 2024 17:04:12 -0700
Subject: [PATCH 01/16] add test
---
.../clang/Basic/DiagnosticDriverKinds.td
https://github.com/bob80905 updated
https://github.com/llvm/llvm-project/pull/85340
>From 74a869a282d532ec426dbc1c954779ec2972aa5c Mon Sep 17 00:00:00 2001
From: Joshua Batista
Date: Thu, 14 Mar 2024 17:04:12 -0700
Subject: [PATCH 01/15] add test
---
.../clang/Basic/DiagnosticDriverKinds.td
https://github.com/bob80905 updated
https://github.com/llvm/llvm-project/pull/85340
>From 3ba14cb55a85bf8bd0ed0cae43af657c6946acb8 Mon Sep 17 00:00:00 2001
From: Joshua Batista
Date: Thu, 14 Mar 2024 17:04:12 -0700
Subject: [PATCH 01/15] add test
---
.../clang/Basic/DiagnosticDriverKinds.td
github-actions[bot] wrote:
:white_check_mark: With the latest revision this PR passed the Python code
formatter.
https://github.com/llvm/llvm-project/pull/85340
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
github-actions[bot] wrote:
:white_check_mark: With the latest revision this PR passed the C/C++ code
formatter.
https://github.com/llvm/llvm-project/pull/85340
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://github.com/bob80905 updated
https://github.com/llvm/llvm-project/pull/85340
>From 3cdcfa4e63550b9677c8ffe2f33eab85899b2c45 Mon Sep 17 00:00:00 2001
From: Joshua Batista
Date: Thu, 14 Mar 2024 17:04:12 -0700
Subject: [PATCH 1/9] add test
---
.../clang/Basic/DiagnosticDriverKinds.td
@@ -4258,6 +4258,18 @@ bool CompilerInvocation::ParseLangArgs(LangOptions
, ArgList ,
} else {
llvm_unreachable("expected DXIL or SPIR-V target");
}
+ // validate that if fnative-half-type is given, that
+ // the language standard is at least
@@ -4258,6 +4258,18 @@ bool CompilerInvocation::ParseLangArgs(LangOptions
, ArgList ,
} else {
llvm_unreachable("expected DXIL or SPIR-V target");
}
+ // validate that if fnative-half-type is given, that
+ // the language standard is at least
https://github.com/bob80905 updated
https://github.com/llvm/llvm-project/pull/85340
>From 3cdcfa4e63550b9677c8ffe2f33eab85899b2c45 Mon Sep 17 00:00:00 2001
From: Joshua Batista
Date: Thu, 14 Mar 2024 17:04:12 -0700
Subject: [PATCH 1/8] add test
---
.../clang/Basic/DiagnosticDriverKinds.td
@@ -4258,6 +4258,18 @@ bool CompilerInvocation::ParseLangArgs(LangOptions
, ArgList ,
} else {
llvm_unreachable("expected DXIL or SPIR-V target");
}
+ // validate that if fnative-half-type is given, that
+ // the language standard is at least
@@ -4258,6 +4258,18 @@ bool CompilerInvocation::ParseLangArgs(LangOptions
, ArgList ,
} else {
llvm_unreachable("expected DXIL or SPIR-V target");
}
+ // validate that if fnative-half-type is given, that
+ // the language standard is at least
@@ -4258,6 +4258,18 @@ bool CompilerInvocation::ParseLangArgs(LangOptions
, ArgList ,
} else {
llvm_unreachable("expected DXIL or SPIR-V target");
}
+ // validate that if fnative-half-type is given, that
+ // the language standard is at least
@@ -4258,6 +4258,18 @@ bool CompilerInvocation::ParseLangArgs(LangOptions
, ArgList ,
} else {
llvm_unreachable("expected DXIL or SPIR-V target");
}
+ // validate that if fnative-half-type is given, that
+ // the language standard is at least
@@ -4258,6 +4258,18 @@ bool CompilerInvocation::ParseLangArgs(LangOptions
, ArgList ,
} else {
llvm_unreachable("expected DXIL or SPIR-V target");
}
+ // validate that if fnative-half-type is given, that
+ // the language standard is at least
https://github.com/bob80905 updated
https://github.com/llvm/llvm-project/pull/85340
>From 3cdcfa4e63550b9677c8ffe2f33eab85899b2c45 Mon Sep 17 00:00:00 2001
From: Joshua Batista
Date: Thu, 14 Mar 2024 17:04:12 -0700
Subject: [PATCH 1/7] add test
---
.../clang/Basic/DiagnosticDriverKinds.td
@@ -753,7 +753,8 @@ def err_drv_hlsl_unsupported_target : Error<
"HLSL code generation is unsupported for target '%0'">;
def err_drv_hlsl_bad_shader_required_in_target : Error<
"%select{shader model|Vulkan environment|shader stage}0 is required as
%select{OS|environment}1
@@ -4258,6 +4258,18 @@ bool CompilerInvocation::ParseLangArgs(LangOptions
, ArgList ,
} else {
llvm_unreachable("expected DXIL or SPIR-V target");
}
+ // validate that if fnative-half-type is given, that
+ // the language standard is at least
https://github.com/damyanp edited
https://github.com/llvm/llvm-project/pull/85340
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
@@ -4258,6 +4258,18 @@ bool CompilerInvocation::ParseLangArgs(LangOptions
, ArgList ,
} else {
llvm_unreachable("expected DXIL or SPIR-V target");
}
+ // validate that if fnative-half-type is given, that
+ // the language standard is at least
https://github.com/damyanp requested changes to this pull request.
I'm worried about what this'll do when `T.isSPIRVLogical()`.
https://github.com/llvm/llvm-project/pull/85340
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
@@ -4258,6 +4258,18 @@ bool CompilerInvocation::ParseLangArgs(LangOptions
, ArgList ,
} else {
llvm_unreachable("expected DXIL or SPIR-V target");
}
+ // validate that if fnative-half-type is given, that
+ // the language standard is at least
https://github.com/bob80905 updated
https://github.com/llvm/llvm-project/pull/85340
>From 3cdcfa4e63550b9677c8ffe2f33eab85899b2c45 Mon Sep 17 00:00:00 2001
From: Joshua Batista
Date: Thu, 14 Mar 2024 17:04:12 -0700
Subject: [PATCH 1/6] add test
---
.../clang/Basic/DiagnosticDriverKinds.td
https://github.com/bob80905 updated
https://github.com/llvm/llvm-project/pull/85340
>From 3cdcfa4e63550b9677c8ffe2f33eab85899b2c45 Mon Sep 17 00:00:00 2001
From: Joshua Batista
Date: Thu, 14 Mar 2024 17:04:12 -0700
Subject: [PATCH 1/5] add test
---
.../clang/Basic/DiagnosticDriverKinds.td
https://github.com/bob80905 updated
https://github.com/llvm/llvm-project/pull/85340
>From 3cdcfa4e63550b9677c8ffe2f33eab85899b2c45 Mon Sep 17 00:00:00 2001
From: Joshua Batista
Date: Thu, 14 Mar 2024 17:04:12 -0700
Subject: [PATCH 1/4] add test
---
.../clang/Basic/DiagnosticDriverKinds.td
https://github.com/bob80905 updated
https://github.com/llvm/llvm-project/pull/85340
>From 3cdcfa4e63550b9677c8ffe2f33eab85899b2c45 Mon Sep 17 00:00:00 2001
From: Joshua Batista
Date: Thu, 14 Mar 2024 17:04:12 -0700
Subject: [PATCH 1/3] add test
---
.../clang/Basic/DiagnosticDriverKinds.td
https://github.com/bob80905 updated
https://github.com/llvm/llvm-project/pull/85340
>From 3cdcfa4e63550b9677c8ffe2f33eab85899b2c45 Mon Sep 17 00:00:00 2001
From: Joshua Batista
Date: Thu, 14 Mar 2024 17:04:12 -0700
Subject: [PATCH 1/2] add test
---
.../clang/Basic/DiagnosticDriverKinds.td
llvmbot wrote:
@llvm/pr-subscribers-clang-driver
@llvm/pr-subscribers-clang
Author: Joshua Batista (bob80905)
Changes
Previously, the clang compiler with the dxc driver would accept the
-enable-16bit-types flag without checking to see if the required conditions are
met for proper
https://github.com/bob80905 created
https://github.com/llvm/llvm-project/pull/85340
Previously, the clang compiler with the dxc driver would accept the
-enable-16bit-types flag without checking to see if the required conditions are
met for proper processing of the flag.
Specifically,
53 matches
Mail list logo
