[clang] [NFC][Clang][CodeGen] Improve performance for vtable metadata generation (PR #67066)

https://github.com/mizvekov edited https://github.com/llvm/llvm-project/pull/67066 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [NFC][Clang][CodeGen] Improve performance for vtable metadata generation (PR #67066)

https://github.com/rnk approved this pull request. https://github.com/llvm/llvm-project/pull/67066 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [NFC][Clang][CodeGen] Improve performance for vtable metadata generation (PR #67066)

https://github.com/MaskRay approved this pull request. https://github.com/llvm/llvm-project/pull/67066 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [NFC][Clang][CodeGen] Improve performance for vtable metadata generation (PR #67066)

https://github.com/mizvekov updated https://github.com/llvm/llvm-project/pull/67066 >From 44d43a8e7fa5b19671bc3f56f934dfb63a632aa4 Mon Sep 17 00:00:00 2001 From: Matheus Izvekov Date: Thu, 21 Sep 2023 22:57:27 +0200 Subject: [PATCH] [NFC][Clang][CodeGen] Improve performance for vtable metadata

[clang] [NFC][Clang][CodeGen] Improve performance for vtable metadata generation (PR #67066)

https://github.com/mizvekov edited https://github.com/llvm/llvm-project/pull/67066 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [NFC][Clang][CodeGen] Improve performance for vtable metadata generation (PR #67066)

https://github.com/mizvekov closed https://github.com/llvm/llvm-project/pull/67066 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [NFC][Clang][CodeGen] Improve performance for vtable metadata generation (PR #67066)

shafik wrote: Please next time before you commit add a more detailed description of the change so that readers of git log can get a better understanding of the change w/o having to view it in detail. https://github.com/llvm/llvm-project/pull/67066 __

[clang] [NFC][Clang][CodeGen] Improve performance for vtable metadata generation (PR #67066)

mizvekov wrote: Weird, the commit in the MR has a description, but it lost the description when merging through the github interface. https://github.com/llvm/llvm-project/pull/67066 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists

[clang] [NFC][Clang][CodeGen] Improve performance for vtable metadata generation (PR #67066)

mizvekov wrote: @kstoimenov I believe you are supposed to notify the MR in case of reverts, otherwise I could have missed this if I wasn't awake. I believe in this case the bot is misconfigured, it's using `-Werror,-Wmissing-field-initializers`, the 'error' is just a missing initializer, whic

[clang] [NFC][Clang][CodeGen] Improve performance for vtable metadata generation (PR #67066)

kstoimenov wrote: Could you please send me a link which describes that process? I assume that by MR you mean merge request? Thanks, Kirill On Mon, Oct 2, 2023 at 5:24 PM Matheus Izvekov ***@***.***> wrote: > @kstoimenov I believe you are supposed to > notify the

[clang] [NFC][Clang][CodeGen] Improve performance for vtable metadata generation (PR #67066)

mizvekov wrote: > Could you please send me a link which describes that process? I assume that > by MR you mean merge request? Thanks, Kirill > […](#) > On Mon, Oct 2, 2023 at 5:24 PM Matheus Izvekov ***@***.***> wrote: > @kstoimenov I believe you are supposed to

[clang] [NFC][Clang][CodeGen] Improve performance for vtable metadata generation (PR #67066)

vitalybuka wrote: There is automatic github notification about revert, I assume something in the email as well.  What is the value of another message? https://github.com/llvm/llvm-project/pull/67

[clang] [NFC][Clang][CodeGen] Improve performance for vtable metadata generation (PR #67066)

efriedma-quic wrote: I didn't get an an email notification for that. https://github.com/llvm/llvm-project/pull/67066 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [NFC][Clang][CodeGen] Improve performance for vtable metadata generation (PR #67066)

vitalybuka wrote: > I didn't get an an email notification for that. Thanks, good to know. I like that in Phabricator it was possible just reopen review making revert very visible to the author. https://github.com/llvm/llvm-project/pull/67066 ___ cfe-

[clang] [NFC][Clang][CodeGen] Improve performance for vtable metadata generation (PR #67066)

kstoimenov wrote: Maybe one way is to add @mention which should trigger a new email message? On Tue, Oct 3, 2023 at 12:42 PM Vitaly Buka ***@***.***> wrote: > I didn't get an an email notification for that. > > Thanks, good to know. > I like that in Phabricator it was possible just reopen revie

[clang] [NFC][Clang][CodeGen] Improve performance for vtable metadata generation (PR #67066)

efriedma-quic wrote: Maybe start a discourse thread to get more eyes on this discussion? We might be able to use a hook to make llvmbot do something automatically. https://github.com/llvm/llvm-project/pull/67066 ___ cfe-commits mailing list cfe-commi