MaskRay wrote:
I think this is fine, but we probably should think about the general option
compatibility problem
https://github.com/llvm/llvm-project/pull/70740#issuecomment-1786180822
https://github.com/llvm/llvm-project/pull/70799
___
cfe-commits
jhuber6 wrote:
> Is there some reason stack protectors don't make sense on GPU targets? Or is
> the issue just that the GPU targets in question don't have the necessary
> runtime support?
It's more of the latter as GPUs don't really have much of a runtime. That's why
I didn't want to
efriedma-quic wrote:
Is there some reason stack protectors don't make sense on GPU targets? Or is
the issue just that the GPU targets in question don't have the necessary
runtime support?
https://github.com/llvm/llvm-project/pull/70799
___
https://github.com/jhuber6 closed
https://github.com/llvm/llvm-project/pull/70799
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/shiltian approved this pull request.
I think the changes make sense.
https://github.com/llvm/llvm-project/pull/70799
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
github-actions[bot] wrote:
:warning: C/C++ code formatter, clang-format found issues in your code.
:warning:
You can test this locally with the following command:
``bash
git-clang-format --diff 562ce8bbd23d96ee64992bcda041bf67e7c51057
c1c5174d9a9bb82ba42de0aabd0a3e129cc87aa5 --
https://github.com/jhuber6 updated
https://github.com/llvm/llvm-project/pull/70799
>From c791e527ee388659b35707816c0a67bee66dd0da Mon Sep 17 00:00:00 2001
From: Joseph Huber
Date: Tue, 31 Oct 2023 08:12:01 -0500
Subject: [PATCH] [StackProtector] Do not emit the stack protector on GPU
llvmbot wrote:
@llvm/pr-subscribers-clang
Author: Joseph Huber (jhuber6)
Changes
Summary:
This patch changes the code generation to not emit the stack protector
metadata on unsupported architectures. The issue was caused by system
toolchains emitting stack protector option by default
https://github.com/jhuber6 created
https://github.com/llvm/llvm-project/pull/70799
Summary:
This patch changes the code generation to not emit the stack protector
metadata on unsupported architectures. The issue was caused by system
toolchains emitting stack protector option by default which
