Timm =?utf-8?q?Bäder?= ,
Timm =?utf-8?q?Bäder?= ,
Timm =?utf-8?q?Bäder?=
Message-ID:
In-Reply-To:
https://github.com/AaronBallman commented:
Splitting the code across a few implementation files might be a reasonable
approach, but in general, I'm fine with how this is proceeding.
I reviewed
Timm =?utf-8?q?B=C3=A4der?= ,
Timm =?utf-8?q?B=C3=A4der?= ,
Timm =?utf-8?q?B=C3=A4der?=
Message-ID:
In-Reply-To:
tbaederr wrote:
Ping
https://github.com/llvm/llvm-project/pull/83683
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
Timm =?utf-8?q?Bäder?= ,
Timm =?utf-8?q?Bäder?=
Message-ID:
In-Reply-To:
github-actions[bot] wrote:
:warning: C/C++ code formatter, clang-format found issues in your code.
:warning:
You can test this locally with the following command:
``bash
git-clang-format --diff
Timm =?utf-8?q?Bäder?= ,
Timm =?utf-8?q?Bäder?=
Message-ID:
In-Reply-To:
tbaederr wrote:
> Sorry, I thought you were still doing some investigation.
Ah, sorry, I was just trying to say that this is how far I'm going to
investigate at that point. :)
> I can live with either approach; the
Timm =?utf-8?q?Bäder?= ,
Timm =?utf-8?q?Bäder?=
Message-ID:
In-Reply-To:
AaronBallman wrote:
> Ping
Sorry, I thought you were still doing some investigation.
I can live with either approach; the CRTP way doesn't seem too awful to me and
retains the separation. But the unified interface
Timm =?utf-8?q?B=C3=A4der?= ,
Timm =?utf-8?q?B=C3=A4der?=
Message-ID:
In-Reply-To:
tbaederr wrote:
Ping
https://github.com/llvm/llvm-project/pull/83683
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
Timm =?utf-8?q?Bäder?= ,
Timm =?utf-8?q?Bäder?=
Message-ID:
In-Reply-To:
tbaederr wrote:
> How ugly does CRTP get though?
Looks like this:
https://github.com/tbaederr/llvm-project/commit/ae37a17e30978cbe8e42799d26308b2e4e7b0115
Not really a big fan.
But I'm now stuck with
```
mold:
Timm =?utf-8?q?Bäder?= ,
Timm =?utf-8?q?Bäder?=
Message-ID:
In-Reply-To:
AaronBallman wrote:
> But that's not the problem I have in mind. My problem is the other way
> around: when `ByteCodeExprGen` needs to generate code for statements. It has
> no `visitStmt` function, because that's only
Timm =?utf-8?q?Bäder?= ,
Timm =?utf-8?q?Bäder?=
Message-ID:
In-Reply-To:
tbaederr wrote:
> So ByteCodeExprGen can definitely visit statements and expressions.
Well yes, the possibility is there, but it doesn't implement any of the
functionality when visiting statements. :)
> Can't
Timm =?utf-8?q?Bäder?= ,
Timm =?utf-8?q?Bäder?=
Message-ID:
In-Reply-To:
AaronBallman wrote:
> When implementing support for `StmtExpr`, I ran into a problem: there is no
> way for `ByteCodeExprGen` to visit a statement. Previously, `ByteCodeStmtGen`
> inherited from `ByteCodeExprGen`, so
Timm =?utf-8?q?Bäder?= ,
Timm =?utf-8?q?Bäder?=
Message-ID:
In-Reply-To:
llvmbot wrote:
@llvm/pr-subscribers-clang
Author: Timm Baeder (tbaederr)
Changes
When implementing support for `StmtExpr`, I ran into a problem: there is no
way for `ByteCodeExprGen` to visit a statement.
11 matches
Mail list logo
