https://github.com/tbaederr closed
https://github.com/llvm/llvm-project/pull/66203
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
tbaederr wrote:
I've merged https://reviews.llvm.org/D155548, so closing this.
https://github.com/llvm/llvm-project/pull/66203
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
tbaederr wrote:
^ Removing integer and boolean expressions seems to have some negative impact
though.
https://github.com/llvm/llvm-project/pull/66203
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
tbaederr wrote:
http://llvm-compile-time-tracker.com/index.php?config=NewPM-O3=instructions%3Au=tbaederr
https://github.com/llvm/llvm-project/pull/66203
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
cor3ntin wrote:
> Ah, I didn't realize you had measured on your own. But yeah, having some
> concrete numbers to play with would help.
I'd like to see rough numbers too but I'm really hoping we can progress
https://reviews.llvm.org/D155548.
I think it's the worse case it's harmless, at best
AaronBallman wrote:
> > > Well, this is not going to make a noticeable difference in runtime.
> > > https://reviews.llvm.org/D155548 didn't land because there are no
> > > measurements to make where this makes a measurable difference.
> >
> >
> > Those changes didn't land because no
tbaederr wrote:
> > Well, this is not going to make a noticeable difference in runtime.
> > https://reviews.llvm.org/D155548 didn't land because there are no
> > measurements to make where this makes a measurable difference.
>
> Those changes didn't land because no measurements were
AaronBallman wrote:
> Well, this is not going to make a noticeable difference in runtime.
> https://reviews.llvm.org/D155548 didn't land because there are no
> measurements to make where this makes a measurable difference.
Those changes didn't land because no measurements were attempted.
tbaederr wrote:
Well, this is not going to make a noticeable difference in runtime.
https://reviews.llvm.org/D155548 didn't land because there are no measurements
to make where this makes a measurable difference.
As for my earlier comment, it would also make sense to rename that function to
AaronBallman wrote:
> @cor3ntin Looking at this again... while I'd also like to see the general
> solution, I'd probably apply this anyway since it makes it clearer that this
> function can actually be fast. Its name is terrible for what it does. It
> sounds like it's a simply getter but in
tbaederr wrote:
Ping
https://github.com/llvm/llvm-project/pull/66203
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
tbaederr wrote:
Ping
https://github.com/llvm/llvm-project/pull/66203
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
tbaederr wrote:
Ping
https://github.com/llvm/llvm-project/pull/66203
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
tbaederr wrote:
@cor3ntin Looking at this again... while I'd also like to see the general
solution, I'd probably apply this anyway since it makes it clearer that this
function can actually be fast. Its name is terrible for what it does. It sounds
like it's a simply getter but in reality it
https://github.com/cor3ntin requested changes to this pull request.
I knew there was a deja-vu here :)
I'd rather we do the general solution then. Maybe we should pursue the
discussion on phab. I can't imagine the general solution is going to ever be
noticeably worse.
I have the possibility
tbaederr wrote:
> Hum... should we put that in `EvaluateKnownConstInt` directly? Bitfields are
> not the only use case
See https://reviews.llvm.org/D155548 - I can't really support any of this with
performance numbers (from my testing, I can't even support that we
short-circuit
cor3ntin wrote:
Hum... should we put that in `EvaluateKnownConstInt` directly? Bitfields are
not the only use case
https://github.com/llvm/llvm-project/pull/66203
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://github.com/cor3ntin approved this pull request.
https://github.com/llvm/llvm-project/pull/66203
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
llvmbot wrote:
@llvm/pr-subscribers-clang
Changes
It's usually a ConstantExpr with a saved constant integer anyway, so we can
just return that.
--
Full diff: https://github.com/llvm/llvm-project/pull/66203.diff
1 Files Affected:
- (modified) clang/lib/AST/Decl.cpp (+8)
https://github.com/llvmbot labeled
https://github.com/llvm/llvm-project/pull/66203
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/llvmbot labeled
https://github.com/llvm/llvm-project/pull/66203
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/tbaederr review_requested
https://github.com/llvm/llvm-project/pull/66203
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/tbaederr created
https://github.com/llvm/llvm-project/pull/66203:
It's usually a ConstantExpr with a saved constant integer anyway, so we can
just return that.
>From 7668b4e5eb09b05c50ef67b23671dc2d19e12046 Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Timm=20B=C3=A4der?=
Date:
23 matches
Mail list logo
