whitequark wrote:
> but my naive thinking is that it would help in some cases but be insufficient
> in others (e.g., within Support/Unix/Path.inc, we'd still need to have a
> conditional for WASI).
`LLVM_ON_UNIX` is definitely a mixed bag for WASI and I'll take another look at
whether it
AaronBallman wrote:
Ah thank you for pointing that out, I had missed some updates on that thread.
I think `defined(__wasi__)` would address my concerns. @MaskRay asked a good
question about whether we should tie this to `LLVM_ON_UNIX` as well and I don't
have a strong intuition there, but my
whitequark wrote:
> Comments in the config file isn't a harmful thing, but I'm also worried about
> folks who never see the config file. e.g., they're working in Path.inc on
> something, see `HAVE_PWD_H` in the code, and just make assumptions from there.
>
> So perhaps a two-pronged approach:
AaronBallman wrote:
Comments in the config file isn't a harmful thing, but I'm also worried about
folks who never see the config file. e.g., they're working in Path.inc on
something, see `HAVE_PWD_H` in the code, and just make assumptions from there.
So perhaps a two-pronged approach: a
whitequark wrote:
> One concern I have is that someone adding new code may think they need to
> come up with fallback behavior in case a feature isn't available
Shall I add some comments to config.h indicating as such?
https://github.com/llvm/llvm-project/pull/92677
https://github.com/AaronBallman edited
https://github.com/llvm/llvm-project/pull/92677
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/AaronBallman commented:
Sorry for not responding sooner, but I think this approach makes sense to me.
It's basically similar to autoconf where we're checking whether a feature is
supported and guarding against it.
One concern I have is that someone adding new code may think
whitequark wrote:
I can see the build failure--I think it's related to the changes to crash
reporting, but I'm not sure how yet. I'll fix it but I'd still very much like
the feedback on the general approach.
https://github.com/llvm/llvm-project/pull/92677
https://github.com/whitequark edited
https://github.com/llvm/llvm-project/pull/92677
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/whitequark updated
https://github.com/llvm/llvm-project/pull/92677
>From 0a86da8896ccc32c82e045828e28d2f39de991f9 Mon Sep 17 00:00:00 2001
From: Catherine
Date: Sun, 19 May 2024 04:41:27 +
Subject: [PATCH] Conditionalize use of POSIX features missing on
https://github.com/whitequark updated
https://github.com/llvm/llvm-project/pull/92677
>From 4110cfe39bde72f0a0c1ed3187811db5548ecd99 Mon Sep 17 00:00:00 2001
From: Catherine
Date: Sun, 19 May 2024 04:41:27 +
Subject: [PATCH] Conditionalize use of POSIX features missing on
github-actions[bot] wrote:
:warning: C/C++ code formatter, clang-format found issues in your code.
:warning:
You can test this locally with the following command:
``bash
git-clang-format --diff 577785c5ca78a9714584b5c99ec085f8aea0a5c0
289750cd78979e4811d6fd943c0a6c3b5bd3b5dd --
https://github.com/whitequark edited
https://github.com/llvm/llvm-project/pull/92677
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
llvmbot wrote:
@llvm/pr-subscribers-clang
Author: Catherine (whitequark)
Changes
This patch is the first in a series that makes it possible to build LLVM,
Clang, and LLD for WASI/WebAssembly. This patch does not introduce conditionals
of the form `defined(__wasi__)` or
llvmbot wrote:
@llvm/pr-subscribers-llvm-support
@llvm/pr-subscribers-clang-driver
Author: Catherine (whitequark)
Changes
This patch is the first in a series that makes it possible to build LLVM,
Clang, and LLD for WASI/WebAssembly. This patch does not introduce conditionals
of the form
https://github.com/whitequark created
https://github.com/llvm/llvm-project/pull/92677
This patch is the first in a series that makes it possible to build LLVM,
Clang, and LLD for WASI/WebAssembly. This patch does not introduce conditionals
of the form `defined(__wasi__)` or
16 matches
Mail list logo
