Author: Phoebe Wang Date: 2021-11-30T14:08:10+08:00 New Revision: 42c15c7edf174fc7a45131a1b89ee816fada7633
URL: https://github.com/llvm/llvm-project/commit/42c15c7edf174fc7a45131a1b89ee816fada7633 DIFF: https://github.com/llvm/llvm-project/commit/42c15c7edf174fc7a45131a1b89ee816fada7633.diff LOG: [X86][clang] Enable floating-point type for -mno-x87 option on 32-bits We should match GCC's behavior which allows floating-point type for -mno-x87 option on 32-bits. https://godbolt.org/z/KrbhfWc9o The previous block issues have partially been fixed by D112143. Reviewed By: asavonic, nickdesaulniers Differential Revision: https://reviews.llvm.org/D114162 Added: Modified: clang/lib/Basic/Targets/X86.cpp clang/test/Sema/x86-no-x87.cpp Removed: ################################################################################ diff --git a/clang/lib/Basic/Targets/X86.cpp b/clang/lib/Basic/Targets/X86.cpp index 454a7743dded3..5c4bd364b06a3 100644 --- a/clang/lib/Basic/Targets/X86.cpp +++ b/clang/lib/Basic/Targets/X86.cpp @@ -382,12 +382,10 @@ bool X86TargetInfo::handleTargetFeatures(std::vector<std::string> &Features, SimdDefaultAlign = hasFeature("avx512f") ? 512 : hasFeature("avx") ? 256 : 128; - if (!HasX87) { - if (LongDoubleFormat == &llvm::APFloat::x87DoubleExtended()) - HasLongDouble = false; - if (getTriple().getArch() == llvm::Triple::x86) - HasFPReturn = false; - } + // FIXME: We should allow long double type on 32-bits to match with GCC. + // This requires backend to be able to lower f80 without x87 first. + if (!HasX87 && LongDoubleFormat == &llvm::APFloat::x87DoubleExtended()) + HasLongDouble = false; return true; } diff --git a/clang/test/Sema/x86-no-x87.cpp b/clang/test/Sema/x86-no-x87.cpp index 112f6bff7e1c8..2421ea15a57af 100644 --- a/clang/test/Sema/x86-no-x87.cpp +++ b/clang/test/Sema/x86-no-x87.cpp @@ -1,4 +1,4 @@ -// RUN: %clang_cc1 -fsyntax-only -verify %s -triple i686-linux-gnu -target-feature -x87 -DRET_ERROR +// RUN: %clang_cc1 -fsyntax-only -verify %s -triple i686-linux-gnu -target-feature -x87 // RUN: %clang_cc1 -fsyntax-only -verify %s -triple i686-linux-gnu -DNOERROR #ifdef NOERROR @@ -123,42 +123,22 @@ void assign5() { long_double ld = 0.42; } -#ifndef NOERROR -// expected-note@+3{{'d_ret1' defined here}} -// expected-error@+2{{'d_ret1' requires 'double' return type support, but target 'i686-unknown-linux-gnu' does not support it}} -#endif double d_ret1(float x) { return 0.0; } -#ifndef NOERROR -// expected-note@+2{{'d_ret2' defined here}} -#endif double d_ret2(float x); int d_ret3(float x) { -#ifndef NOERROR - // expected-error@+2{{'d_ret2' requires 'double' return type support, but target 'i686-unknown-linux-gnu' does not support it}} -#endif return (int)d_ret2(x); } -#ifndef NOERROR -// expected-note@+3{{'f_ret1' defined here}} -// expected-error@+2{{'f_ret1' requires 'float' return type support, but target 'i686-unknown-linux-gnu' does not support it}} -#endif float f_ret1(float x) { return 0.0f; } -#ifndef NOERROR -// expected-note@+2{{'f_ret2' defined here}} -#endif float f_ret2(float x); int f_ret3(float x) { -#ifndef NOERROR - // expected-error@+2{{'f_ret2' requires 'float' return type support, but target 'i686-unknown-linux-gnu' does not support it}} -#endif return (int)f_ret2(x); } _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits