[clang] Fix buildbot failure. (PR #86741)

2024-03-28 Thread Zahira Ammarguellat via cfe-commits
zahiraam wrote: > > Now I wonder if the fix should be with the (void) or without. Have you > > tried it locally to see if you get the same build error? > > Yes, I just tried your patch and confirmed that the unit test passes without > a problem. > > No, you shouldn't keep `(void)` there. It's

[clang] Fix buildbot failure. (PR #86741)

2024-03-28 Thread Kazu Hirata via cfe-commits
kazutakahirata wrote: > Now I wonder if the fix should be with the (void) or without. Have you tried > it locally to see if you get the same build error? Yes, I just tried your patch and confirmed that the unit test passes without a problem. No, you shouldn't keep `(void)` there. It's there

[clang] Fix buildbot failure. (PR #86741)

2024-03-28 Thread Zahira Ammarguellat via cfe-commits
https://github.com/zahiraam updated https://github.com/llvm/llvm-project/pull/86741 >From 8d113344d0742f80bc967019131c9111a0db78ff Mon Sep 17 00:00:00 2001 From: Zahira Ammarguellat Date: Tue, 26 Mar 2024 14:21:16 -0700 Subject: [PATCH] Fix buildbot https://lab.llvm.org/buildbot/#/builders/36/

[clang] Fix buildbot failure. (PR #86741)

2024-03-28 Thread Zahira Ammarguellat via cfe-commits
zahiraam wrote: > > > I thought the issue was fixed with the (void) addition! If not, I will > > > merge this PR immediately. > > > > > > Sorry, I misunderstood. The `void` fix > > ([577e0ef](https://github.com/llvm/llvm-project/commit/577e0ef94fb0b4ba9f97a6f58a1961f7ba247d21)) > > fixes the

[clang] Fix buildbot failure. (PR #86741)

2024-03-28 Thread Zahira Ammarguellat via cfe-commits
https://github.com/zahiraam updated https://github.com/llvm/llvm-project/pull/86741 >From 8d113344d0742f80bc967019131c9111a0db78ff Mon Sep 17 00:00:00 2001 From: Zahira Ammarguellat Date: Tue, 26 Mar 2024 14:21:16 -0700 Subject: [PATCH] Fix buildbot https://lab.llvm.org/buildbot/#/builders/36/

[clang] Fix buildbot failure. (PR #86741)

2024-03-28 Thread Zahira Ammarguellat via cfe-commits
https://github.com/zahiraam edited https://github.com/llvm/llvm-project/pull/86741 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] Fix buildbot failure. (PR #86741)

2024-03-28 Thread Zahira Ammarguellat via cfe-commits
zahiraam wrote: > > I thought the issue was fixed with the (void) addition! If not, I will > > merge this PR immediately. > > Sorry, I misunderstood. The `void` fix > ([577e0ef](https://github.com/llvm/llvm-project/commit/577e0ef94fb0b4ba9f97a6f58a1961f7ba247d21)) > fixes the build error. >

[clang] Fix buildbot failure. (PR #86741)

2024-03-28 Thread Kazu Hirata via cfe-commits
kazutakahirata wrote: > I thought the issue was fixed with the (void) addition! If not, I will merge > this PR immediately. Sorry, I misunderstood. The `void` fix (https://github.com/llvm/llvm-project/commit/577e0ef94fb0b4ba9f97a6f58a1961f7ba247d21) fixes the build error. Meanwhile, I am gu

[clang] Fix buildbot failure. (PR #86741)

2024-03-28 Thread Zahira Ammarguellat via cfe-commits
zahiraam wrote: > Would you mind merging this PR into the LLVM source tree if nothing is > blocking you? > > If something is blocking you, I am happy to revert your original patch on > your behalf (along with the `(void)` fix). I thought the issue was fixed with the (void) addition! If not, I

[clang] Fix buildbot failure. (PR #86741)

2024-03-28 Thread Kazu Hirata via cfe-commits
kazutakahirata wrote: Would you mind merging this PR into the LLVM source tree if nothing is blocking you? If something is blocking you, I am happy to revert your original patch on your behalf (along with the `(void)` fix). https://github.com/llvm/llvm-project/pull/86741 _

[clang] Fix buildbot failure. (PR #86741)

2024-03-27 Thread Zahira Ammarguellat via cfe-commits
https://github.com/zahiraam updated https://github.com/llvm/llvm-project/pull/86741 >From 8d113344d0742f80bc967019131c9111a0db78ff Mon Sep 17 00:00:00 2001 From: Zahira Ammarguellat Date: Tue, 26 Mar 2024 14:21:16 -0700 Subject: [PATCH] Fix buildbot https://lab.llvm.org/buildbot/#/builders/36/

[clang] Fix buildbot failure. (PR #86741)

2024-03-26 Thread Kazu Hirata via cfe-commits
https://github.com/kazutakahirata approved this pull request. LGTM. Thanks! https://github.com/llvm/llvm-project/pull/86741 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] Fix buildbot failure. (PR #86741)

2024-03-26 Thread Zahira Ammarguellat via cfe-commits
zahiraam wrote: Tagging @amy-kwan and @kazutakahirata . Hopefully this will fix the issue. https://github.com/llvm/llvm-project/pull/86741 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-comm

[clang] Fix buildbot failure. (PR #86741)

2024-03-26 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-clang Author: Zahira Ammarguellat (zahiraam) Changes https://lab.llvm.org/buildbot/#/builders/36/builds/43998/steps/12/logs/stdio --- Full diff: https://github.com/llvm/llvm-project/pull/86741.diff 1 Files Affected: - (modified) clang/unittests/AST/D

[clang] Fix buildbot failure. (PR #86741)

2024-03-26 Thread Zahira Ammarguellat via cfe-commits
https://github.com/zahiraam ready_for_review https://github.com/llvm/llvm-project/pull/86741 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] Fix buildbot failure. (PR #86741)

2024-03-26 Thread Zahira Ammarguellat via cfe-commits
https://github.com/zahiraam created https://github.com/llvm/llvm-project/pull/86741 https://lab.llvm.org/buildbot/#/builders/36/builds/43998/steps/12/logs/stdio >From 8d113344d0742f80bc967019131c9111a0db78ff Mon Sep 17 00:00:00 2001 From: Zahira Ammarguellat Date: Tue, 26 Mar 2024 14:21:16 -07