Re: [clang] a8503b8 - [NFC] Remove unused static function

2020-09-12 Thread David Blaikie via cfe-commits
On Sat, Sep 12, 2020 at 1:15 AM Vitaly Buka wrote: > build fails with -DLLVM_ENABLE_WERROR=ON > Oh, I see - it's a -Wunused-function when building with LLVM_ENABLE_DUMP off. Kristof - if/when you want to recommit this, I think the only thing you need to do is make this function not function-loc

Re: [clang] a8503b8 - [NFC] Remove unused static function

2020-09-12 Thread Vitaly Buka via cfe-commits
build fails with -DLLVM_ENABLE_WERROR=ON On Fri, 11 Sep 2020 at 23:16, Kristóf Umann wrote: > Yup, unless you this breaks something, I'd really prefer to keep it. > > On Sat, 12 Sep 2020, 03:24 David Blaikie, wrote: > >> LLVM_DUMP_METHOD is meant to be used for annotating functions that might >

Re: [clang] a8503b8 - [NFC] Remove unused static function

2020-09-11 Thread Kristóf Umann via cfe-commits
Yup, unless you this breaks something, I'd really prefer to keep it. On Sat, 12 Sep 2020, 03:24 David Blaikie, wrote: > LLVM_DUMP_METHOD is meant to be used for annotating functions that might > be useful to execute from a debugger to dump data structures, etc - so it's > expected that they'd be

Re: [clang] a8503b8 - [NFC] Remove unused static function

2020-09-11 Thread David Blaikie via cfe-commits
LLVM_DUMP_METHOD is meant to be used for annotating functions that might be useful to execute from a debugger to dump data structures, etc - so it's expected that they'd be unused. Do you find that this function is not useful to use from a debugger/similar situation? (or perhaps because the functio

[clang] a8503b8 - [NFC] Remove unused static function

2020-09-11 Thread Vitaly Buka via cfe-commits
Author: Vitaly Buka Date: 2020-09-11T16:50:30-07:00 New Revision: a8503b87f739776cc9d5738f69aa0990db952340 URL: https://github.com/llvm/llvm-project/commit/a8503b87f739776cc9d5738f69aa0990db952340 DIFF: https://github.com/llvm/llvm-project/commit/a8503b87f739776cc9d5738f69aa0990db952340.diff L