================ @@ -6872,35 +6883,6 @@ void OpenMPIRBuilder::loadOffloadInfoMetadata(StringRef HostFilePath) { loadOffloadInfoMetadata(*M.get()); } -Function *OpenMPIRBuilder::createRegisterRequires(StringRef Name) { ---------------- skatrak wrote:
Removing this function breaks the compilation of the OpenMP MLIR dialect, as it's used there (mlir/lib/Target/LLVMIR/Dialect/OpenMP/OpenMPToLLVMIRTranslation.cpp: `convertRequiresAttr()`). My understanding is that creating this function would no longer be necessary, so the solution to that should be to remove `convertRequiresAttr()` and replace the call to it in `OpenMPDialectLLVMIRTranslationInterface::amendOperation()` to `return success()` in the same file. Flang should already pick up your other changes, so REQUIRES information should still work in Fortran after this. https://github.com/llvm/llvm-project/pull/80460 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits