Re: r314262 - Emit section information for extern variables.

2017-10-04 Thread Nico Weber via cfe-commits
1:54 PM > *To:* Friedman, Eli <efrie...@codeaurora.org>; Keane, Erich < > erich.ke...@intel.com>; Nico Weber <tha...@chromium.org> > *Cc:* cfe-commits <cfe-commits@lists.llvm.org> > *Subject:* RE: r314262 - Emit section information for extern variables. >

RE: r314262 - Emit section information for extern variables.

2017-10-04 Thread Keane, Erich via cfe-commits
ommits@lists.llvm.org> Subject: RE: r314262 - Emit section information for extern variables. Alright. Will do. Thanks! From: Friedman, Eli [mailto:efrie...@codeaurora.org] Sent: Wednesday, October 4, 2017 4:51 PM To: Keane, Erich <erich.ke...@intel.com<mailto:erich.ke...@intel.com>>;

RE: r314262 - Emit section information for extern variables.

2017-10-04 Thread Andrews, Elizabeth via cfe-commits
ommits@lists.llvm.org> Subject: Re: r314262 - Emit section information for extern variables. On 10/4/2017 1:48 PM, Keane, Erich wrote: Ah, cool! I didn’t realize that, and that is actually exactly what Elizabeth is looking into now. Elizabeth, if you send me a diff, I’ll commit it as review-after-c

Re: r314262 - Emit section information for extern variables.

2017-10-04 Thread Friedman, Eli via cfe-commits
ium.org> *Cc:* cfe-commits <cfe-commits@lists.llvm.org>; Keane, Erich <erich.ke...@intel.com> *Subject:* Re: r314262 - Emit section information for extern variables. Oh, that's easy to explain; sorry, I didn't think of it when I was reviewing. DefinitionKind has three possible values:

RE: r314262 - Emit section information for extern variables.

2017-10-04 Thread Keane, Erich via cfe-commits
ndrews, Elizabeth <elizabeth.andr...@intel.com>; Nico Weber <tha...@chromium.org> Cc: cfe-commits <cfe-commits@lists.llvm.org>; Keane, Erich <erich.ke...@intel.com> Subject: Re: r314262 - Emit section information for extern variables. Oh, that's easy to explain; sorry,

Re: r314262 - Emit section information for extern variables.

2017-10-04 Thread Friedman, Eli via cfe-commits
ch.ke...@intel.com> *Cc:* Andrews, Elizabeth <elizabeth.andr...@intel.com>; Friedman, Eli <efrie...@codeaurora.org>; cfe-commits <cfe-commits@lists.llvm.org> *Subject:* Re: r314262 - Emit section information for extern variables. All I know about this code that it used t

RE: r314262 - Emit section information for extern variables.

2017-10-04 Thread Andrews, Elizabeth via cfe-commits
t;; cfe-commits <cfe-commits@lists.llvm.org> Subject: Re: r314262 - Emit section information for extern variables. All I know about this code that it used to build (and still builds with gcc) and now it doesn't, sorry :-) What that code does seems somewhat questionable, but also somewhat useful, and

RE: r314262 - Emit section information for extern variables.

2017-10-04 Thread Keane, Erich via cfe-commits
intel.com>; Friedman, Eli <efrie...@codeaurora.org>; cfe-commits <cfe-commits@lists.llvm.org> Subject: Re: r314262 - Emit section information for extern variables. All I know about this code that it used to build (and still builds with gcc) and now it doesn't, sorry :-) What that

Re: r314262 - Emit section information for extern variables.

2017-10-04 Thread Nico Weber via cfe-commits
> *From:* tha...@google.com [mailto:tha...@google.com] *On Behalf Of *Nico > Weber > *Sent:* Wednesday, October 4, 2017 1:14 PM > *To:* Keane, Erich <erich.ke...@intel.com> > *Cc:* Andrews, Elizabeth <elizabeth.andr...@intel.com>; Friedman, Eli < > efrie...@codea

RE: r314262 - Emit section information for extern variables.

2017-10-04 Thread Keane, Erich via cfe-commits
eaurora.org>; cfe-commits <cfe-commits@lists.llvm.org> Subject: Re: r314262 - Emit section information for extern variables. For why, here's the comment from the code I linked to: /* * GDB looks for this symbol name when it cannot find PT_DYNAMIC->DT_DEBUG. * We don't have a PT_DYN

Re: r314262 - Emit section information for extern variables.

2017-10-04 Thread Nico Weber via cfe-commits
nesday, October 4, 2017 12:59 PM > *To:* Keane, Erich <erich.ke...@intel.com> > *Cc:* cfe-commits <cfe-commits@lists.llvm.org> > *Subject:* Re: r314262 - Emit section information for extern variables. > > > > Hi Erich, > > > > this breaks existing code. N

RE: r314262 - Emit section information for extern variables.

2017-10-04 Thread Keane, Erich via cfe-commits
14262 - Emit section information for extern variables. Hi Erich, this breaks existing code. NaCl does this: #include struct r_debug _r_debug __attribute__((nocommon, section(".r_debug"))); (There's a lengthy-ish comment for why in https://cs.chromium.org/chromium/src/nat

Re: r314262 - Emit section information for extern variables.

2017-10-04 Thread Nico Weber via cfe-commits
Hi Erich, this breaks existing code. NaCl does this: #include struct r_debug _r_debug __attribute__((nocommon, section(".r_debug"))); (There's a lengthy-ish comment for why in