compnerd closed this revision.
compnerd added a comment.
Committed as SVN r249279 (as per your request in the initial revision).
http://reviews.llvm.org/D13322
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mai
wristow added inline comments.
Comment at: lib/Driver/Tools.cpp:4663
@@ +4662,3 @@
+ else if (Args.hasArg(options::OPT_fno_declspec))
+CmdArgs.push_back("-fno-declspec"); // Explicitly disabling __declspec.
+
But in the '-fno-declspec -fdeclspec' case, the 'i
wristow updated this revision to Diff 36373.
wristow added a comment.
Added 4 new tests, the verify the last -fdeclspec/-fno-declspec wins, both in
the context of -fms-extensions and without -fms-extensions.
http://reviews.llvm.org/D13322
Files:
include/clang/Basic/LangOptions.def
include/
compnerd added inline comments.
Comment at: lib/Driver/Tools.cpp:4663
@@ +4662,3 @@
+ else if (Args.hasArg(options::OPT_fno_declspec))
+CmdArgs.push_back("-fno-declspec"); // Explicitly disabling __declspec.
+
@rsmith, so they are. I misread something and wa
wristow updated this revision to Diff 36307.
wristow added a comment.
Updated patch to change the Group of the diagnostic from f_Group to
f_clang_Group, and to change the string associated with the LANGOPT definition
of the flag. Also fixed a minor typo in a comment.
http://reviews.llvm.org/D
wristow added inline comments.
Comment at: include/clang/Basic/LangOptions.def:93
@@ -92,2 +92,3 @@
LANGOPT(WChar , 1, CPlusPlus, "wchar_t keyword")
+LANGOPT(DeclSpecKeyword , 1, 0, "Microsoft __declspec keyword support")
BENIGN_LANGOPT(DollarIdents , 1, 1, "'$'
rsmith added a subscriber: rsmith.
Comment at: include/clang/Basic/LangOptions.def:93
@@ -92,2 +92,3 @@
LANGOPT(WChar , 1, CPlusPlus, "wchar_t keyword")
+LANGOPT(DeclSpecKeyword , 1, 0, "Microsoft __declspec keyword support")
BENIGN_LANGOPT(DollarIdents , 1, 1, "
compnerd added inline comments.
Comment at: include/clang/Basic/LangOptions.def:93
@@ -92,2 +92,3 @@
LANGOPT(WChar , 1, CPlusPlus, "wchar_t keyword")
+LANGOPT(DeclSpecKeyword , 1, 0, "Microsoft __declspec keyword support")
BENIGN_LANGOPT(DollarIdents , 1, 1, "'$'