Re: r326168 - Attempt to fix greendragon bot after r326141

2018-02-27 Thread Reid Kleckner via cfe-commits
bruary 26, 2018 at 9:51 PM > *To: *Shoaib Meenai > *Cc: *Zachary Turner , "cfe-commits@lists.llvm.org" < > cfe-commits@lists.llvm.org>, Reid Kleckner > *Subject: *Re: r326168 - Attempt to fix greendragon bot after r326141 > > > > Yep. > > > > O

Re: r326168 - Attempt to fix greendragon bot after r326141

2018-02-26 Thread Shoaib Meenai via cfe-commits
Zachary Turner Date: Monday, February 26, 2018 at 10:36 PM To: Adam Nemet Cc: Shoaib Meenai , "cfe-commits@lists.llvm.org" , Reid Kleckner Subject: Re: r326168 - Attempt to fix greendragon bot after r326141 So this doesn’t appear to fix the issue that led to my revert earlier. http://l

Re: r326168 - Attempt to fix greendragon bot after r326141

2018-02-26 Thread Zachary Turner via cfe-commits
eep an eye on the bots. >> >> *From: * on behalf of Adam Nemet >> *Date: *Monday, February 26, 2018 at 9:51 PM >> *To: *Shoaib Meenai >> *Cc: *Zachary Turner , "cfe-commits@lists.llvm.org" < >> cfe-commits@lists.llvm.org>, Reid Kleckner >> *Subj

Re: r326168 - Attempt to fix greendragon bot after r326141

2018-02-26 Thread Zachary Turner via cfe-commits
> *Cc: *Zachary Turner , "cfe-commits@lists.llvm.org" < > cfe-commits@lists.llvm.org>, Reid Kleckner > *Subject: *Re: r326168 - Attempt to fix greendragon bot after r326141 > > Yep. > > > On Feb 26, 2018, at 9:50 PM, Shoaib Meenai wrote: > > Reid re-committe

Re: r326168 - Attempt to fix greendragon bot after r326141

2018-02-26 Thread Adam Nemet via cfe-commits
ary 26, 2018 at 9:51 PM > To: Shoaib Meenai > Cc: Zachary Turner , "cfe-commits@lists.llvm.org" > , Reid Kleckner > Subject: Re: r326168 - Attempt to fix greendragon bot after r326141 > > Yep. > > > On Feb 26, 2018, at 9:50 PM, Shoaib Meenai <mailto:smee.

Re: r326168 - Attempt to fix greendragon bot after r326141

2018-02-26 Thread Adam Nemet via cfe-commits
ruary 26, 2018 at 9:51 PM > To: Shoaib Meenai mailto:smee...@fb.com>> > Cc: Zachary Turner mailto:ztur...@google.com>>, > "cfe-commits@lists.llvm.org <mailto:cfe-commits@lists.llvm.org>" > mailto:cfe-commits@lists.llvm.org>>, Reid > Kleckner mailto:

Re: r326168 - Attempt to fix greendragon bot after r326141

2018-02-26 Thread Shoaib Meenai via cfe-commits
r326171 works locally. I'll keep an eye on the bots. From: on behalf of Adam Nemet Date: Monday, February 26, 2018 at 9:51 PM To: Shoaib Meenai Cc: Zachary Turner , "cfe-commits@lists.llvm.org" , Reid Kleckner Subject: Re: r326168 - Attempt to fix greendragon bot after r326141

Re: r326168 - Attempt to fix greendragon bot after r326141

2018-02-26 Thread Adam Nemet via cfe-commits
To: Adam Nemet > Cc: Shoaib Meenai , "cfe-commits@lists.llvm.org" > , Reid Kleckner > Subject: Re: r326168 - Attempt to fix greendragon bot after r326141 > > I already reverted this a long time ago, but if Shoaib has a proper fix that > would be great <> > On

Re: r326168 - Attempt to fix greendragon bot after r326141

2018-02-26 Thread Shoaib Meenai via cfe-commits
nai mailto:smee...@fb.com>> Cc: "cfe-commits@lists.llvm.org<mailto:cfe-commits@lists.llvm.org>" mailto:cfe-commits@lists.llvm.org>>, Reid Kleckner mailto:r...@google.com>>, Zachary Turner mailto:ztur...@google.com>> Subject: Re: r326168 - Attempt to fix greend

Re: r326168 - Attempt to fix greendragon bot after r326141

2018-02-26 Thread Adam Nemet via cfe-commits
the bot after the fix to make sure it stays green. >> >> From: mailto:ane...@apple.com>> on behalf of Adam Nemet >> mailto:ane...@apple.com>> >> Date: Monday, February 26, 2018 at 9:30 PM >> To: Shoaib Meenai mailto:smee...@fb.com>> >> Cc:

Re: r326168 - Attempt to fix greendragon bot after r326141

2018-02-26 Thread Zachary Turner via cfe-commits
locally to confirm the original problem and > my fix. > > *From: * on behalf of Adam Nemet > *Date: *Monday, February 26, 2018 at 9:42 PM > *To: *Shoaib Meenai > *Cc: *"cfe-commits@lists.llvm.org" , Reid > Kleckner , Zachary Turner > *Subject: *Re: r326168 - Attempt

Re: r326168 - Attempt to fix greendragon bot after r326141

2018-02-26 Thread Shoaib Meenai via cfe-commits
met mailto:ane...@apple.com>> Date: Monday, February 26, 2018 at 9:30 PM To: Shoaib Meenai mailto:smee...@fb.com>> Cc: "cfe-commits@lists.llvm.org<mailto:cfe-commits@lists.llvm.org>" mailto:cfe-commits@lists.llvm.org>>, Reid Kleckner mailto:r...@google.com>&g

Re: r326168 - Attempt to fix greendragon bot after r326141

2018-02-26 Thread Adam Nemet via cfe-commits
ib Meenai > Cc: "cfe-commits@lists.llvm.org" , Reid Kleckner > , Zachary Turner > Subject: Re: r326168 - Attempt to fix greendragon bot after r326141 > > This is the bot with the failure: > > http://lab.llvm.org:8080/green/job/clang-stag

Re: r326168 - Attempt to fix greendragon bot after r326141

2018-02-26 Thread Adam Nemet via cfe-commits
behalf of Adam Nemet > Date: Monday, February 26, 2018 at 9:30 PM > To: Shoaib Meenai > Cc: "cfe-commits@lists.llvm.org" , Reid Kleckner > , Zachary Turner > Subject: Re: r326168 - Attempt to fix greendragon bot after r326141 > > I don’t think we can deal with the sl

Re: r326168 - Attempt to fix greendragon bot after r326141

2018-02-26 Thread Shoaib Meenai via cfe-commits
Meenai Cc: "cfe-commits@lists.llvm.org" , Reid Kleckner , Zachary Turner Subject: Re: r326168 - Attempt to fix greendragon bot after r326141 I don’t think we can deal with the slash options: clang-7.0: warning: '/Users/buildslave/jenkins/workspace/apple-clang-master-RA-stage1-cm

Re: r326168 - Attempt to fix greendragon bot after r326141

2018-02-26 Thread Adam Nemet via cfe-commits
I don’t think we can deal with the slash options: clang-7.0: warning: '/Users/buildslave/jenkins/workspace/apple-clang-master-RA-stage1-cmake-incremental/clang/src/tools/clang/test/Driver/codeview-column-info.c' treated as the '/U' option [-Wslash-u-filename] clang-7.0: note: Use '--' to treat s

Re: r326168 - Attempt to fix greendragon bot after r326141

2018-02-26 Thread Shoaib Meenai via cfe-commits
This seems bogus to me. CodeView can be generated on any build platform; it just needs the correct triple, which Reid added in r326144. From: cfe-commits on behalf of Adam Nemet via cfe-commits Reply-To: Adam Nemet Date: Monday, February 26, 2018 at 8:51 PM To: "cfe-commits@lists.llvm.org" S